From: Eryu Guan <guaneryu@gmail.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Brian Foster <bfoster@redhat.com>,
linux-xfs@vger.kernel.org, david@fromorbit.com,
fstests <fstests@vger.kernel.org>
Subject: Re: [PATCH v3] xfs: test agfl reset on bad list wrapping
Date: Mon, 26 Mar 2018 09:22:53 +0800 [thread overview]
Message-ID: <20180326012253.GC30836@localhost.localdomain> (raw)
In-Reply-To: <20180323160817.GJ4818@magnolia>
On Fri, Mar 23, 2018 at 09:08:17AM -0700, Darrick J. Wong wrote:
> > > +
> > > + # Format filesystem
> > > + echo "TEST $cmd" | tee /dev/ttyprintk
> >
> > What's the purpose of writing to /dev/ttyprintk? I don't see how it's
> > used in the test.
>
> It makes it easy to tell which kernel messages came from which runtest()
> invocation so that we can tell if a particular agfl mutation test
> actually triggered the fixup.
This could fail the test if /dev/ttyprintk doesn't exist. It seems
writing to /dev/kmsg works could tell us the same information, and we've
already made sure /dev/kmsg is writable by _require_check_dmesg. IMHO
/dev/kmsg might be a better choice here.
Thanks,
Eryu
next prev parent reply other threads:[~2018-03-26 1:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 16:57 [PATCH v3] xfs: test agfl reset on bad list wrapping Darrick J. Wong
2018-03-22 2:46 ` [PATCH] common/xfs: don't call xfs_scrub on a block device Darrick J. Wong
2018-03-29 10:25 ` Xiao Yang
2018-03-29 15:46 ` Darrick J. Wong
2018-03-22 2:48 ` [PATCH] common/xfs: fix various problems with _supports_xfs_scrub Darrick J. Wong
2018-03-23 5:26 ` [PATCH v3] xfs: test agfl reset on bad list wrapping Eryu Guan
2018-03-23 16:08 ` Darrick J. Wong
2018-03-26 1:22 ` Eryu Guan [this message]
2018-03-28 1:20 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180326012253.GC30836@localhost.localdomain \
--to=guaneryu@gmail.com \
--cc=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.