All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Nipun Gupta <nipun.gupta@nxp.com>
Cc: robin.murphy@arm.com, hch@lst.de, linux@armlinux.org.uk,
	gregkh@linuxfoundation.org, m.szyprowski@samsung.com,
	bhelgaas@google.com, zajec5@gmail.com, andy.gross@linaro.org,
	david.brown@linaro.org, dan.j.williams@intel.com,
	vinod.koul@intel.com, thierry.reding@gmail.com,
	robh+dt@kernel.org, frowand.list@gmail.com,
	jarkko.sakkinen@linux.intel.com, rafael.j.wysocki@intel.com,
	dmitry.torokhov@gmail.com, johan@kernel.org, msuchanek@suse.de,
	linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
	linux-wireless@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-soc@vger.kernel.org, dmaengine@vger.kernel.org,
	dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,
	devicetree@vger.kernel.org, linux-pci@vger.kernel.org,
	bharat.bhushan@nxp.com, leoyang.li@nxp.com
Subject: [v2,2/2] drivers: remove force dma flag from buses
Date: Thu, 22 Mar 2018 09:19:26 +0100	[thread overview]
Message-ID: <20180322081926.GC29444@lst.de> (raw)

> --- a/drivers/dma/qcom/hidma_mgmt.c
> +++ b/drivers/dma/qcom/hidma_mgmt.c
> @@ -398,7 +398,7 @@ static int __init hidma_mgmt_of_populate_channels(struct device_node *np)
>  		}
>  		of_node_get(child);
>  		new_pdev->dev.of_node = child;
> -		of_dma_configure(&new_pdev->dev, child);
> +		of_dma_configure(&new_pdev->dev, child, true);
>  		/*
>  		 * It is assumed that calling of_msi_configure is safe on
>  		 * platforms with or without MSI support.

Where did we mark this bus as force_dma before?

> diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c
> index 9a4f4246..895c83e 100644
> --- a/drivers/of/of_reserved_mem.c
> +++ b/drivers/of/of_reserved_mem.c
> @@ -353,7 +353,7 @@ int of_reserved_mem_device_init_by_idx(struct device *dev,
>  		/* ensure that dma_ops is set for virtual devices
>  		 * using reserved memory
>  		 */
> -		of_dma_configure(dev, np);
> +		of_dma_configure(dev, np, true);

Did all the callers of this one really force dma?  I have a hard time
untangling the call stacks unfortunately.
---
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Nipun Gupta <nipun.gupta-3arQi8VN3Tc@public.gmane.org>
Cc: zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
	david.brown-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	hch-jcswGhMUV9g@public.gmane.org,
	vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	rafael.j.wysocki-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org,
	andy.gross-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	msuchanek-l3A5Bk7waGM@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
	dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	linux-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
	dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	leoyang.li-3arQi8VN3Tc@public.gmane.org,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 2/2] drivers: remove force dma flag from buses
Date: Thu, 22 Mar 2018 09:19:26 +0100	[thread overview]
Message-ID: <20180322081926.GC29444@lst.de> (raw)
In-Reply-To: <1521615323-4752-2-git-send-email-nipun.gupta-3arQi8VN3Tc@public.gmane.org>

> --- a/drivers/dma/qcom/hidma_mgmt.c
> +++ b/drivers/dma/qcom/hidma_mgmt.c
> @@ -398,7 +398,7 @@ static int __init hidma_mgmt_of_populate_channels(struct device_node *np)
>  		}
>  		of_node_get(child);
>  		new_pdev->dev.of_node = child;
> -		of_dma_configure(&new_pdev->dev, child);
> +		of_dma_configure(&new_pdev->dev, child, true);
>  		/*
>  		 * It is assumed that calling of_msi_configure is safe on
>  		 * platforms with or without MSI support.

Where did we mark this bus as force_dma before?

> diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c
> index 9a4f4246..895c83e 100644
> --- a/drivers/of/of_reserved_mem.c
> +++ b/drivers/of/of_reserved_mem.c
> @@ -353,7 +353,7 @@ int of_reserved_mem_device_init_by_idx(struct device *dev,
>  		/* ensure that dma_ops is set for virtual devices
>  		 * using reserved memory
>  		 */
> -		of_dma_configure(dev, np);
> +		of_dma_configure(dev, np, true);

Did all the callers of this one really force dma?  I have a hard time
untangling the call stacks unfortunately.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Nipun Gupta <nipun.gupta@nxp.com>
Cc: robin.murphy@arm.com, hch@lst.de, linux@armlinux.org.uk,
	gregkh@linuxfoundation.org, m.szyprowski@samsung.com,
	bhelgaas@google.com, zajec5@gmail.com, andy.gross@linaro.org,
	david.brown@linaro.org, dan.j.williams@intel.com,
	vinod.koul@intel.com, thierry.reding@gmail.com,
	robh+dt@kernel.org, frowand.list@gmail.com,
	jarkko.sakkinen@linux.intel.com, rafael.j.wysocki@intel.com,
	dmitry.torokhov@gmail.com, johan@kernel.org, msuchanek@suse.de,
	linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
	linux-wireless@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-soc@vger.kernel.org, dmaengine@vger.kernel.org,
	dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,
	devicetree@vger.kernel.org, linux-pci@vger.kernel.org,
	bharat.bhushan@nxp.com, leoyang.li@nxp.com
Subject: Re: [PATCH v2 2/2] drivers: remove force dma flag from buses
Date: Thu, 22 Mar 2018 09:19:26 +0100	[thread overview]
Message-ID: <20180322081926.GC29444@lst.de> (raw)
In-Reply-To: <1521615323-4752-2-git-send-email-nipun.gupta@nxp.com>

> --- a/drivers/dma/qcom/hidma_mgmt.c
> +++ b/drivers/dma/qcom/hidma_mgmt.c
> @@ -398,7 +398,7 @@ static int __init hidma_mgmt_of_populate_channels(struct device_node *np)
>  		}
>  		of_node_get(child);
>  		new_pdev->dev.of_node = child;
> -		of_dma_configure(&new_pdev->dev, child);
> +		of_dma_configure(&new_pdev->dev, child, true);
>  		/*
>  		 * It is assumed that calling of_msi_configure is safe on
>  		 * platforms with or without MSI support.

Where did we mark this bus as force_dma before?

> diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c
> index 9a4f4246..895c83e 100644
> --- a/drivers/of/of_reserved_mem.c
> +++ b/drivers/of/of_reserved_mem.c
> @@ -353,7 +353,7 @@ int of_reserved_mem_device_init_by_idx(struct device *dev,
>  		/* ensure that dma_ops is set for virtual devices
>  		 * using reserved memory
>  		 */
> -		of_dma_configure(dev, np);
> +		of_dma_configure(dev, np, true);

Did all the callers of this one really force dma?  I have a hard time
untangling the call stacks unfortunately.

             reply	other threads:[~2018-03-22  8:19 UTC|newest]

Thread overview: 141+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-22  8:19 Christoph Hellwig [this message]
2018-03-22  8:19 ` [PATCH v2 2/2] drivers: remove force dma flag from buses Christoph Hellwig
2018-03-22  8:19 ` Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2018-05-03 16:36 [v4,2/2] " Vinod Koul
2018-05-03 16:36 ` [PATCH v4 2/2] " Vinod Koul
2018-05-03 16:36 ` Vinod Koul
2018-05-03 12:21 [v4,1/2] dma-mapping: move dma configuration to bus infrastructure Christoph Hellwig
2018-05-03 12:21 ` [PATCH v4 1/2] " Christoph Hellwig
2018-05-03 12:21 ` Christoph Hellwig
2018-05-03 12:21 [v4,1/2] " Christoph Hellwig
2018-05-03 12:21 ` [PATCH v4 1/2] " Christoph Hellwig
2018-05-03 12:21 ` Christoph Hellwig
2018-05-01 12:34 [v4,2/2] drivers: remove force dma flag from buses Rob Herring
2018-05-01 12:34 ` [PATCH v4 2/2] " Rob Herring
2018-05-01 12:34 ` Rob Herring
2018-04-30 10:41 [v4,1/2] dma-mapping: move dma configuration to bus infrastructure Thierry Reding
2018-04-30 10:41 ` [PATCH v4 1/2] " Thierry Reding
2018-04-30 10:41 ` Thierry Reding
2018-04-28  2:51 [v4,2/2] drivers: remove force dma flag from buses Nipun Gupta
2018-04-28  2:51 ` [PATCH v4 2/2] " Nipun Gupta
2018-04-28  2:51 ` Nipun Gupta
2018-04-28  2:51 [v4,1/2] dma-mapping: move dma configuration to bus infrastructure Nipun Gupta
2018-04-28  2:51 ` [PATCH v4 1/2] " Nipun Gupta
2018-04-28  2:51 ` Nipun Gupta
2018-04-27 17:10 [v3,1/2] " Nipun Gupta
2018-04-27 17:10 ` [PATCH v3 1/2] " Nipun Gupta
2018-04-27 17:10 ` Nipun Gupta
2018-04-27 17:10 ` Nipun Gupta
2018-04-23 12:56 [v3,1/2] " Christoph Hellwig
2018-04-23 12:56 ` [PATCH v3 1/2] " Christoph Hellwig
2018-04-23 12:56 ` Christoph Hellwig
2018-04-23 12:56 [v3,1/2] " Christoph Hellwig
2018-04-23 12:56 ` [PATCH v3 1/2] " Christoph Hellwig
2018-04-23 12:56 ` Christoph Hellwig
2018-04-10 19:21 [v3,2/2] drivers: remove force dma flag from buses Bjorn Helgaas
2018-04-10 19:21 ` [PATCH v3 2/2] " Bjorn Helgaas
2018-04-10 19:21 ` Bjorn Helgaas
2018-04-10 19:20 [v3,1/2] dma-mapping: move dma configuration to bus infrastructure Bjorn Helgaas
2018-04-10 19:20 ` [PATCH v3 1/2] " Bjorn Helgaas
2018-04-10 19:20 ` Bjorn Helgaas
2018-04-09 20:27 [v3,2/2] drivers: remove force dma flag from buses Rob Herring
2018-04-09 20:27 ` [PATCH v3 2/2] " Rob Herring
2018-04-09 20:27 ` Rob Herring
2018-03-30  7:54 [v3,2/2] " Nipun Gupta
2018-03-30  7:54 ` [PATCH v3 2/2] " Nipun Gupta
2018-03-30  7:54 ` Nipun Gupta
2018-03-30  7:54 ` Nipun Gupta
2018-03-30  7:54 [v3,1/2] dma-mapping: move dma configuration to bus infrastructure Nipun Gupta
2018-03-30  7:54 ` [PATCH v3 1/2] " Nipun Gupta
2018-03-30  7:54 ` Nipun Gupta
2018-03-30  7:54 ` Nipun Gupta
2018-03-24  9:25 [v2,1/2] " kbuild test robot
2018-03-24  9:25 ` [PATCH v2 1/2] " kbuild test robot
2018-03-24  9:25 ` kbuild test robot
2018-03-23 17:41 [v2,2/2] drivers: remove force dma flag from buses kbuild test robot
2018-03-23 17:41 ` [PATCH v2 2/2] " kbuild test robot
2018-03-23 17:41 ` kbuild test robot
2018-03-23 16:09 [v2,2/2] " kbuild test robot
2018-03-23 16:09 ` [PATCH v2 2/2] " kbuild test robot
2018-03-23 16:09 ` kbuild test robot
2018-03-22 15:13 [v2,2/2] " Nipun Gupta
2018-03-22 15:13 ` [PATCH v2 2/2] " Nipun Gupta
2018-03-22 15:13 ` Nipun Gupta
2018-03-22 15:13 ` Nipun Gupta
2018-03-22 15:05 [v2,1/2] dma-mapping: move dma configuration to bus infrastructure Nipun Gupta
2018-03-22 15:05 ` [PATCH v2 1/2] " Nipun Gupta
2018-03-22 15:05 ` Nipun Gupta
2018-03-22 15:05 ` Nipun Gupta
2018-03-22  8:17 [v2,1/2] " Christoph Hellwig
2018-03-22  8:17 ` [PATCH v2 1/2] " hch
2018-03-22  8:17 ` hch-jcswGhMUV9g
2018-03-22  8:15 [v2,1/2] " Christoph Hellwig
2018-03-22  8:15 ` [PATCH v2 1/2] " Christoph Hellwig
2018-03-22  8:15 ` Christoph Hellwig
2018-03-21 17:49 [v2,2/2] drivers: remove force dma flag from buses Greg Kroah-Hartman
2018-03-21 17:49 ` [PATCH v2 2/2] " Greg KH
2018-03-21 17:49 ` Greg KH
2018-03-21 16:28 [v2,2/2] " Nipun Gupta
2018-03-21 16:28 ` [PATCH v2 2/2] " Nipun Gupta
2018-03-21 16:28 ` Nipun Gupta
2018-03-21 16:28 ` Nipun Gupta
2018-03-21 16:13 [v2,1/2] dma-mapping: move dma configuration to bus infrastructure Nipun Gupta
2018-03-21 16:13 ` [PATCH v2 1/2] " Nipun Gupta
2018-03-21 16:13 ` Nipun Gupta
2018-03-21 16:13 ` Nipun Gupta
2018-03-21  9:35 [v2,2/2] drivers: remove force dma flag from buses Greg Kroah-Hartman
2018-03-21  9:35 ` [PATCH v2 2/2] " Greg KH
2018-03-21  9:35 ` Greg KH
2018-03-21  9:29 [v2,1/2] dma-mapping: move dma configuration to bus infrastructure Greg Kroah-Hartman
2018-03-21  9:29 ` [PATCH v2 1/2] " Greg KH
2018-03-21  9:29 ` Greg KH
2018-03-21  7:29 [v2,1/2] " Nipun Gupta
2018-03-21  7:29 ` [PATCH v2 1/2] " Nipun Gupta
2018-03-21  7:29 ` Nipun Gupta
2018-03-21  7:29 ` Nipun Gupta
2018-03-21  7:19 [v2,1/2] " Bharat Bhushan
2018-03-21  7:19 ` [PATCH v2 1/2] " Bharat Bhushan
2018-03-21  7:19 ` Bharat Bhushan
2018-03-21  7:19 ` Bharat Bhushan
2018-03-21  6:55 [v2,2/2] drivers: remove force dma flag from buses Nipun Gupta
2018-03-21  6:55 ` [PATCH v2 2/2] " Nipun Gupta
2018-03-21  6:55 ` Nipun Gupta
2018-03-21  6:55 [v2,1/2] dma-mapping: move dma configuration to bus infrastructure Nipun Gupta
2018-03-21  6:55 ` [PATCH v2 1/2] " Nipun Gupta
2018-03-21  6:55 ` Nipun Gupta
2018-03-12 15:24 [PATCH] " Nipun Gupta
2018-03-12 15:24 ` Nipun Gupta
     [not found] ` <1520868292-2479-1-git-send-email-nipun.gupta-3arQi8VN3Tc@public.gmane.org>
2018-03-12 16:44   ` Sinan Kaya
2018-03-12 16:44     ` Sinan Kaya
     [not found]     ` <6a76df69-8c6c-52a6-0afd-fd0b8d2ff703-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-03-13  4:22       ` Nipun Gupta
2018-03-13  4:22         ` Nipun Gupta
2018-03-13  4:22         ` Nipun Gupta
     [not found]         ` <HE1PR0401MB24250A8631823FB3108EA62CE6D20-B0v07Ae2taqTjcJO+iVGAo3W/0Ik+aLCnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2018-03-13  7:27           ` hch-jcswGhMUV9g
2018-03-13  7:27             ` hch
2018-03-13  7:34   ` Christoph Hellwig
2018-03-13  7:34     ` Christoph Hellwig
     [not found]     ` <20180313073448.GA32269-jcswGhMUV9g@public.gmane.org>
2018-03-13 15:59       ` Nipun Gupta
2018-03-13 15:59         ` Nipun Gupta
2018-03-13 15:59         ` Nipun Gupta
     [not found]         ` <HE1PR0401MB242509FE2B60674CAF306A4AE6D20-B0v07Ae2taqTjcJO+iVGAo3W/0Ik+aLCnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2018-03-14  9:03           ` Christoph Hellwig
2018-03-14  9:03             ` Christoph Hellwig
2018-03-13 11:35   ` Robin Murphy
2018-03-13 11:35     ` Robin Murphy
     [not found]     ` <a6cd83c9-d769-2994-5230-0a97de1897e5-5wv7dgnIgG8@public.gmane.org>
2018-03-13 16:11       ` Nipun Gupta
2018-03-13 16:11         ` Nipun Gupta
2018-03-13 16:11         ` Nipun Gupta
2018-03-14  9:02       ` Christoph Hellwig
2018-03-14  9:02         ` Christoph Hellwig
2018-03-13 21:53   ` kbuild test robot
2018-03-13 21:53     ` kbuild test robot
2018-03-13 21:53   ` [RFC PATCH] dma-mapping: platform_dma_configure() can be static kbuild test robot
2018-03-13 21:53     ` kbuild test robot
2018-03-14  5:48 ` [dma] 9a019f4251: BUG:unable_to_handle_kernel kernel test robot
2018-03-14  5:48   ` kernel test robot
2018-03-14  5:48   ` kernel test robot
2018-03-30  7:15 ` [PATCH] dma-mapping: move dma configuration to bus infrastructure Christoph Hellwig
     [not found]   ` <20180330071530.GA17557-jcswGhMUV9g@public.gmane.org>
2018-03-30  7:17     ` Nipun Gupta
2018-03-30  7:17       ` Nipun Gupta
2018-03-30  7:17       ` Nipun Gupta
2018-03-30  9:05     ` Greg KH
2018-03-30  9:05       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180322081926.GC29444@lst.de \
    --to=hch@lst.de \
    --cc=andy.gross@linaro.org \
    --cc=bharat.bhushan@nxp.com \
    --cc=bhelgaas@google.com \
    --cc=dan.j.williams@intel.com \
    --cc=david.brown@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=frowand.list@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=johan@kernel.org \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-soc@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=m.szyprowski@samsung.com \
    --cc=msuchanek@suse.de \
    --cc=nipun.gupta@nxp.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=robh+dt@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=thierry.reding@gmail.com \
    --cc=vinod.koul@intel.com \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.