All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>
Cc: forest@alittletooquiet.net, outreachy-kernel@googlegroups.com
Subject: Re: [PATCH 3/5] staging: vt6655: Change typedef struct to struct
Date: Thu, 22 Mar 2018 18:29:14 +0100	[thread overview]
Message-ID: <20180322172914.GA5030@kroah.com> (raw)
In-Reply-To: <1521577679-21104-3-git-send-email-nishka.dasgupta_ug18@ashoka.edu.in>

On Tue, Mar 20, 2018 at 08:27:57PM +0000, Nishka Dasgupta wrote:
> Change typedef struct to struct. Issue found with checkpatch.

Your subject and changelog texts are too generic, say what the name of
the typedef you are changing is, to make it easier to search for later.
And to make your subject lines unique.

I've only applied the first patch in this series, please fix up and redo
all of the others.

thanks,

greg k-h


  reply	other threads:[~2018-03-22 17:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-20 20:27 [PATCH 1/5] staging: vt6655: Change typedef enum to enum Nishka Dasgupta
2018-03-20 20:27 ` [PATCH 2/5] stging: vt6655: Replace typedef enum with enum Nishka Dasgupta
2018-03-20 20:27 ` [PATCH 3/5] staging: vt6655: Change typedef struct to struct Nishka Dasgupta
2018-03-22 17:29   ` Greg KH [this message]
2018-03-20 20:27 ` [PATCH 4/5] staging:vt6655:Delete typedef in typedef enum Nishka Dasgupta
2018-03-20 20:27 ` [PATCH 5/5] staging: vt6655: Remove else after return Nishka Dasgupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180322172914.GA5030@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=forest@alittletooquiet.net \
    --cc=nishka.dasgupta_ug18@ashoka.edu.in \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.