* [PATCH 1/5] staging: vt6655: Change typedef enum to enum
@ 2018-03-20 20:27 Nishka Dasgupta
2018-03-20 20:27 ` [PATCH 2/5] stging: vt6655: Replace typedef enum with enum Nishka Dasgupta
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Nishka Dasgupta @ 2018-03-20 20:27 UTC (permalink / raw)
To: forest, gregkh, outreachy-kernel; +Cc: Nishka Dasgupta
Change typedef enum to enum. Issue found with checkpatch.
Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>
---
drivers/staging/vt6655/card.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/vt6655/card.h b/drivers/staging/vt6655/card.h
index 487039a..be5254a 100644
--- a/drivers/staging/vt6655/card.h
+++ b/drivers/staging/vt6655/card.h
@@ -39,12 +39,12 @@
#define CB_MAX_CHANNEL_5G 42
#define CB_MAX_CHANNEL (CB_MAX_CHANNEL_24G + CB_MAX_CHANNEL_5G)
-typedef enum _CARD_PKT_TYPE {
+enum CARD_PKT_TYPE {
PKT_TYPE_802_11_BCN,
PKT_TYPE_802_11_MNG,
PKT_TYPE_802_11_DATA,
PKT_TYPE_802_11_ALL
-} CARD_PKT_TYPE, *PCARD_PKT_TYPE;
+};
typedef enum _CARD_STATUS_TYPE {
CARD_STATUS_MEDIA_CONNECT,
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/5] stging: vt6655: Replace typedef enum with enum 2018-03-20 20:27 [PATCH 1/5] staging: vt6655: Change typedef enum to enum Nishka Dasgupta @ 2018-03-20 20:27 ` Nishka Dasgupta 2018-03-20 20:27 ` [PATCH 3/5] staging: vt6655: Change typedef struct to struct Nishka Dasgupta ` (2 subsequent siblings) 3 siblings, 0 replies; 6+ messages in thread From: Nishka Dasgupta @ 2018-03-20 20:27 UTC (permalink / raw) To: forest, gregkh, outreachy-kernel; +Cc: Nishka Dasgupta Replace typedef enum with enum. Issue found with checkpatch. Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in> --- drivers/staging/vt6655/card.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vt6655/card.h b/drivers/staging/vt6655/card.h index be5254a..f599624 100644 --- a/drivers/staging/vt6655/card.h +++ b/drivers/staging/vt6655/card.h @@ -46,11 +46,11 @@ enum CARD_PKT_TYPE { PKT_TYPE_802_11_ALL }; -typedef enum _CARD_STATUS_TYPE { +enum CARD_STATUS_TYPE { CARD_STATUS_MEDIA_CONNECT, CARD_STATUS_MEDIA_DISCONNECT, CARD_STATUS_PMKID -} CARD_STATUS_TYPE, *PCARD_STATUS_TYPE; +}; struct vnt_private; -- 2.7.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/5] staging: vt6655: Change typedef struct to struct 2018-03-20 20:27 [PATCH 1/5] staging: vt6655: Change typedef enum to enum Nishka Dasgupta 2018-03-20 20:27 ` [PATCH 2/5] stging: vt6655: Replace typedef enum with enum Nishka Dasgupta @ 2018-03-20 20:27 ` Nishka Dasgupta 2018-03-22 17:29 ` Greg KH 2018-03-20 20:27 ` [PATCH 4/5] staging:vt6655:Delete typedef in typedef enum Nishka Dasgupta 2018-03-20 20:27 ` [PATCH 5/5] staging: vt6655: Remove else after return Nishka Dasgupta 3 siblings, 1 reply; 6+ messages in thread From: Nishka Dasgupta @ 2018-03-20 20:27 UTC (permalink / raw) To: forest, gregkh, outreachy-kernel; +Cc: Nishka Dasgupta Change typedef struct to struct. Issue found with checkpatch. Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in> --- drivers/staging/vt6655/device_cfg.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/vt6655/device_cfg.h b/drivers/staging/vt6655/device_cfg.h index 73f904b..3972881 100644 --- a/drivers/staging/vt6655/device_cfg.h +++ b/drivers/staging/vt6655/device_cfg.h @@ -16,12 +16,11 @@ #include <linux/types.h> -typedef -struct _version { +struct version { unsigned char major; unsigned char minor; unsigned char build; -} version_t, *pversion_t; +}; #define VID_TABLE_SIZE 64 #define MCAST_TABLE_SIZE 64 -- 2.7.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 3/5] staging: vt6655: Change typedef struct to struct 2018-03-20 20:27 ` [PATCH 3/5] staging: vt6655: Change typedef struct to struct Nishka Dasgupta @ 2018-03-22 17:29 ` Greg KH 0 siblings, 0 replies; 6+ messages in thread From: Greg KH @ 2018-03-22 17:29 UTC (permalink / raw) To: Nishka Dasgupta; +Cc: forest, outreachy-kernel On Tue, Mar 20, 2018 at 08:27:57PM +0000, Nishka Dasgupta wrote: > Change typedef struct to struct. Issue found with checkpatch. Your subject and changelog texts are too generic, say what the name of the typedef you are changing is, to make it easier to search for later. And to make your subject lines unique. I've only applied the first patch in this series, please fix up and redo all of the others. thanks, greg k-h ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 4/5] staging:vt6655:Delete typedef in typedef enum 2018-03-20 20:27 [PATCH 1/5] staging: vt6655: Change typedef enum to enum Nishka Dasgupta 2018-03-20 20:27 ` [PATCH 2/5] stging: vt6655: Replace typedef enum with enum Nishka Dasgupta 2018-03-20 20:27 ` [PATCH 3/5] staging: vt6655: Change typedef struct to struct Nishka Dasgupta @ 2018-03-20 20:27 ` Nishka Dasgupta 2018-03-20 20:27 ` [PATCH 5/5] staging: vt6655: Remove else after return Nishka Dasgupta 3 siblings, 0 replies; 6+ messages in thread From: Nishka Dasgupta @ 2018-03-20 20:27 UTC (permalink / raw) To: forest, gregkh, outreachy-kernel; +Cc: Nishka Dasgupta Change typedef enum to enum. Issue found with checkpatch. Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in> --- drivers/staging/vt6655/device_cfg.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vt6655/device_cfg.h b/drivers/staging/vt6655/device_cfg.h index 3972881..2f38634 100644 --- a/drivers/staging/vt6655/device_cfg.h +++ b/drivers/staging/vt6655/device_cfg.h @@ -51,8 +51,8 @@ struct version { #define PKT_BUF_SZ 2390 -typedef enum _chip_type { +enum CHIP_TYPE { VT3253 = 1 -} CHIP_TYPE, *PCHIP_TYPE; +}; #endif -- 2.7.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 5/5] staging: vt6655: Remove else after return 2018-03-20 20:27 [PATCH 1/5] staging: vt6655: Change typedef enum to enum Nishka Dasgupta ` (2 preceding siblings ...) 2018-03-20 20:27 ` [PATCH 4/5] staging:vt6655:Delete typedef in typedef enum Nishka Dasgupta @ 2018-03-20 20:27 ` Nishka Dasgupta 3 siblings, 0 replies; 6+ messages in thread From: Nishka Dasgupta @ 2018-03-20 20:27 UTC (permalink / raw) To: forest, gregkh, outreachy-kernel; +Cc: Nishka Dasgupta Remove else after return. Issue found with checkpatch. Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in> --- drivers/staging/vt6655/rxtx.c | 37 ++++++++++++++++++------------------- 1 file changed, 18 insertions(+), 19 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index 9c4a532..89adee4 100644 --- a/drivers/staging/vt6655/rxtx.c +++ b/drivers/staging/vt6655/rxtx.c @@ -568,28 +568,27 @@ s_uFillDataHead( wCurrentRate, bNeedAck, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption)); buf->time_stamp_off = vnt_time_stamp_off(pDevice, wCurrentRate); return buf->duration; - } else { - struct vnt_tx_datahead_ab *buf = pTxDataHead; - /* Get SignalField, ServiceField & Length */ - vnt_get_phy_field(pDevice, cbFrameLength, wCurrentRate, - byPktType, &buf->ab); - - if (is_pspoll) { - __le16 dur = cpu_to_le16(pDevice->current_aid | BIT(14) | BIT(15)); + } + struct vnt_tx_datahead_ab *buf = pTxDataHead; + /* Get SignalField, ServiceField & Length */ + vnt_get_phy_field(pDevice, cbFrameLength, wCurrentRate, + byPktType, &buf->ab); - buf->duration = dur; - } else { - /* Get Duration and TimeStampOff */ - buf->duration = - cpu_to_le16((u16)s_uGetDataDuration(pDevice, DATADUR_A, cbFrameLength, byPktType, - wCurrentRate, bNeedAck, uFragIdx, - cbLastFragmentSize, uMACfragNum, - byFBOption)); - } + if (is_pspoll) { + __le16 dur = cpu_to_le16(pDevice->current_aid | BIT(14) | BIT(15)); - buf->time_stamp_off = vnt_time_stamp_off(pDevice, wCurrentRate); - return buf->duration; + buf->duration = dur; + } else { + /* Get Duration and TimeStampOff */ + buf->duration = + cpu_to_le16((u16)s_uGetDataDuration(pDevice, DATADUR_A, cbFrameLength, byPktType, + wCurrentRate, bNeedAck, uFragIdx, + cbLastFragmentSize, uMACfragNum, + byFBOption)); } + + buf->time_stamp_off = vnt_time_stamp_off(pDevice, wCurrentRate); + return buf->duration; } else { struct vnt_tx_datahead_ab *buf = pTxDataHead; /* Get SignalField, ServiceField & Length */ -- 2.7.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-03-22 17:29 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-03-20 20:27 [PATCH 1/5] staging: vt6655: Change typedef enum to enum Nishka Dasgupta 2018-03-20 20:27 ` [PATCH 2/5] stging: vt6655: Replace typedef enum with enum Nishka Dasgupta 2018-03-20 20:27 ` [PATCH 3/5] staging: vt6655: Change typedef struct to struct Nishka Dasgupta 2018-03-22 17:29 ` Greg KH 2018-03-20 20:27 ` [PATCH 4/5] staging:vt6655:Delete typedef in typedef enum Nishka Dasgupta 2018-03-20 20:27 ` [PATCH 5/5] staging: vt6655: Remove else after return Nishka Dasgupta
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.