From: mka@chromium.org (Matthias Kaehlcke)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm/arm64: smccc: Use xN for arm64 register constraints with clang
Date: Thu, 22 Mar 2018 15:44:56 -0700 [thread overview]
Message-ID: <20180322224456.GB78232@google.com> (raw)
In-Reply-To: <CAKwvOdk4Tos1Q8dyQvic4PUX3cjy3q1hn3FkK=xiVSChht+gEg@mail.gmail.com>
El Thu, Mar 22, 2018 at 10:26:18PM +0000 Nick Desaulniers ha dit:
> Note that a patch in this form has previously been implemented by:
>
> Andrey Konovalov <andreyknvl@google.com>:
> https://gist.github.com/xairy/ee11682ea86044a45c0291c528cd936f
>
> and another by:
>
> Greg Hackmann <ghackmann@google.com>:
> https://android-review.googlesource.com/c/kernel/common/+/645181
>
> If you used either as a reference, you may want to credit them with a
> `Suggested-by:` in the commit message.
Not really, but I think I prefer Greg's version over mine and might
use it in a respin if nobody raises objections.
> On Thu, Mar 22, 2018 at 2:28 PM Matthias Kaehlcke <mka@chromium.org> wrote:
> > +#ifndef __clang__
> > +#define __reg__ "r"
> > +#else
> > +#define __reg__ "x"
> > +#endif
>
> Can this be flipped to #ifdef __clang__ ? having an if...else where the
> conditional negated is kind of funny.
Sure, my thought was "common case first", but I agree that the negated
condition isn't ideal either.
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Kaehlcke <mka@chromium.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: marc.zyngier@arm.com, Catalin Marinas <catalin.marinas@arm.com>,
Robin Murphy <robin.murphy@arm.com>,
linux-arm-kernel@lists.infradead.org,
LKML <linux-kernel@vger.kernel.org>,
Christoffer Dall <christoffer.dall@linaro.org>,
Dave.Martin@arm.com, Andrey Konovalov <andreyknvl@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
Kostya Serebryany <kcc@google.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Greg Hackmann <ghackmann@google.com>
Subject: Re: [PATCH] arm/arm64: smccc: Use xN for arm64 register constraints with clang
Date: Thu, 22 Mar 2018 15:44:56 -0700 [thread overview]
Message-ID: <20180322224456.GB78232@google.com> (raw)
In-Reply-To: <CAKwvOdk4Tos1Q8dyQvic4PUX3cjy3q1hn3FkK=xiVSChht+gEg@mail.gmail.com>
El Thu, Mar 22, 2018 at 10:26:18PM +0000 Nick Desaulniers ha dit:
> Note that a patch in this form has previously been implemented by:
>
> Andrey Konovalov <andreyknvl@google.com>:
> https://gist.github.com/xairy/ee11682ea86044a45c0291c528cd936f
>
> and another by:
>
> Greg Hackmann <ghackmann@google.com>:
> https://android-review.googlesource.com/c/kernel/common/+/645181
>
> If you used either as a reference, you may want to credit them with a
> `Suggested-by:` in the commit message.
Not really, but I think I prefer Greg's version over mine and might
use it in a respin if nobody raises objections.
> On Thu, Mar 22, 2018 at 2:28 PM Matthias Kaehlcke <mka@chromium.org> wrote:
> > +#ifndef __clang__
> > +#define __reg__ "r"
> > +#else
> > +#define __reg__ "x"
> > +#endif
>
> Can this be flipped to #ifdef __clang__ ? having an if...else where the
> conditional negated is kind of funny.
Sure, my thought was "common case first", but I agree that the negated
condition isn't ideal either.
next prev parent reply other threads:[~2018-03-22 22:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-22 21:27 [PATCH] arm/arm64: smccc: Use xN for arm64 register constraints with clang Matthias Kaehlcke
2018-03-22 21:27 ` Matthias Kaehlcke
2018-03-22 22:26 ` Nick Desaulniers
2018-03-22 22:26 ` Nick Desaulniers
2018-03-22 22:44 ` Matthias Kaehlcke [this message]
2018-03-22 22:44 ` Matthias Kaehlcke
2018-03-22 23:19 ` Greg Hackmann
2018-03-22 23:19 ` Greg Hackmann
2018-03-22 23:58 ` Matthias Kaehlcke
2018-03-22 23:58 ` Matthias Kaehlcke
2018-04-05 18:43 ` Nick Desaulniers
2018-04-05 18:43 ` Nick Desaulniers
2018-04-05 19:21 ` Matthias Kaehlcke
2018-04-05 19:21 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180322224456.GB78232@google.com \
--to=mka@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.