From: James Hogan <jhogan@kernel.org>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: Huacai Chen <chenhc@lemote.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, Russell King <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
linux-sh@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH V3] ZBOOT: fix stack protector in compressed boot phase
Date: Fri, 23 Mar 2018 21:08:12 +0000 [thread overview]
Message-ID: <20180323210811.GD11796@saruman> (raw)
In-Reply-To: <1521777055.1510.9.camel@flygoat.com>
[-- Attachment #1: Type: text/plain, Size: 764 bytes --]
On Fri, Mar 23, 2018 at 11:50:55AM +0800, Jiaxun Yang wrote:
> 在 2018-03-22四的 22:21 +0000，James Hogan写道：
> > Also I think it worth mentioning in the commit message the MIPS
> > configuration you hit this with, presumably a Loongson one? For me
> > decompress_kernel() gets a stack guard on loongson3_defconfig, but
> > not
> > malta_defconfig or malta_defconfig + 64-bit. I presume its sensitive
> > to
> > the compiler inlining stuff into decompress_kernel() or something
> > such
> > that it suddenly qualifies for a stack guard.
>
> Have you tested with CONFIG_CC_STACKPROTECTOR_STRONG=y ?
Yes. for malta_defconfig I could only reproduce by adding an array to
decompress_kernel() so that it would get the guard.
Cheers
James
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: James Hogan <jhogan@kernel.org>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V3] ZBOOT: fix stack protector in compressed boot phase
Date: Fri, 23 Mar 2018 21:08:12 +0000 [thread overview]
Message-ID: <20180323210811.GD11796@saruman> (raw)
In-Reply-To: <1521777055.1510.9.camel@flygoat.com>
[-- Attachment #1: Type: text/plain, Size: 764 bytes --]
On Fri, Mar 23, 2018 at 11:50:55AM +0800, Jiaxun Yang wrote:
> 在 2018-03-22四的 22:21 +0000，James Hogan写道：
> > Also I think it worth mentioning in the commit message the MIPS
> > configuration you hit this with, presumably a Loongson one? For me
> > decompress_kernel() gets a stack guard on loongson3_defconfig, but
> > not
> > malta_defconfig or malta_defconfig + 64-bit. I presume its sensitive
> > to
> > the compiler inlining stuff into decompress_kernel() or something
> > such
> > that it suddenly qualifies for a stack guard.
>
> Have you tested with CONFIG_CC_STACKPROTECTOR_STRONG=y ?
Yes. for malta_defconfig I could only reproduce by adding an array to
decompress_kernel() so that it would get the guard.
Cheers
James
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: jhogan@kernel.org (James Hogan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3] ZBOOT: fix stack protector in compressed boot phase
Date: Fri, 23 Mar 2018 21:08:12 +0000 [thread overview]
Message-ID: <20180323210811.GD11796@saruman> (raw)
In-Reply-To: <1521777055.1510.9.camel@flygoat.com>
On Fri, Mar 23, 2018 at 11:50:55AM +0800, Jiaxun Yang wrote:
> ? 2018-03-22?? 22:21 +0000?James Hogan???
> > Also I think it worth mentioning in the commit message the MIPS
> > configuration you hit this with, presumably a Loongson one? For me
> > decompress_kernel() gets a stack guard on loongson3_defconfig, but
> > not
> > malta_defconfig or malta_defconfig + 64-bit. I presume its sensitive
> > to
> > the compiler inlining stuff into decompress_kernel() or something
> > such
> > that it suddenly qualifies for a stack guard.
>
> Have you tested with CONFIG_CC_STACKPROTECTOR_STRONG=y ?
Yes. for malta_defconfig I could only reproduce by adding an array to
decompress_kernel() so that it would get the guard.
Cheers
James
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180323/6a2e96af/attachment.sig>
next prev parent reply other threads:[~2018-03-23 21:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180316075352epcas5p3d95b13f9382ff7bbce83b8177e8e3ad6@epcas5p3.samsung.com>
2018-03-16 7:55 ` [PATCH V3] ZBOOT: fix stack protector in compressed boot phase Huacai Chen
2018-03-16 7:55 ` Huacai Chen
2018-03-16 7:55 ` Huacai Chen
2018-03-16 22:13 ` Andrew Morton
2018-03-16 22:13 ` Andrew Morton
2018-03-16 22:13 ` Andrew Morton
2018-03-16 23:13 ` Rich Felker
2018-03-16 23:13 ` Rich Felker
2018-03-16 23:13 ` Rich Felker
2018-03-17 11:43 ` Jiaxun Yang
2018-03-22 22:21 ` James Hogan
2018-03-22 22:21 ` James Hogan
2018-03-22 22:21 ` James Hogan
2018-03-23 3:50 ` Jiaxun Yang
2018-03-23 3:50 ` Jiaxun Yang
2018-03-23 3:50 ` Jiaxun Yang
2018-03-23 3:50 ` Jiaxun Yang
2018-03-23 21:08 ` James Hogan [this message]
2018-03-23 21:08 ` James Hogan
2018-03-23 21:08 ` James Hogan
2018-03-23 8:14 ` Marek Szyprowski
2018-03-23 8:14 ` Marek Szyprowski
2018-03-23 8:14 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180323210811.GD11796@saruman \
--to=jhogan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=chenhc@lemote.com \
--cc=dalias@libc.org \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-mm@kvack.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=ralf@linux-mips.org \
--cc=stable@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.