From: Jonathan Cameron <jic23@kernel.org>
To: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
Cc: John Syne <john3909@gmail.com>, Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, Barry Song <21cnbao@gmail.com>,
daniel.baluta@nxp.com
Subject: Re: [PATCH v3 5/8] staging:iio:ade7854: Remove write_reg_* duplications
Date: Sat, 24 Mar 2018 13:26:14 +0000 [thread overview]
Message-ID: <20180324132614.4bbbb419@archlinux> (raw)
In-Reply-To: <f653606d784c5b4dd1b502030a4b0ce43df8e913.1521813782.git.rodrigosiqueiramelo@gmail.com>
On Fri, 23 Mar 2018 11:26:41 -0300
Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com> wrote:
> This patch removes code duplications related to the write_reg_*
> functions and centralizes them in a single function. Also, it eliminates
> the legacy functions and replaces them by a unique signature that is
> used by SPI and I2C.
>
> Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
Applied, thanks.
Jonathan
> ---
> Changes in v3:
> - Update commit message
>
> drivers/staging/iio/meter/ade7854-i2c.c | 33 +--------------------------------
> drivers/staging/iio/meter/ade7854-spi.c | 33 +--------------------------------
> drivers/staging/iio/meter/ade7854.c | 12 ++++++------
> drivers/staging/iio/meter/ade7854.h | 9 ++++-----
> 4 files changed, 12 insertions(+), 75 deletions(-)
>
> diff --git a/drivers/staging/iio/meter/ade7854-i2c.c b/drivers/staging/iio/meter/ade7854-i2c.c
> index c9f46d26b752..29e959fdb932 100644
> --- a/drivers/staging/iio/meter/ade7854-i2c.c
> +++ b/drivers/staging/iio/meter/ade7854-i2c.c
> @@ -65,34 +65,6 @@ static int ade7854_i2c_write_reg(struct device *dev,
> return ret < 0 ? ret : 0;
> }
>
> -static int ade7854_i2c_write_reg_8(struct device *dev,
> - u16 reg_address,
> - u8 val)
> -{
> - return ade7854_i2c_write_reg(dev, reg_address, val, 8);
> -}
> -
> -static int ade7854_i2c_write_reg_16(struct device *dev,
> - u16 reg_address,
> - u16 val)
> -{
> - return ade7854_i2c_write_reg(dev, reg_address, val, 16);
> -}
> -
> -static int ade7854_i2c_write_reg_24(struct device *dev,
> - u16 reg_address,
> - u32 val)
> -{
> - return ade7854_i2c_write_reg(dev, reg_address, val, 24);
> -}
> -
> -static int ade7854_i2c_write_reg_32(struct device *dev,
> - u16 reg_address,
> - u32 val)
> -{
> - return ade7854_i2c_write_reg(dev, reg_address, val, 32);
> -}
> -
> static int ade7854_i2c_read_reg_8(struct device *dev,
> u16 reg_address,
> u8 *val)
> @@ -213,10 +185,7 @@ static int ade7854_i2c_probe(struct i2c_client *client,
> st->read_reg_16 = ade7854_i2c_read_reg_16;
> st->read_reg_24 = ade7854_i2c_read_reg_24;
> st->read_reg_32 = ade7854_i2c_read_reg_32;
> - st->write_reg_8 = ade7854_i2c_write_reg_8;
> - st->write_reg_16 = ade7854_i2c_write_reg_16;
> - st->write_reg_24 = ade7854_i2c_write_reg_24;
> - st->write_reg_32 = ade7854_i2c_write_reg_32;
> + st->write_reg = ade7854_i2c_write_reg;
> st->i2c = client;
> st->irq = client->irq;
>
> diff --git a/drivers/staging/iio/meter/ade7854-spi.c b/drivers/staging/iio/meter/ade7854-spi.c
> index 9c5c16c4d6e0..be7397042850 100644
> --- a/drivers/staging/iio/meter/ade7854-spi.c
> +++ b/drivers/staging/iio/meter/ade7854-spi.c
> @@ -67,34 +67,6 @@ static int ade7854_spi_write_reg(struct device *dev,
> return ret;
> }
>
> -static int ade7854_spi_write_reg_8(struct device *dev,
> - u16 reg_address,
> - u8 val)
> -{
> - return ade7854_spi_write_reg(dev, reg_address, val, 8);
> -}
> -
> -static int ade7854_spi_write_reg_16(struct device *dev,
> - u16 reg_address,
> - u16 val)
> -{
> - return ade7854_spi_write_reg(dev, reg_address, val, 16);
> -}
> -
> -static int ade7854_spi_write_reg_24(struct device *dev,
> - u16 reg_address,
> - u32 val)
> -{
> - return ade7854_spi_write_reg(dev, reg_address, val, 24);
> -}
> -
> -static int ade7854_spi_write_reg_32(struct device *dev,
> - u16 reg_address,
> - u32 val)
> -{
> - return ade7854_spi_write_reg(dev, reg_address, val, 32);
> -}
> -
> static int ade7854_spi_read_reg_8(struct device *dev,
> u16 reg_address,
> u8 *val)
> @@ -260,10 +232,7 @@ static int ade7854_spi_probe(struct spi_device *spi)
> st->read_reg_16 = ade7854_spi_read_reg_16;
> st->read_reg_24 = ade7854_spi_read_reg_24;
> st->read_reg_32 = ade7854_spi_read_reg_32;
> - st->write_reg_8 = ade7854_spi_write_reg_8;
> - st->write_reg_16 = ade7854_spi_write_reg_16;
> - st->write_reg_24 = ade7854_spi_write_reg_24;
> - st->write_reg_32 = ade7854_spi_write_reg_32;
> + st->write_reg = ade7854_spi_write_reg;
> st->irq = spi->irq;
> st->spi = spi;
>
> diff --git a/drivers/staging/iio/meter/ade7854.c b/drivers/staging/iio/meter/ade7854.c
> index 0193ae3aae29..45984b9a2bee 100644
> --- a/drivers/staging/iio/meter/ade7854.c
> +++ b/drivers/staging/iio/meter/ade7854.c
> @@ -105,7 +105,7 @@ static ssize_t ade7854_write_8bit(struct device *dev,
> ret = kstrtou8(buf, 10, &val);
> if (ret)
> goto error_ret;
> - ret = st->write_reg_8(dev, this_attr->address, val);
> + ret = st->write_reg(dev, this_attr->address, val, 8);
>
> error_ret:
> return ret ? ret : len;
> @@ -126,7 +126,7 @@ static ssize_t ade7854_write_16bit(struct device *dev,
> ret = kstrtou16(buf, 10, &val);
> if (ret)
> goto error_ret;
> - ret = st->write_reg_16(dev, this_attr->address, val);
> + ret = st->write_reg(dev, this_attr->address, val, 16);
>
> error_ret:
> return ret ? ret : len;
> @@ -147,7 +147,7 @@ static ssize_t ade7854_write_24bit(struct device *dev,
> ret = kstrtou32(buf, 10, &val);
> if (ret)
> goto error_ret;
> - ret = st->write_reg_24(dev, this_attr->address, val);
> + ret = st->write_reg(dev, this_attr->address, val, 24);
>
> error_ret:
> return ret ? ret : len;
> @@ -168,7 +168,7 @@ static ssize_t ade7854_write_32bit(struct device *dev,
> ret = kstrtou32(buf, 10, &val);
> if (ret)
> goto error_ret;
> - ret = st->write_reg_32(dev, this_attr->address, val);
> + ret = st->write_reg(dev, this_attr->address, val, 32);
>
> error_ret:
> return ret ? ret : len;
> @@ -183,7 +183,7 @@ static int ade7854_reset(struct device *dev)
> st->read_reg_16(dev, ADE7854_CONFIG, &val);
> val |= BIT(7); /* Software Chip Reset */
>
> - return st->write_reg_16(dev, ADE7854_CONFIG, val);
> + return st->write_reg(dev, ADE7854_CONFIG, val, 16);
> }
>
> static IIO_DEV_ATTR_AIGAIN(0644,
> @@ -426,7 +426,7 @@ static int ade7854_set_irq(struct device *dev, bool enable)
> else
> irqen &= ~BIT(17);
>
> - return st->write_reg_32(dev, ADE7854_MASK0, irqen);
> + return st->write_reg(dev, ADE7854_MASK0, irqen, 32);
> }
>
> static int ade7854_initial_setup(struct iio_dev *indio_dev)
> diff --git a/drivers/staging/iio/meter/ade7854.h b/drivers/staging/iio/meter/ade7854.h
> index a82d38224cbd..290adbf56951 100644
> --- a/drivers/staging/iio/meter/ade7854.h
> +++ b/drivers/staging/iio/meter/ade7854.h
> @@ -145,7 +145,8 @@
>
> /**
> * struct ade7854_state - device instance specific data
> - * @spi: actual spi_device
> + * @spi: actual spi_device
> + * @write_reg Wrapper function for I2C and SPI write
> * @indio_dev: industrial I/O device structure
> * @buf_lock: mutex to protect tx and rx
> * @tx: transmit buffer
> @@ -158,10 +159,8 @@ struct ade7854_state {
> int (*read_reg_16)(struct device *dev, u16 reg_address, u16 *val);
> int (*read_reg_24)(struct device *dev, u16 reg_address, u32 *val);
> int (*read_reg_32)(struct device *dev, u16 reg_address, u32 *val);
> - int (*write_reg_8)(struct device *dev, u16 reg_address, u8 val);
> - int (*write_reg_16)(struct device *dev, u16 reg_address, u16 val);
> - int (*write_reg_24)(struct device *dev, u16 reg_address, u32 val);
> - int (*write_reg_32)(struct device *dev, u16 reg_address, u32 val);
> + int (*write_reg)(struct device *dev, u16 reg_address, u32 val,
> + int bits);
> int irq;
> struct mutex buf_lock;
> u8 tx[ADE7854_MAX_TX] ____cacheline_aligned;
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org>
To: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
Cc: devel@driverdev.osuosl.org, Lars-Peter Clausen <lars@metafoo.de>,
linux-iio@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Barry Song <21cnbao@gmail.com>,
linux-kernel@vger.kernel.org,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Hartmut Knaack <knaack.h@gmx.de>,
daniel.baluta@nxp.com
Subject: Re: [PATCH v3 5/8] staging:iio:ade7854: Remove write_reg_* duplications
Date: Sat, 24 Mar 2018 13:26:14 +0000 [thread overview]
Message-ID: <20180324132614.4bbbb419@archlinux> (raw)
In-Reply-To: <f653606d784c5b4dd1b502030a4b0ce43df8e913.1521813782.git.rodrigosiqueiramelo@gmail.com>
On Fri, 23 Mar 2018 11:26:41 -0300
Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com> wrote:
> This patch removes code duplications related to the write_reg_*
> functions and centralizes them in a single function. Also, it eliminates
> the legacy functions and replaces them by a unique signature that is
> used by SPI and I2C.
>
> Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
Applied, thanks.
Jonathan
> ---
> Changes in v3:
> - Update commit message
>
> drivers/staging/iio/meter/ade7854-i2c.c | 33 +--------------------------------
> drivers/staging/iio/meter/ade7854-spi.c | 33 +--------------------------------
> drivers/staging/iio/meter/ade7854.c | 12 ++++++------
> drivers/staging/iio/meter/ade7854.h | 9 ++++-----
> 4 files changed, 12 insertions(+), 75 deletions(-)
>
> diff --git a/drivers/staging/iio/meter/ade7854-i2c.c b/drivers/staging/iio/meter/ade7854-i2c.c
> index c9f46d26b752..29e959fdb932 100644
> --- a/drivers/staging/iio/meter/ade7854-i2c.c
> +++ b/drivers/staging/iio/meter/ade7854-i2c.c
> @@ -65,34 +65,6 @@ static int ade7854_i2c_write_reg(struct device *dev,
> return ret < 0 ? ret : 0;
> }
>
> -static int ade7854_i2c_write_reg_8(struct device *dev,
> - u16 reg_address,
> - u8 val)
> -{
> - return ade7854_i2c_write_reg(dev, reg_address, val, 8);
> -}
> -
> -static int ade7854_i2c_write_reg_16(struct device *dev,
> - u16 reg_address,
> - u16 val)
> -{
> - return ade7854_i2c_write_reg(dev, reg_address, val, 16);
> -}
> -
> -static int ade7854_i2c_write_reg_24(struct device *dev,
> - u16 reg_address,
> - u32 val)
> -{
> - return ade7854_i2c_write_reg(dev, reg_address, val, 24);
> -}
> -
> -static int ade7854_i2c_write_reg_32(struct device *dev,
> - u16 reg_address,
> - u32 val)
> -{
> - return ade7854_i2c_write_reg(dev, reg_address, val, 32);
> -}
> -
> static int ade7854_i2c_read_reg_8(struct device *dev,
> u16 reg_address,
> u8 *val)
> @@ -213,10 +185,7 @@ static int ade7854_i2c_probe(struct i2c_client *client,
> st->read_reg_16 = ade7854_i2c_read_reg_16;
> st->read_reg_24 = ade7854_i2c_read_reg_24;
> st->read_reg_32 = ade7854_i2c_read_reg_32;
> - st->write_reg_8 = ade7854_i2c_write_reg_8;
> - st->write_reg_16 = ade7854_i2c_write_reg_16;
> - st->write_reg_24 = ade7854_i2c_write_reg_24;
> - st->write_reg_32 = ade7854_i2c_write_reg_32;
> + st->write_reg = ade7854_i2c_write_reg;
> st->i2c = client;
> st->irq = client->irq;
>
> diff --git a/drivers/staging/iio/meter/ade7854-spi.c b/drivers/staging/iio/meter/ade7854-spi.c
> index 9c5c16c4d6e0..be7397042850 100644
> --- a/drivers/staging/iio/meter/ade7854-spi.c
> +++ b/drivers/staging/iio/meter/ade7854-spi.c
> @@ -67,34 +67,6 @@ static int ade7854_spi_write_reg(struct device *dev,
> return ret;
> }
>
> -static int ade7854_spi_write_reg_8(struct device *dev,
> - u16 reg_address,
> - u8 val)
> -{
> - return ade7854_spi_write_reg(dev, reg_address, val, 8);
> -}
> -
> -static int ade7854_spi_write_reg_16(struct device *dev,
> - u16 reg_address,
> - u16 val)
> -{
> - return ade7854_spi_write_reg(dev, reg_address, val, 16);
> -}
> -
> -static int ade7854_spi_write_reg_24(struct device *dev,
> - u16 reg_address,
> - u32 val)
> -{
> - return ade7854_spi_write_reg(dev, reg_address, val, 24);
> -}
> -
> -static int ade7854_spi_write_reg_32(struct device *dev,
> - u16 reg_address,
> - u32 val)
> -{
> - return ade7854_spi_write_reg(dev, reg_address, val, 32);
> -}
> -
> static int ade7854_spi_read_reg_8(struct device *dev,
> u16 reg_address,
> u8 *val)
> @@ -260,10 +232,7 @@ static int ade7854_spi_probe(struct spi_device *spi)
> st->read_reg_16 = ade7854_spi_read_reg_16;
> st->read_reg_24 = ade7854_spi_read_reg_24;
> st->read_reg_32 = ade7854_spi_read_reg_32;
> - st->write_reg_8 = ade7854_spi_write_reg_8;
> - st->write_reg_16 = ade7854_spi_write_reg_16;
> - st->write_reg_24 = ade7854_spi_write_reg_24;
> - st->write_reg_32 = ade7854_spi_write_reg_32;
> + st->write_reg = ade7854_spi_write_reg;
> st->irq = spi->irq;
> st->spi = spi;
>
> diff --git a/drivers/staging/iio/meter/ade7854.c b/drivers/staging/iio/meter/ade7854.c
> index 0193ae3aae29..45984b9a2bee 100644
> --- a/drivers/staging/iio/meter/ade7854.c
> +++ b/drivers/staging/iio/meter/ade7854.c
> @@ -105,7 +105,7 @@ static ssize_t ade7854_write_8bit(struct device *dev,
> ret = kstrtou8(buf, 10, &val);
> if (ret)
> goto error_ret;
> - ret = st->write_reg_8(dev, this_attr->address, val);
> + ret = st->write_reg(dev, this_attr->address, val, 8);
>
> error_ret:
> return ret ? ret : len;
> @@ -126,7 +126,7 @@ static ssize_t ade7854_write_16bit(struct device *dev,
> ret = kstrtou16(buf, 10, &val);
> if (ret)
> goto error_ret;
> - ret = st->write_reg_16(dev, this_attr->address, val);
> + ret = st->write_reg(dev, this_attr->address, val, 16);
>
> error_ret:
> return ret ? ret : len;
> @@ -147,7 +147,7 @@ static ssize_t ade7854_write_24bit(struct device *dev,
> ret = kstrtou32(buf, 10, &val);
> if (ret)
> goto error_ret;
> - ret = st->write_reg_24(dev, this_attr->address, val);
> + ret = st->write_reg(dev, this_attr->address, val, 24);
>
> error_ret:
> return ret ? ret : len;
> @@ -168,7 +168,7 @@ static ssize_t ade7854_write_32bit(struct device *dev,
> ret = kstrtou32(buf, 10, &val);
> if (ret)
> goto error_ret;
> - ret = st->write_reg_32(dev, this_attr->address, val);
> + ret = st->write_reg(dev, this_attr->address, val, 32);
>
> error_ret:
> return ret ? ret : len;
> @@ -183,7 +183,7 @@ static int ade7854_reset(struct device *dev)
> st->read_reg_16(dev, ADE7854_CONFIG, &val);
> val |= BIT(7); /* Software Chip Reset */
>
> - return st->write_reg_16(dev, ADE7854_CONFIG, val);
> + return st->write_reg(dev, ADE7854_CONFIG, val, 16);
> }
>
> static IIO_DEV_ATTR_AIGAIN(0644,
> @@ -426,7 +426,7 @@ static int ade7854_set_irq(struct device *dev, bool enable)
> else
> irqen &= ~BIT(17);
>
> - return st->write_reg_32(dev, ADE7854_MASK0, irqen);
> + return st->write_reg(dev, ADE7854_MASK0, irqen, 32);
> }
>
> static int ade7854_initial_setup(struct iio_dev *indio_dev)
> diff --git a/drivers/staging/iio/meter/ade7854.h b/drivers/staging/iio/meter/ade7854.h
> index a82d38224cbd..290adbf56951 100644
> --- a/drivers/staging/iio/meter/ade7854.h
> +++ b/drivers/staging/iio/meter/ade7854.h
> @@ -145,7 +145,8 @@
>
> /**
> * struct ade7854_state - device instance specific data
> - * @spi: actual spi_device
> + * @spi: actual spi_device
> + * @write_reg Wrapper function for I2C and SPI write
> * @indio_dev: industrial I/O device structure
> * @buf_lock: mutex to protect tx and rx
> * @tx: transmit buffer
> @@ -158,10 +159,8 @@ struct ade7854_state {
> int (*read_reg_16)(struct device *dev, u16 reg_address, u16 *val);
> int (*read_reg_24)(struct device *dev, u16 reg_address, u32 *val);
> int (*read_reg_32)(struct device *dev, u16 reg_address, u32 *val);
> - int (*write_reg_8)(struct device *dev, u16 reg_address, u8 val);
> - int (*write_reg_16)(struct device *dev, u16 reg_address, u16 val);
> - int (*write_reg_24)(struct device *dev, u16 reg_address, u32 val);
> - int (*write_reg_32)(struct device *dev, u16 reg_address, u32 val);
> + int (*write_reg)(struct device *dev, u16 reg_address, u32 val,
> + int bits);
> int irq;
> struct mutex buf_lock;
> u8 tx[ADE7854_MAX_TX] ____cacheline_aligned;
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2018-03-24 13:26 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 14:21 [PATCH v3 0/8] Cleanup on I2C/SPI code Rodrigo Siqueira
2018-03-23 14:21 ` Rodrigo Siqueira
2018-03-23 14:22 ` [PATCH v3 1/8] staging:iio:ade7854: Fix error handling on read/write John Syne
2018-03-23 14:22 ` John Syne
2018-03-24 12:41 ` Jonathan Cameron
2018-03-24 12:41 ` Jonathan Cameron
2018-03-23 14:25 ` [PATCH v3 2/8] staging:iio:ade7854: Fix the wrong number of bits to read John Syne
2018-03-23 14:25 ` John Syne
2018-03-24 13:23 ` Jonathan Cameron
2018-03-24 13:23 ` Jonathan Cameron
2018-03-23 14:26 ` [PATCH v3 3/8] staging:iio:ade7854: Rework I2C write function Rodrigo Siqueira
2018-03-23 14:26 ` Rodrigo Siqueira
2018-03-24 13:24 ` Jonathan Cameron
2018-03-24 13:24 ` Jonathan Cameron
2018-03-23 14:26 ` [PATCH v3 4/8] staging:iio:ade7854: Rework SPI " Rodrigo Siqueira
2018-03-23 14:26 ` Rodrigo Siqueira
2018-03-24 13:25 ` Jonathan Cameron
2018-03-24 13:25 ` Jonathan Cameron
2018-03-23 14:26 ` [PATCH v3 5/8] staging:iio:ade7854: Remove write_reg_* duplications Rodrigo Siqueira
2018-03-23 14:26 ` Rodrigo Siqueira
2018-03-24 13:26 ` Jonathan Cameron [this message]
2018-03-24 13:26 ` Jonathan Cameron
2018-03-23 14:26 ` [PATCH v3 6/8] staging:iio:ade7854: Rework I2C read function Rodrigo Siqueira
2018-03-23 14:26 ` Rodrigo Siqueira
2018-03-24 13:27 ` Jonathan Cameron
2018-03-24 13:27 ` Jonathan Cameron
2018-03-23 14:27 ` [PATCH v3 7/8] staging:iio:ade7854: Rework SPI " Rodrigo Siqueira
2018-03-23 14:27 ` Rodrigo Siqueira
2018-03-24 13:28 ` Jonathan Cameron
2018-03-24 13:28 ` Jonathan Cameron
2018-03-23 14:27 ` [PATCH v3 8/8] staging:iio:ade7854: Remove read_reg_* duplications Rodrigo Siqueira
2018-03-23 14:27 ` Rodrigo Siqueira
2018-03-24 13:29 ` Jonathan Cameron
2018-03-24 13:29 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180324132614.4bbbb419@archlinux \
--to=jic23@kernel.org \
--cc=21cnbao@gmail.com \
--cc=daniel.baluta@nxp.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=john3909@gmail.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=rodrigosiqueiramelo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.