From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Konrad Rzeszutek Wilk
<konrad.wilk-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org,
mingo-X9Un+BFzKDI@public.gmane.org,
Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] swiotlb: swiotlb_{alloc,free}_buffer should depend on CONFIG_DMA_DIRECT_OPS
Date: Sat, 24 Mar 2018 18:03:51 +0100 [thread overview]
Message-ID: <20180324170351.GA511@lst.de> (raw)
In-Reply-To: <20180323185707.GD25533-he5eyhs8q0BAdwtm4QZOy9BPR1lH4CV8@public.gmane.org>
On Fri, Mar 23, 2018 at 02:57:07PM -0400, Konrad Rzeszutek Wilk wrote:
> On Fri, Mar 23, 2018 at 06:49:30PM +0100, Christoph Hellwig wrote:
> > Otherwise we might get unused symbol warnings for configs that built
> > swiotlb.c only for use by xen-swiotlb.c and that don't otherwise select
> > CONFIG_DMA_DIRECT_OPS, which is possible on arm.
> >
> > Fixes: 16e73adbca76 ("dma/swiotlb: Remove swiotlb_{alloc,free}_coherent()")
> > Reported-by: Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
> > Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
>
>
> Alternatively could we set the Kconfig to slect DMA_DIRECT_OPS?
IFF we build swiotlb.c only for xen-swiotlb we don't need DMA_DIRECT_OPS.
IF you are fine with just requring it as well that would be doable nicely
only if we consolidate to a single defintion of CONFIG_SWIOTLB instead
of one per architecture. Which is something we should do anyway,
so I'll look into it once I get some time.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
tglx@linutronix.de, mingo@elte.hu, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org
Subject: Re: [PATCH] swiotlb: swiotlb_{alloc,free}_buffer should depend on CONFIG_DMA_DIRECT_OPS
Date: Sat, 24 Mar 2018 18:03:51 +0100 [thread overview]
Message-ID: <20180324170351.GA511@lst.de> (raw)
In-Reply-To: <20180323185707.GD25533@char.us.oracle.com>
On Fri, Mar 23, 2018 at 02:57:07PM -0400, Konrad Rzeszutek Wilk wrote:
> On Fri, Mar 23, 2018 at 06:49:30PM +0100, Christoph Hellwig wrote:
> > Otherwise we might get unused symbol warnings for configs that built
> > swiotlb.c only for use by xen-swiotlb.c and that don't otherwise select
> > CONFIG_DMA_DIRECT_OPS, which is possible on arm.
> >
> > Fixes: 16e73adbca76 ("dma/swiotlb: Remove swiotlb_{alloc,free}_coherent()")
> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
>
> Alternatively could we set the Kconfig to slect DMA_DIRECT_OPS?
IFF we build swiotlb.c only for xen-swiotlb we don't need DMA_DIRECT_OPS.
IF you are fine with just requring it as well that would be doable nicely
only if we consolidate to a single defintion of CONFIG_SWIOTLB instead
of one per architecture. Which is something we should do anyway,
so I'll look into it once I get some time.
next prev parent reply other threads:[~2018-03-24 17:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 17:49 [PATCH] swiotlb: swiotlb_{alloc, free}_buffer should depend on CONFIG_DMA_DIRECT_OPS Christoph Hellwig
2018-03-23 17:49 ` [PATCH] swiotlb: swiotlb_{alloc,free}_buffer " Christoph Hellwig
[not found] ` <20180323174930.17767-1-hch-jcswGhMUV9g@public.gmane.org>
2018-03-23 18:57 ` Konrad Rzeszutek Wilk
2018-03-23 18:57 ` Konrad Rzeszutek Wilk
2018-03-23 19:41 ` Thomas Gleixner
[not found] ` <20180323185707.GD25533-he5eyhs8q0BAdwtm4QZOy9BPR1lH4CV8@public.gmane.org>
2018-03-24 17:03 ` Christoph Hellwig [this message]
2018-03-24 17:03 ` Christoph Hellwig
[not found] ` <20180324170351.GA511-jcswGhMUV9g@public.gmane.org>
2018-03-24 20:05 ` Konrad Rzeszutek Wilk
2018-03-24 20:05 ` Konrad Rzeszutek Wilk
[not found] ` <20180324200545.GC23658-he5eyhs8q0BAdwtm4QZOy9BPR1lH4CV8@public.gmane.org>
2018-03-26 13:42 ` Christoph Hellwig
2018-03-26 13:42 ` Christoph Hellwig
2018-03-23 19:54 ` [tip:x86/dma] swiotlb: Make swiotlb_{alloc,free}_buffer " tip-bot for Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180324170351.GA511@lst.de \
--to=hch-jcswghmuv9g@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=konrad.wilk-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mingo-X9Un+BFzKDI@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.