From: Pavel Machek <pavel@ucw.cz>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Thierry Reding <thierry.reding@gmail.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Richard Purdie <rpurdie@rpsys.net>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, groeck@chromium.org,
linux-rockchip@lists.infradead.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCH v6 1/5] pwm-backlight: enable/disable the PWM before/after LCD enable toggle.
Date: Mon, 26 Mar 2018 10:42:05 +0000 [thread overview]
Message-ID: <20180326104205.GA12425@amd> (raw)
In-Reply-To: <20180326095213.18362-1-enric.balletbo@collabora.com>
[-- Attachment #1: Type: text/plain, Size: 832 bytes --]
On Mon 2018-03-26 11:52:09, Enric Balletbo i Serra wrote:
> Before this patch the enable signal was set before the PWM signal and
> vice-versa on power off. This sequence is wrong, at least, it is on
> the different panels datasheets that I checked, so I inverted the sequence
> to follow the specs.
>
> For reference the following panels have the mentioned sequence:
> - N133HSE-EA1 (Innolux)
> - N116BGE (Innolux)
> - N156BGE-L21 (Innolux)
> - B101EAN0 (Auo)
> - B101AW03 (Auo)
> - LTN101NT05 (Samsung)
> - CLAA101WA01A (Chunghwa)
Ok, but this changes behaviour for other panels, too. Are you sure you
are not breaking one of those?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Thierry Reding <thierry.reding@gmail.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Richard Purdie <rpurdie@rpsys.net>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, groeck@chromium.org,
linux-rockchip@lists.infradead.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCH v6 1/5] pwm-backlight: enable/disable the PWM before/after LCD enable toggle.
Date: Mon, 26 Mar 2018 12:42:05 +0200 [thread overview]
Message-ID: <20180326104205.GA12425@amd> (raw)
In-Reply-To: <20180326095213.18362-1-enric.balletbo@collabora.com>
[-- Attachment #1: Type: text/plain, Size: 832 bytes --]
On Mon 2018-03-26 11:52:09, Enric Balletbo i Serra wrote:
> Before this patch the enable signal was set before the PWM signal and
> vice-versa on power off. This sequence is wrong, at least, it is on
> the different panels datasheets that I checked, so I inverted the sequence
> to follow the specs.
>
> For reference the following panels have the mentioned sequence:
> - N133HSE-EA1 (Innolux)
> - N116BGE (Innolux)
> - N156BGE-L21 (Innolux)
> - B101EAN0 (Auo)
> - B101AW03 (Auo)
> - LTN101NT05 (Samsung)
> - CLAA101WA01A (Chunghwa)
Ok, but this changes behaviour for other panels, too. Are you sure you
are not breaking one of those?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2018-03-26 10:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 9:52 [PATCH v6 1/5] pwm-backlight: enable/disable the PWM before/after LCD enable toggle Enric Balletbo i Serra
2018-03-26 9:52 ` Enric Balletbo i Serra
2018-03-26 9:52 ` Enric Balletbo i Serra
[not found] ` <20180326095213.18362-1-enric.balletbo-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2018-03-26 9:52 ` [PATCH v6 2/5] dt-bindings: pwm-backlight: add PWM delay proprieties Enric Balletbo i Serra
2018-03-26 9:52 ` Enric Balletbo i Serra
2018-03-26 9:52 ` Enric Balletbo i Serra
2018-03-26 15:07 ` Daniel Thompson
2018-03-26 15:07 ` Daniel Thompson
2018-03-27 15:08 ` Rob Herring
2018-03-27 15:08 ` Rob Herring
2018-03-26 9:52 ` [PATCH v6 3/5] pwm-backlight: add support for PWM delays proprieties Enric Balletbo i Serra
2018-03-26 9:52 ` Enric Balletbo i Serra
2018-03-26 9:52 ` Enric Balletbo i Serra
2018-03-26 9:52 ` [PATCH v6 5/5] ARM: dts: rockchip: set PWM delay backlight settings for Minnie Enric Balletbo i Serra
2018-03-26 9:52 ` Enric Balletbo i Serra
2018-03-26 9:52 ` Enric Balletbo i Serra
2018-03-26 9:52 ` [PATCH v6 4/5] ARM: dts: rockchip: set PWM delay backlight settings for Veyron Enric Balletbo i Serra
2018-03-26 9:52 ` Enric Balletbo i Serra
2018-03-26 10:42 ` Pavel Machek [this message]
2018-03-26 10:42 ` [PATCH v6 1/5] pwm-backlight: enable/disable the PWM before/after LCD enable toggle Pavel Machek
2018-03-26 14:40 ` Enric Balletbo Serra
2018-03-26 14:40 ` Enric Balletbo Serra
2018-03-26 15:18 ` Daniel Thompson
2018-03-26 15:18 ` Daniel Thompson
2018-03-28 11:12 ` Lee Jones
2018-03-28 11:12 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180326104205.GA12425@amd \
--to=pavel@ucw.cz \
--cc=b.zolnierkie@samsung.com \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=heiko@sntech.de \
--cc=jacek.anaszewski@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=kernel@collabora.com \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=rpurdie@rpsys.net \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.