[Buildroot] [PATCH 1/1] Makefile: fix build break in sdk target

[Buildroot] [PATCH 1/1] Makefile: fix build break in sdk target

[Peter Korsgaard]

>>>>> "Stefan" == Stefan Becker <chemobejk@gmail.com> writes:

 > After commit 6729050f3a49dba42d2d881d31dbefd6b82b8dad nothing creates
 > $(HOST_DIR)/share/buildroot anymore, causing sdk to fail with:

 >  /bin/bash: .../output/host/share/buildroot/sdk-location: No such file or directory

 > Add creation of that directory to the "sdk" build steps itself.

 > Signed-off-by: Stefan Becker <chemobejk@gmail.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 1/1] Makefile: fix build break in sdk target

[Thomas Petazzoni]

Hello,

On Mon, 26 Mar 2018 10:23:32 +0300, Stefan Becker wrote:
> After commit 6729050f3a49dba42d2d881d31dbefd6b82b8dad nothing creates
> $(HOST_DIR)/share/buildroot anymore, causing sdk to fail with:
> 
>  /bin/bash: .../output/host/share/buildroot/sdk-location: No such file or directory
> 
> Add creation of that directory to the "sdk" build steps itself.
> 
> Signed-off-by: Stefan Becker <chemobejk@gmail.com>
> ---
>  Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Makefile b/Makefile
> index a3a9d290d9..9e2402d7d9 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -574,6 +574,7 @@ sdk: world
>  	$(TOPDIR)/support/scripts/fix-rpath host
>  	$(TOPDIR)/support/scripts/fix-rpath staging
>  	$(INSTALL) -m 755 $(TOPDIR)/support/misc/relocate-sdk.sh $(HOST_DIR)/relocate-sdk.sh
> +	mkdir -p $(HOST_DIR)/share/buildroot

While this is OK, I am still not sure to understand why you are seeing
this problem. My commit 6729050f3a49dba42d2d881d31dbefd6b82b8dad moved
the creation of the $(HOST_DIR)/share/buildroot folder from a
dependency of the toolchain package, to a post-install staging hook of
the toolchain package.

But in both cases, the logic should be executed way before
the sdk target is called.

So, I'm puzzled.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/1] Makefile: fix build break in sdk target

[Stefan Becker]

Hi,

On Mon, Mar 26, 2018 at 12:21 PM, Stefan Becker <chemobejk@gmail.com> wrote:

> On Mon, Mar 26, 2018 at 12:16 PM, Thomas Petazzoni <
> thomas.petazzoni at bootlin.com> wrote:
>
>> Hello,
>>
>> While this is OK, I am still not sure to understand why you are seeing
>> this problem. My commit 6729050f3a49dba42d2d881d31dbefd6b82b8dad moved
>> the creation of the $(HOST_DIR)/share/buildroot folder from a
>> dependency of the toolchain package, to a post-install staging hook of
>> the toolchain package.
>>
>
> The top-level buildroot build steps executed are (a) "xyz_deconfig" and
> (b) "all sdk".
>
> Could be that you do not see the problem if you execute "all" and then
> "sdk". But then it would mean that some dependency is missing on the "sdk"
> target, which I agree would be worse.
>

I guess the real problem with commit
6729050f3a49dba42d2d881d31dbefd6b82b8dad is that it adds a script to
toolchain install staging hooks, but does not set TOOLCHAIN_INSTALL_STAGING
to YES. Thus after that change the script is no longer executed during the
build.

I've submitted another patch to fix the root cause.

Regards, Stefan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180326/13d47d64/attachment.html>