From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [net-next PATCH 2/5] soc: ti: K2G: provide APIs to support driver probe deferral
Date: Mon, 26 Mar 2018 22:48:02 +0200 [thread overview]
Message-ID: <20180326204802.GC5862@lunn.ch> (raw)
In-Reply-To: <1522095312-23249-3-git-send-email-m-karicheri2@ti.com>
On Mon, Mar 26, 2018 at 04:15:09PM -0400, Murali Karicheri wrote:
> This patch provide APIs to allow client drivers to support
> probe deferral. On K2G SoC, devices can be probed only
> after the ti_sci_pm_domains driver is probed and ready.
> As drivers may get probed at different order, any driver
> that depends on knav dma and qmss drivers, for example
> netcp network driver, needs to defer probe until
> knav devices are probed and ready to service. To do this,
> add an API to query the device ready status from the knav
> dma and qmss devices.
Hi Murali
Shouldn't you really re-write this to be a dma driver? You would then
do something like of_dma_request_slave_channel() in the ethernet
driver probe function. That probably correctly returns EPROBE_DEFER.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Murali Karicheri <m-karicheri2@ti.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, ssantosh@kernel.org,
malat@debian.org, w-kwok2@ti.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, davem@davemloft.net,
netdev@vger.kernel.org
Subject: Re: [net-next PATCH 2/5] soc: ti: K2G: provide APIs to support driver probe deferral
Date: Mon, 26 Mar 2018 22:48:02 +0200 [thread overview]
Message-ID: <20180326204802.GC5862@lunn.ch> (raw)
In-Reply-To: <1522095312-23249-3-git-send-email-m-karicheri2@ti.com>
On Mon, Mar 26, 2018 at 04:15:09PM -0400, Murali Karicheri wrote:
> This patch provide APIs to allow client drivers to support
> probe deferral. On K2G SoC, devices can be probed only
> after the ti_sci_pm_domains driver is probed and ready.
> As drivers may get probed at different order, any driver
> that depends on knav dma and qmss drivers, for example
> netcp network driver, needs to defer probe until
> knav devices are probed and ready to service. To do this,
> add an API to query the device ready status from the knav
> dma and qmss devices.
Hi Murali
Shouldn't you really re-write this to be a dma driver? You would then
do something like of_dma_request_slave_channel() in the ethernet
driver probe function. That probably correctly returns EPROBE_DEFER.
Andrew
next prev parent reply other threads:[~2018-03-26 20:48 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 20:15 [net-next PATCH 0/5] Add support for netcp driver on K2G SoC Murali Karicheri
2018-03-26 20:15 ` Murali Karicheri
2018-03-26 20:15 ` Murali Karicheri
2018-03-26 20:15 ` [net-next PATCH 1/5] soc: ti: K2G: enhancement to support QMSS in NSS Murali Karicheri
2018-03-26 20:15 ` Murali Karicheri
2018-03-26 20:15 ` Murali Karicheri
2018-03-26 20:15 ` [net-next PATCH 2/5] soc: ti: K2G: provide APIs to support driver probe deferral Murali Karicheri
2018-03-26 20:15 ` Murali Karicheri
2018-03-26 20:15 ` Murali Karicheri
2018-03-26 20:48 ` Andrew Lunn [this message]
2018-03-26 20:48 ` Andrew Lunn
2018-03-27 13:32 ` Murali Karicheri
2018-03-27 13:32 ` Murali Karicheri
2018-03-27 13:32 ` Murali Karicheri
2018-03-27 14:03 ` Andrew Lunn
2018-03-27 14:03 ` Andrew Lunn
2018-03-27 14:31 ` Murali Karicheri
2018-03-27 14:31 ` Murali Karicheri
2018-03-27 14:31 ` Murali Karicheri
2018-03-26 20:15 ` [net-next PATCH 3/5] net: netcp: ethss enhancements to support 2u cpsw h/w on K2G SoC Murali Karicheri
2018-03-26 20:15 ` Murali Karicheri
2018-03-26 20:15 ` Murali Karicheri
2018-03-26 20:28 ` Andrew Lunn
2018-03-26 20:28 ` Andrew Lunn
2018-03-26 20:28 ` Andrew Lunn
2018-03-27 13:23 ` Murali Karicheri
2018-03-27 13:23 ` Murali Karicheri
2018-03-27 13:23 ` Murali Karicheri
2018-03-27 13:47 ` Andrew Lunn
2018-03-27 13:47 ` Andrew Lunn
2018-03-26 20:15 ` [net-next PATCH 4/5] Revert "net: netcp: remove dead code from the driver" Murali Karicheri
2018-03-26 20:15 ` Murali Karicheri
2018-03-26 20:15 ` Murali Karicheri
2018-03-26 20:15 ` [net-next PATCH 5/5] net: netcp: support probe deferral Murali Karicheri
2018-03-26 20:15 ` Murali Karicheri
2018-03-26 20:15 ` Murali Karicheri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180326204802.GC5862@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.