[PATCH for-4.11] tools: set DEBUG_DIR from configure

[PATCH for-4.11] tools: set DEBUG_DIR from configure

[Roger Pau Monne]

Allow the path to be set from a configure command line option.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
Cc: Olaf Hering <olaf@aepfle.de>
Cc: Jan Beulich <jbeulich@suse.com>
---
 config/Paths.mk.in | 1 +
 m4/paths.m4        | 9 +++++++++
 2 files changed, 10 insertions(+)

diff --git a/config/Paths.mk.in b/config/Paths.mk.in
index a603295146..8a518d5a5d 100644
--- a/config/Paths.mk.in
+++ b/config/Paths.mk.in
@@ -51,6 +51,7 @@ BASH_COMPLETION_DIR      := $(CONFIG_DIR)/bash_completion.d
 XEN_LOCK_DIR             := @XEN_LOCK_DIR@
 XEN_PAGING_DIR           := @XEN_PAGING_DIR@
 XEN_DUMP_DIR             := @XEN_DUMP_DIR@
+DEBUG_DIR                := @DEBUG_DIR@
 
 XENFIRMWAREDIR           := @XENFIRMWAREDIR@
 
diff --git a/m4/paths.m4 b/m4/paths.m4
index f208b7e39f..7c5a775c88 100644
--- a/m4/paths.m4
+++ b/m4/paths.m4
@@ -82,6 +82,12 @@ AC_ARG_WITH([rundir],
     [rundir_path=$withval],
     [rundir_path=$localstatedir/run])
 
+AC_ARG_WITH([debugdir],
+    AS_HELP_STRING([--with-debugdir=DIR],
+    [Path to directory for debug symbols. [PREFIX/usr/lib/debug]]),
+    [debugdir_path=$withval],
+    [debugdir_path=$prefix/usr/lib/debug])
+
 if test "$libexecdir" = '${exec_prefix}/libexec' ; then
     case "$host_os" in
          *netbsd*) ;;
@@ -146,6 +152,9 @@ AC_SUBST(XEN_PAGING_DIR)
 
 XEN_DUMP_DIR=$xen_dumpdir_path
 AC_SUBST(XEN_DUMP_DIR)
+
+DEBUG_DIR=$debugdir_path
+AC_SUBST(DEBUG_DIR)
 ])
 
 case "$host_os" in
-- 
2.16.3


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH for-4.11] tools: set DEBUG_DIR from configure

[Olaf Hering]

[-- Attachment #1.1: Type: text/plain, Size: 319 bytes --]

On Tue, Mar 27, Roger Pau Monne wrote:

> +AC_ARG_WITH([debugdir],
> +    AS_HELP_STRING([--with-debugdir=DIR],
> +    [Path to directory for debug symbols. [PREFIX/usr/lib/debug]]),
> +    [debugdir_path=$withval],
> +    [debugdir_path=$prefix/usr/lib/debug])

Would that create /usr/usr/lib/debug per default?

Olaf

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH for-4.11] tools: set DEBUG_DIR from configure

[Roger Pau Monné]

On Tue, Mar 27, 2018 at 06:18:08PM +0200, Olaf Hering wrote:
> On Tue, Mar 27, Roger Pau Monne wrote:
> 
> > +AC_ARG_WITH([debugdir],
> > +    AS_HELP_STRING([--with-debugdir=DIR],
> > +    [Path to directory for debug symbols. [PREFIX/usr/lib/debug]]),
> > +    [debugdir_path=$withval],
> > +    [debugdir_path=$prefix/usr/lib/debug])
> 
> Would that create /usr/usr/lib/debug per default?

No, this would be: /usr/local/usr/lib/debug by default.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH for-4.11] tools: set DEBUG_DIR from configure

[Roger Pau Monné]

On Tue, Mar 27, 2018 at 05:20:57PM +0100, Roger Pau Monné wrote:
> On Tue, Mar 27, 2018 at 06:18:08PM +0200, Olaf Hering wrote:
> > On Tue, Mar 27, Roger Pau Monne wrote:
> > 
> > > +AC_ARG_WITH([debugdir],
> > > +    AS_HELP_STRING([--with-debugdir=DIR],
> > > +    [Path to directory for debug symbols. [PREFIX/usr/lib/debug]]),
> > > +    [debugdir_path=$withval],
> > > +    [debugdir_path=$prefix/usr/lib/debug])
> > 
> > Would that create /usr/usr/lib/debug per default?
> 
> No, this would be: /usr/local/usr/lib/debug by default.

Which maybe should be: /usr/local/lib/debug instead?

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH for-4.11] tools: set DEBUG_DIR from configure

[Doug Goldstein]

On 3/27/18 11:28 AM, Roger Pau Monné wrote:
> On Tue, Mar 27, 2018 at 05:20:57PM +0100, Roger Pau Monné wrote:
>> On Tue, Mar 27, 2018 at 06:18:08PM +0200, Olaf Hering wrote:
>>> On Tue, Mar 27, Roger Pau Monne wrote:
>>>
>>>> +AC_ARG_WITH([debugdir],
>>>> +    AS_HELP_STRING([--with-debugdir=DIR],
>>>> +    [Path to directory for debug symbols. [PREFIX/usr/lib/debug]]),
>>>> +    [debugdir_path=$withval],
>>>> +    [debugdir_path=$prefix/usr/lib/debug])
>>>
>>> Would that create /usr/usr/lib/debug per default?
>>
>> No, this would be: /usr/local/usr/lib/debug by default.
> 
> Which maybe should be: /usr/local/lib/debug instead?
> 

You should use $prefix/lib/debug by default. Which would cause this to
map appropriately. If you have let's say /usr/bin/ls then by default it
would have /usr/lib/debug/usr/bin/ls.debug If you have
/usr/local/bin/foo then it would be /usr/local/debug/usr/local/bin/foo.debug

Assuming that ls was built with ./configure --prefix=/usr and foo was
built with ./configure (where --prefix is by default /usr/local).

-- 
Doug Goldstein

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH for-4.11] tools: set DEBUG_DIR from configure

[Roger Pau Monné]

On Tue, Mar 27, 2018 at 11:55:37AM -0500, Doug Goldstein wrote:
> On 3/27/18 11:28 AM, Roger Pau Monné wrote:
> > On Tue, Mar 27, 2018 at 05:20:57PM +0100, Roger Pau Monné wrote:
> >> On Tue, Mar 27, 2018 at 06:18:08PM +0200, Olaf Hering wrote:
> >>> On Tue, Mar 27, Roger Pau Monne wrote:
> >>>
> >>>> +AC_ARG_WITH([debugdir],
> >>>> +    AS_HELP_STRING([--with-debugdir=DIR],
> >>>> +    [Path to directory for debug symbols. [PREFIX/usr/lib/debug]]),
> >>>> +    [debugdir_path=$withval],
> >>>> +    [debugdir_path=$prefix/usr/lib/debug])
> >>>
> >>> Would that create /usr/usr/lib/debug per default?
> >>
> >> No, this would be: /usr/local/usr/lib/debug by default.
> > 
> > Which maybe should be: /usr/local/lib/debug instead?
> > 
> 
> You should use $prefix/lib/debug by default. Which would cause this to
> map appropriately. If you have let's say /usr/bin/ls then by default it
> would have /usr/lib/debug/usr/bin/ls.debug If you have
> /usr/local/bin/foo then it would be /usr/local/debug/usr/local/bin/foo.debug
                                                 ^ lib/
> 
> Assuming that ls was built with ./configure --prefix=/usr and foo was

I guess you mean --prefix=/, using /usr would generate /usr/usr/bin/ls
AFAICT?

Will send v2 shortly, hopefully this time the paths will be right :)

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH for-4.11] tools: set DEBUG_DIR from configure

[Doug Goldstein]

On 3/28/18 2:26 AM, Roger Pau Monné wrote:
> On Tue, Mar 27, 2018 at 11:55:37AM -0500, Doug Goldstein wrote:
>> On 3/27/18 11:28 AM, Roger Pau Monné wrote:
>>> On Tue, Mar 27, 2018 at 05:20:57PM +0100, Roger Pau Monné wrote:
>>>> On Tue, Mar 27, 2018 at 06:18:08PM +0200, Olaf Hering wrote:
>>>>> On Tue, Mar 27, Roger Pau Monne wrote:
>>>>>
>>>>>> +AC_ARG_WITH([debugdir],
>>>>>> +    AS_HELP_STRING([--with-debugdir=DIR],
>>>>>> +    [Path to directory for debug symbols. [PREFIX/usr/lib/debug]]),
>>>>>> +    [debugdir_path=$withval],
>>>>>> +    [debugdir_path=$prefix/usr/lib/debug])
>>>>>
>>>>> Would that create /usr/usr/lib/debug per default?
>>>>
>>>> No, this would be: /usr/local/usr/lib/debug by default.
>>>
>>> Which maybe should be: /usr/local/lib/debug instead?
>>>
>>
>> You should use $prefix/lib/debug by default. Which would cause this to
>> map appropriately. If you have let's say /usr/bin/ls then by default it
>> would have /usr/lib/debug/usr/bin/ls.debug If you have
>> /usr/local/bin/foo then it would be /usr/local/debug/usr/local/bin/foo.debug
>                                                  ^ lib/
>>
>> Assuming that ls was built with ./configure --prefix=/usr and foo was
> 
> I guess you mean --prefix=/, using /usr would generate /usr/usr/bin/ls
> AFAICT?
> 
> Will send v2 shortly, hopefully this time the paths will be right :)
> 
> Thanks, Roger.
> 

No. The default prefix with autoconf is "/usr/local". But when Linux
distros package things up they use "/usr". See:
https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/Default-Prefix.html

-- 
Doug Goldstein

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH for-4.11] tools: set DEBUG_DIR from configure

[Olaf Hering]

[-- Attachment #1.1: Type: text/plain, Size: 241 bytes --]

On Tue, Mar 27, Roger Pau Monne wrote:

> Allow the path to be set from a configure command line option.

Please backport 641f9ce2fa to 4.10 ASAP. See
https://lists.xenproject.org/archives/html/xen-devel/2018-02/msg02749.html

Thanks.

Olaf

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH for-4.11] tools: set DEBUG_DIR from configure

[Ian Jackson]

Olaf Hering writes ("Re: [Xen-devel] [PATCH for-4.11] tools: set DEBUG_DIR from configure"):
> On Tue, Mar 27, Roger Pau Monne wrote:
> 
> > Allow the path to be set from a configure command line option.
> 
> Please backport 641f9ce2fa to 4.10 ASAP. See
> https://lists.xenproject.org/archives/html/xen-devel/2018-02/msg02749.html

I read that, but it doesn't say when the breakage was introduced ?

Can you please provide that information ?  That should really have
been in your commit message, as the git commit id.  TBH, most of what
is in that email could profitably have been in your commit message...

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH for-4.11] tools: set DEBUG_DIR from configure

[Olaf Hering]

[-- Attachment #1.1: Type: text/plain, Size: 443 bytes --]

On Fri, May 25, Ian Jackson wrote:

> Can you please provide that information ?  That should really have
> been in your commit message, as the git commit id.  TBH, most of what
> is in that email could profitably have been in your commit message...

Perhaps 641f9ce2fa should have been more verbose.

Do you want me to provide a verbose backport, or would that be against
the rules of how backporting from master is supposed to be done?

Olaf

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH for-4.11] tools: set DEBUG_DIR from configure

[Ian Jackson]

Olaf Hering writes ("Re: [Xen-devel] [PATCH for-4.11] tools: set DEBUG_DIR from configure"):
> On Fri, May 25, Ian Jackson wrote:
> > Can you please provide that information ?  That should really have
> > been in your commit message, as the git commit id.  TBH, most of what
> > is in that email could profitably have been in your commit message...
> 
> Perhaps 641f9ce2fa should have been more verbose.

Yes, let's go back in time and fix that, err, right away :-).

> Do you want me to provide a verbose backport, or would that be against
> the rules of how backporting from master is supposed to be done?

Yes, please do.  I am happy to add more text to a commit message when
backporting.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel