From: "Michael S. Tsirkin" <mst@redhat.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Wei Wang <wei.w.wang@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
linux-mm@kvack.org, pbonzini@redhat.com,
liliang.opensource@gmail.com, yang.zhang.wz@gmail.com,
quan.xu0@gmail.com, nilal@redhat.com, riel@redhat.com,
huangzhichao@huawei.com
Subject: [virtio-dev] Re: [PATCH v29 1/4] mm: support reporting free page blocks
Date: Tue, 27 Mar 2018 19:07:22 +0300 [thread overview]
Message-ID: <20180327190635-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20180327063322.GW5652@dhcp22.suse.cz>
On Tue, Mar 27, 2018 at 08:33:22AM +0200, Michal Hocko wrote:
> > > > + * The function itself might sleep so it cannot be called from atomic
> > > > + * contexts.
> > > I don't see how walk_free_mem_block() can sleep.
> >
> > OK, it would be better to remove this sentence for the current version. But
> > I think we could probably keep it if we decide to add cond_resched() below.
>
> The point of this sentence was to make any user aware that the function
> might sleep from the very begining rather than chase existing callers
> when we need to add cond_resched or sleep for any other reason. So I
> would rather keep it.
Let's say what it is then - "will be changed to sleep in the future".
> --
> Michal Hocko
> SUSE Labs
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Wei Wang <wei.w.wang@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
linux-mm@kvack.org, pbonzini@redhat.com,
liliang.opensource@gmail.com, yang.zhang.wz@gmail.com,
quan.xu0@gmail.com, nilal@redhat.com, riel@redhat.com,
huangzhichao@huawei.com
Subject: Re: [PATCH v29 1/4] mm: support reporting free page blocks
Date: Tue, 27 Mar 2018 19:07:22 +0300 [thread overview]
Message-ID: <20180327190635-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20180327063322.GW5652@dhcp22.suse.cz>
On Tue, Mar 27, 2018 at 08:33:22AM +0200, Michal Hocko wrote:
> > > > + * The function itself might sleep so it cannot be called from atomic
> > > > + * contexts.
> > > I don't see how walk_free_mem_block() can sleep.
> >
> > OK, it would be better to remove this sentence for the current version. But
> > I think we could probably keep it if we decide to add cond_resched() below.
>
> The point of this sentence was to make any user aware that the function
> might sleep from the very begining rather than chase existing callers
> when we need to add cond_resched or sleep for any other reason. So I
> would rather keep it.
Let's say what it is then - "will be changed to sleep in the future".
> --
> Michal Hocko
> SUSE Labs
next prev parent reply other threads:[~2018-03-27 16:07 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 2:39 [virtio-dev] [PATCH v29 0/4] Virtio-balloon: support free page reporting Wei Wang
2018-03-26 2:39 ` Wei Wang
2018-03-26 2:39 ` [PATCH v29 1/4] mm: support reporting free page blocks Wei Wang
2018-03-26 2:39 ` [virtio-dev] " Wei Wang
2018-03-26 2:39 ` Wei Wang
2018-03-26 21:22 ` Andrew Morton
2018-03-26 21:22 ` Andrew Morton
2018-03-27 6:23 ` Wei Wang
2018-03-27 6:23 ` [virtio-dev] " Wei Wang
2018-03-27 6:23 ` Wei Wang
2018-03-27 6:33 ` Michal Hocko
2018-03-27 16:07 ` Michael S. Tsirkin [this message]
2018-03-27 16:07 ` Michael S. Tsirkin
2018-03-28 7:01 ` Michal Hocko
2018-03-28 7:01 ` Michal Hocko
2018-03-27 16:07 ` Michael S. Tsirkin
2018-03-27 6:33 ` Michal Hocko
2018-04-10 18:19 ` [virtio-dev] " Michael S. Tsirkin
2018-04-10 18:19 ` Michael S. Tsirkin
2018-04-10 20:54 ` Andrew Morton
2018-04-10 23:25 ` Michael S. Tsirkin
2018-04-10 23:25 ` [virtio-dev] " Michael S. Tsirkin
2018-04-10 23:25 ` Michael S. Tsirkin
2018-04-11 1:22 ` [virtio-dev] " Wei Wang
2018-04-11 1:22 ` Wei Wang
2018-04-11 1:22 ` Wei Wang
2018-04-10 20:54 ` Andrew Morton
2018-04-10 18:19 ` Michael S. Tsirkin
2018-03-26 2:39 ` [PATCH v29 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT Wei Wang
2018-03-26 2:39 ` [virtio-dev] " Wei Wang
2018-03-26 2:39 ` Wei Wang
2018-03-26 2:39 ` [virtio-dev] [PATCH v29 3/4] mm/page_poison: expose page_poisoning_enabled to kernel modules Wei Wang
2018-03-26 2:39 ` Wei Wang
2018-03-26 3:24 ` [virtio-dev] " Wang, Wei W
2018-03-26 3:24 ` Wang, Wei W
2018-03-26 3:24 ` Wang, Wei W
2018-03-26 21:24 ` Andrew Morton
2018-03-26 21:24 ` Andrew Morton
2018-03-26 2:39 ` Wei Wang
2018-03-26 2:39 ` [PATCH v29 4/4] virtio-balloon: VIRTIO_BALLOON_F_PAGE_POISON Wei Wang
2018-03-26 2:39 ` [virtio-dev] " Wei Wang
2018-03-26 2:39 ` Wei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180327190635-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=huangzhichao@huawei.com \
--cc=kvm@vger.kernel.org \
--cc=liliang.opensource@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=nilal@redhat.com \
--cc=pbonzini@redhat.com \
--cc=quan.xu0@gmail.com \
--cc=riel@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=wei.w.wang@intel.com \
--cc=yang.zhang.wz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.