From: Tony Lindgren <tony@atomide.com>
To: Tero Kristo <t-kristo@ti.com>
Cc: sboyd@kernel.org, mturquette@baylibre.com,
linux-omap@vger.kernel.org, linux-clk@vger.kernel.org,
arnd@arndb.de, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] clk: ti: fix flag space conflict with clkctrl clocks
Date: Tue, 27 Mar 2018 13:55:10 -0700 [thread overview]
Message-ID: <20180327205510.GJ5700@atomide.com> (raw)
In-Reply-To: <1522172824-14094-1-git-send-email-t-kristo@ti.com>
* Tero Kristo <t-kristo@ti.com> [180327 17:48]:
> The introduction of support for CLK_SET_RATE_PARENT flag for clkctrl
> clocks used a generic clock flag, which causes a conflict with the
> rest of the clkctrl flags, namely the NO_IDLEST flag. This can cause
> boot failures on certain platforms where this flag is introduced, by
> omitting the wait for the clockctrl module to be fully enabled before
> proceeding with rest of the code.
>
> Fix this by moving all the clkctrl specific flags to their own bit-range.
>
> Signed-off-by: Tero Kristo <t-kristo@ti.com>
> Fixes: 49159a9dc3da ("clk: ti: add support for CLK_SET_RATE_PARENT flag")
> Reported-by: Christophe Lyon <christophe.lyon@linaro.org>
I boot tested this on am437x-idk and bbb with multi_v7_defconfig, so:
Tested-by: Tony Lindgren <tony@atomide.com>
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Tero Kristo <t-kristo@ti.com>
Cc: arnd@arndb.de, sboyd@kernel.org, mturquette@baylibre.com,
linux-omap@vger.kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] clk: ti: fix flag space conflict with clkctrl clocks
Date: Tue, 27 Mar 2018 13:55:10 -0700 [thread overview]
Message-ID: <20180327205510.GJ5700@atomide.com> (raw)
In-Reply-To: <1522172824-14094-1-git-send-email-t-kristo@ti.com>
* Tero Kristo <t-kristo@ti.com> [180327 17:48]:
> The introduction of support for CLK_SET_RATE_PARENT flag for clkctrl
> clocks used a generic clock flag, which causes a conflict with the
> rest of the clkctrl flags, namely the NO_IDLEST flag. This can cause
> boot failures on certain platforms where this flag is introduced, by
> omitting the wait for the clockctrl module to be fully enabled before
> proceeding with rest of the code.
>
> Fix this by moving all the clkctrl specific flags to their own bit-range.
>
> Signed-off-by: Tero Kristo <t-kristo@ti.com>
> Fixes: 49159a9dc3da ("clk: ti: add support for CLK_SET_RATE_PARENT flag")
> Reported-by: Christophe Lyon <christophe.lyon@linaro.org>
I boot tested this on am437x-idk and bbb with multi_v7_defconfig, so:
Tested-by: Tony Lindgren <tony@atomide.com>
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: ti: fix flag space conflict with clkctrl clocks
Date: Tue, 27 Mar 2018 13:55:10 -0700 [thread overview]
Message-ID: <20180327205510.GJ5700@atomide.com> (raw)
In-Reply-To: <1522172824-14094-1-git-send-email-t-kristo@ti.com>
* Tero Kristo <t-kristo@ti.com> [180327 17:48]:
> The introduction of support for CLK_SET_RATE_PARENT flag for clkctrl
> clocks used a generic clock flag, which causes a conflict with the
> rest of the clkctrl flags, namely the NO_IDLEST flag. This can cause
> boot failures on certain platforms where this flag is introduced, by
> omitting the wait for the clockctrl module to be fully enabled before
> proceeding with rest of the code.
>
> Fix this by moving all the clkctrl specific flags to their own bit-range.
>
> Signed-off-by: Tero Kristo <t-kristo@ti.com>
> Fixes: 49159a9dc3da ("clk: ti: add support for CLK_SET_RATE_PARENT flag")
> Reported-by: Christophe Lyon <christophe.lyon@linaro.org>
I boot tested this on am437x-idk and bbb with multi_v7_defconfig, so:
Tested-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2018-03-27 20:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-27 17:47 [PATCH] clk: ti: fix flag space conflict with clkctrl clocks Tero Kristo
2018-03-27 17:47 ` Tero Kristo
2018-03-27 17:47 ` Tero Kristo
2018-03-27 20:55 ` Tony Lindgren [this message]
2018-03-27 20:55 ` Tony Lindgren
2018-03-27 20:55 ` Tony Lindgren
2018-03-29 18:25 ` Tero Kristo
2018-03-29 18:25 ` Tero Kristo
2018-03-29 18:25 ` Tero Kristo
2018-04-05 20:05 ` Stephen Boyd
2018-04-05 20:05 ` Stephen Boyd
2018-04-05 20:05 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180327205510.GJ5700@atomide.com \
--to=tony@atomide.com \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.