* [Qemu-devel] [PATCH] migration: fix pfd leak
@ 2018-03-21 11:36 Marc-André Lureau
2018-03-21 14:42 ` Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Marc-André Lureau @ 2018-03-21 11:36 UTC (permalink / raw)
To: qemu-devel; +Cc: dgilbert, peterx, Marc-André Lureau
Fix leak spotted by ASAN:
Direct leak of 16 byte(s) in 1 object(s) allocated from:
#0 0x7fe1abb80a38 in __interceptor_calloc (/lib64/libasan.so.4+0xdea38)
#1 0x7fe1aaf1bf75 in g_malloc0 ../glib/gmem.c:124
#2 0x7fe1aaf1c249 in g_malloc0_n ../glib/gmem.c:355
#3 0x55f4841cfaa9 in postcopy_ram_fault_thread /home/elmarco/src/qemu/migration/postcopy-ram.c:596
#4 0x55f48479447b in qemu_thread_start /home/elmarco/src/qemu/util/qemu-thread-posix.c:504
#5 0x7fe1a043550a in start_thread (/lib64/libpthread.so.0+0x750a)
Regression introduced with commit 00fa4fc85b00f1a8a810068d158a7a66e88658eb.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
migration/postcopy-ram.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c
index efd77939af..4a0b33b373 100644
--- a/migration/postcopy-ram.c
+++ b/migration/postcopy-ram.c
@@ -754,6 +754,7 @@ static void *postcopy_ram_fault_thread(void *opaque)
}
}
trace_postcopy_ram_fault_thread_exit();
+ g_free(pfd);
return NULL;
}
--
2.16.2.521.g9aa15f885a
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] migration: fix pfd leak
2018-03-21 11:36 [Qemu-devel] [PATCH] migration: fix pfd leak Marc-André Lureau
@ 2018-03-21 14:42 ` Philippe Mathieu-Daudé
2018-03-22 3:12 ` Peter Xu
2018-03-29 9:23 ` Dr. David Alan Gilbert
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-03-21 14:42 UTC (permalink / raw)
To: Marc-André Lureau, qemu-devel; +Cc: dgilbert, peterx
On 03/21/2018 12:36 PM, Marc-André Lureau wrote:
> Fix leak spotted by ASAN:
>
> Direct leak of 16 byte(s) in 1 object(s) allocated from:
> #0 0x7fe1abb80a38 in __interceptor_calloc (/lib64/libasan.so.4+0xdea38)
> #1 0x7fe1aaf1bf75 in g_malloc0 ../glib/gmem.c:124
> #2 0x7fe1aaf1c249 in g_malloc0_n ../glib/gmem.c:355
> #3 0x55f4841cfaa9 in postcopy_ram_fault_thread /home/elmarco/src/qemu/migration/postcopy-ram.c:596
> #4 0x55f48479447b in qemu_thread_start /home/elmarco/src/qemu/util/qemu-thread-posix.c:504
> #5 0x7fe1a043550a in start_thread (/lib64/libpthread.so.0+0x750a)
>
> Regression introduced with commit 00fa4fc85b00f1a8a810068d158a7a66e88658eb.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> migration/postcopy-ram.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c
> index efd77939af..4a0b33b373 100644
> --- a/migration/postcopy-ram.c
> +++ b/migration/postcopy-ram.c
> @@ -754,6 +754,7 @@ static void *postcopy_ram_fault_thread(void *opaque)
> }
> }
> trace_postcopy_ram_fault_thread_exit();
> + g_free(pfd);
> return NULL;
> }
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] migration: fix pfd leak
2018-03-21 11:36 [Qemu-devel] [PATCH] migration: fix pfd leak Marc-André Lureau
2018-03-21 14:42 ` Philippe Mathieu-Daudé
@ 2018-03-22 3:12 ` Peter Xu
2018-03-29 9:23 ` Dr. David Alan Gilbert
2 siblings, 0 replies; 4+ messages in thread
From: Peter Xu @ 2018-03-22 3:12 UTC (permalink / raw)
To: Marc-André Lureau; +Cc: qemu-devel, dgilbert
On Wed, Mar 21, 2018 at 12:36:44PM +0100, Marc-André Lureau wrote:
> Fix leak spotted by ASAN:
>
> Direct leak of 16 byte(s) in 1 object(s) allocated from:
> #0 0x7fe1abb80a38 in __interceptor_calloc (/lib64/libasan.so.4+0xdea38)
> #1 0x7fe1aaf1bf75 in g_malloc0 ../glib/gmem.c:124
> #2 0x7fe1aaf1c249 in g_malloc0_n ../glib/gmem.c:355
> #3 0x55f4841cfaa9 in postcopy_ram_fault_thread /home/elmarco/src/qemu/migration/postcopy-ram.c:596
> #4 0x55f48479447b in qemu_thread_start /home/elmarco/src/qemu/util/qemu-thread-posix.c:504
> #5 0x7fe1a043550a in start_thread (/lib64/libpthread.so.0+0x750a)
>
> Regression introduced with commit 00fa4fc85b00f1a8a810068d158a7a66e88658eb.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] migration: fix pfd leak
2018-03-21 11:36 [Qemu-devel] [PATCH] migration: fix pfd leak Marc-André Lureau
2018-03-21 14:42 ` Philippe Mathieu-Daudé
2018-03-22 3:12 ` Peter Xu
@ 2018-03-29 9:23 ` Dr. David Alan Gilbert
2 siblings, 0 replies; 4+ messages in thread
From: Dr. David Alan Gilbert @ 2018-03-29 9:23 UTC (permalink / raw)
To: Marc-André Lureau; +Cc: qemu-devel, peterx
* Marc-André Lureau (marcandre.lureau@redhat.com) wrote:
> Fix leak spotted by ASAN:
>
> Direct leak of 16 byte(s) in 1 object(s) allocated from:
> #0 0x7fe1abb80a38 in __interceptor_calloc (/lib64/libasan.so.4+0xdea38)
> #1 0x7fe1aaf1bf75 in g_malloc0 ../glib/gmem.c:124
> #2 0x7fe1aaf1c249 in g_malloc0_n ../glib/gmem.c:355
> #3 0x55f4841cfaa9 in postcopy_ram_fault_thread /home/elmarco/src/qemu/migration/postcopy-ram.c:596
> #4 0x55f48479447b in qemu_thread_start /home/elmarco/src/qemu/util/qemu-thread-posix.c:504
> #5 0x7fe1a043550a in start_thread (/lib64/libpthread.so.0+0x750a)
>
> Regression introduced with commit 00fa4fc85b00f1a8a810068d158a7a66e88658eb.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Queued
> ---
> migration/postcopy-ram.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c
> index efd77939af..4a0b33b373 100644
> --- a/migration/postcopy-ram.c
> +++ b/migration/postcopy-ram.c
> @@ -754,6 +754,7 @@ static void *postcopy_ram_fault_thread(void *opaque)
> }
> }
> trace_postcopy_ram_fault_thread_exit();
> + g_free(pfd);
> return NULL;
> }
>
> --
> 2.16.2.521.g9aa15f885a
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-03-29 9:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-21 11:36 [Qemu-devel] [PATCH] migration: fix pfd leak Marc-André Lureau
2018-03-21 14:42 ` Philippe Mathieu-Daudé
2018-03-22 3:12 ` Peter Xu
2018-03-29 9:23 ` Dr. David Alan Gilbert
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.