From: Eric Biggers <ebiggers3@gmail.com>
To: David Howells <dhowells@redhat.com>
Cc: keyrings@vger.kernel.org, netdev@vger.kernel.org,
Mark Rutland <mark.rutland@arm.com>,
Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH v2] KEYS: DNS: limit the length of option strings
Date: Mon, 02 Apr 2018 19:20:35 +0000 [thread overview]
Message-ID: <20180402192035.GC59810@gmail.com> (raw)
In-Reply-To: <20180323202122.GB16350@gmail.com>
On Fri, Mar 23, 2018 at 01:21:22PM -0700, Eric Biggers wrote:
> On Mon, Mar 12, 2018 at 10:57:07AM -0700, Eric Biggers wrote:
> > On Wed, Mar 07, 2018 at 03:54:37PM +0000, David Howells wrote:
> > > Eric Biggers <ebiggers3@gmail.com> wrote:
> > >
> > > > Fix it by limiting option strings (combined name + value) to a much more
> > > > reasonable 128 bytes. The exact limit is arbitrary, but currently the
> > > > only recognized option is formatted as "dnserror=%lu" which fits well
> > > > within this limit.
> > >
> > > There will be more options coming ("ipv4", "ipv6") but they shouldn't overrun
> > > this limit and we can always extend the limit if need be.
> > >
> > > David
> >
> > David (Howells) do you want to take this patch through the keyrings tree or
> > should I ask David Miller to take it through net-next?
> >
> > Eric
>
> Ping.
Ping again.
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers3@gmail.com>
To: David Howells <dhowells@redhat.com>
Cc: keyrings@vger.kernel.org, netdev@vger.kernel.org,
Mark Rutland <mark.rutland@arm.com>,
Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH v2] KEYS: DNS: limit the length of option strings
Date: Mon, 2 Apr 2018 12:20:35 -0700 [thread overview]
Message-ID: <20180402192035.GC59810@gmail.com> (raw)
In-Reply-To: <20180323202122.GB16350@gmail.com>
On Fri, Mar 23, 2018 at 01:21:22PM -0700, Eric Biggers wrote:
> On Mon, Mar 12, 2018 at 10:57:07AM -0700, Eric Biggers wrote:
> > On Wed, Mar 07, 2018 at 03:54:37PM +0000, David Howells wrote:
> > > Eric Biggers <ebiggers3@gmail.com> wrote:
> > >
> > > > Fix it by limiting option strings (combined name + value) to a much more
> > > > reasonable 128 bytes. The exact limit is arbitrary, but currently the
> > > > only recognized option is formatted as "dnserror=%lu" which fits well
> > > > within this limit.
> > >
> > > There will be more options coming ("ipv4", "ipv6") but they shouldn't overrun
> > > this limit and we can always extend the limit if need be.
> > >
> > > David
> >
> > David (Howells) do you want to take this patch through the keyrings tree or
> > should I ask David Miller to take it through net-next?
> >
> > Eric
>
> Ping.
Ping again.
next prev parent reply other threads:[~2018-04-02 19:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 19:05 [PATCH v2] KEYS: DNS: limit the length of option strings Eric Biggers
2018-02-28 19:05 ` Eric Biggers
2018-03-07 15:54 ` David Howells
2018-03-12 17:57 ` Eric Biggers
2018-03-12 17:57 ` Eric Biggers
2018-03-23 20:21 ` Eric Biggers
2018-03-23 20:21 ` Eric Biggers
2018-04-02 19:20 ` Eric Biggers [this message]
2018-04-02 19:20 ` Eric Biggers
2018-04-16 21:31 ` Eric Biggers
2018-04-16 21:31 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180402192035.GC59810@gmail.com \
--to=ebiggers3@gmail.com \
--cc=dhowells@redhat.com \
--cc=ebiggers@google.com \
--cc=keyrings@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.