Re: [Mesa-dev] VC4 not working for me with mesa 17.3.7 - was [meta-raspberrypi] VC4 not working for me with mesa 17.3.7

Re: [Mesa-dev] VC4 not working for me with mesa 17.3.7 - was [meta-raspberrypi] VC4 not working for me with mesa 17.3.7

[Andreas Müller]

On Mon, Apr 2, 2018 at 2:42 PM, Daniel Stone <daniel@fooishbar.org> wrote:
> Hi Andreas,
>
> On 31 March 2018 at 15:18, Andreas Müller <schnitzeltony@gmail.com> wrote:
>> Thanks for prompt an VERY helpful support. I did:
>>
>> * Check my configure and found: --disable-dri3!
>> * Tested your patch (with --disable-dri3) and as expected it fixes the issue
>> * Found what causes --disable-dri3 - it came in by the Openembedded
>> update mentioned in first email. FWIW: I use a fork for
>> meta-raspberrypi - the original is not affected so I am the only one
>> with this issue...
>
> Glad to hear it!
>
>> I have two questions related to dri2/your patch (sorry asking for more :)
>>
>> 1. Your patch fixes improper initialized variable. Do you think it is
>> worth being applied?
>
> Yes, definitely: I've sent it in now. It's sadly missed 17.3.8
> (scheduled to be released about an hour ago), but hopefully we can get
> it in for a 17.3.9, if we have one. Else it'll be in 18.0.1.
>
>> 2. In the thread I mentioned in my first email Trevor mentioned that
>> he has seen error message 'Modifier 0x0 vs. tiling(0x7000000000000001)
>> mismatch' when trying to get chromium GLES accelerated. Maybe a stupid
>> question but is it possible that applications running at X can ask for
>> dri2 explicitly?
>
> He said that only happened when using the system (rather than bundled)
> libraries, which would presumably be using DRI2 by default. I've
> submitted a bug to OE to ask them to enable DRI3 by default, but in
> the meantime this Mesa fix should hopefully work anyway.
Thanks - I was thinking same. OE-Core enables DRI3 for x11 AND vulcan
only - and vulcan is not in my distro features (and does not make much
sense for VC4)

Added yocto mailing list to merge both threads together and avoid cross-tak.

Thanks again for taking care

Andreas

Re: [Mesa-dev] VC4 not working for me with mesa 17.3.7 - was [meta-raspberrypi] VC4 not working for me with mesa 17.3.7

[Andreas Müller]

On Mon, Apr 2, 2018 at 3:05 PM, Andreas Müller <schnitzeltony@gmail.com> wrote:
> On Mon, Apr 2, 2018 at 2:42 PM, Daniel Stone <daniel@fooishbar.org> wrote:
>> Hi Andreas,
>>
>> On 31 March 2018 at 15:18, Andreas Müller <schnitzeltony@gmail.com> wrote:
>>> Thanks for prompt an VERY helpful support. I did:
>>>
>>> * Check my configure and found: --disable-dri3!
>>> * Tested your patch (with --disable-dri3) and as expected it fixes the issue
>>> * Found what causes --disable-dri3 - it came in by the Openembedded
>>> update mentioned in first email. FWIW: I use a fork for
>>> meta-raspberrypi - the original is not affected so I am the only one
>>> with this issue...
>>
>> Glad to hear it!
>>
>>> I have two questions related to dri2/your patch (sorry asking for more :)
>>>
>>> 1. Your patch fixes improper initialized variable. Do you think it is
>>> worth being applied?
>>
>> Yes, definitely: I've sent it in now. It's sadly missed 17.3.8
>> (scheduled to be released about an hour ago), but hopefully we can get
>> it in for a 17.3.9, if we have one. Else it'll be in 18.0.1.
>>
>>> 2. In the thread I mentioned in my first email Trevor mentioned that
>>> he has seen error message 'Modifier 0x0 vs. tiling(0x7000000000000001)
>>> mismatch' when trying to get chromium GLES accelerated. Maybe a stupid
>>> question but is it possible that applications running at X can ask for
>>> dri2 explicitly?
>>
>> He said that only happened when using the system (rather than bundled)
>> libraries, which would presumably be using DRI2 by default. I've
>> submitted a bug to OE to ask them to enable DRI3 by default, but in
>> the meantime this Mesa fix should hopefully work anyway.
> Thanks - I was thinking same. OE-Core enables DRI3 for x11 AND vulcan
> only - and vulcan is not in my distro features (and does not make much
> sense for VC4)
>
> Added yocto mailing list to merge both threads together and avoid cross-tak.
>
> Thanks again for taking care
>
Hi Daniel,

Just sent out patches to oe-core

* Apply your patch with dri2 modifier init
* Prefer dri3 over dri2 for x11/opengl distro features

See what happens...

Cheers

Andreas

Re: [Mesa-dev] VC4 not working for me with mesa 17.3.7 - was [meta-raspberrypi] VC4 not working for me with mesa 17.3.7

[Trevor Woerner]

Even without the patch, simply adding:

	PACKAGECONFIG_append_pn-mesa = "dri3"

to my conf/local.conf has glmark2-es2 running, and chromium-x11 is running
accelerated out-of-the-box (i.e. I don't have to install the egl/gles
libraries it builds itself).

I'm re-building my rpi3-64 image to see if things are better there too under
vc4.

I guess the patch is to address some of the other things you were seeing?

Re: [Mesa-dev] VC4 not working for me with mesa 17.3.7 - was [meta-raspberrypi] VC4 not working for me with mesa 17.3.7

[Andreas Müller]

On Mon, Apr 2, 2018 at 11:12 PM, Trevor Woerner <twoerner@gmail.com> wrote:
Removed mesa-dev - this is oe specific only.
> Even without the patch, simply adding:
>
>         PACKAGECONFIG_append_pn-mesa = "dri3"
>
I checked again: BOTH meta-raspi-light and meta-raspberrypi do not
enable dri3 by default. Was sure to have checked that but since I am
working on too many issues at the same time I got confused
somewhere... Will send out something like [1] to meta-raspberrypi -
just to make sure this does not happen again. One of the next steps
for me will be migrating back to meta-raspberrypi anyway.
> to my conf/local.conf has glmark2-es2 running, and chromium-x11 is running
> accelerated out-of-the-box (i.e. I don't have to install the egl/gles
> libraries it builds itself).
Cool - have not seen it running without issues for very long time...
>
> I'm re-building my rpi3-64 image to see if things are better there too under
> vc4.
You'll let me know I guess...
>
> I guess the patch is to address some of the other things you were seeing?
No - after enabling dri3 all I tested so far was perfectly fine. But
maybe other graphic drivers are affected.

[1] https://github.com/schnitzeltony/meta-raspi-light/commit/c844b3bb1b4e2c6479c284bbf144dc95a282881a

Cheers

Andreas

Re: [Mesa-dev] VC4 not working for me with mesa 17.3.7 - was [meta-raspberrypi] VC4 not working for me with mesa 17.3.7

[Trevor Woerner]

On Mon 2018-04-02 @ 11:46:39 PM, Andreas Müller wrote:
> > to my conf/local.conf has glmark2-es2 running, and chromium-x11 is running
> > accelerated out-of-the-box (i.e. I don't have to install the egl/gles
> > libraries it builds itself).
> Cool - have not seen it running without issues for very long time...

Yes, this is a very nice side effect of your digging into this apparently
un-related issue! :-)

In my own layers I had a .bbappend that was copying the chromium-built
egl/gles libraries to the target, but it doesn't look like this is needed
anymore. I posted complete information here (as part of an issue you had
originally opened):

	https://github.com/OSSystems/meta-browser/pull/82#issuecomment-353528110

> >
> > I'm re-building my rpi3-64 image to see if things are better there too under
> > vc4.
> You'll let me know I guess...

Absolutely! But, you know chromium... I'll need an hour or two... ;-)
(my image has chromium, glmark2, mesa-demos, directfb, directfb-examples, Qt,
and a bunch of Qt demos. sadly, the directfb examples always work, it's
everything else that's a coin-toss!! haha)

> > I guess the patch is to address some of the other things you were seeing?
> No - after enabling dri3 all I tested so far was perfectly fine. But
> maybe other graphic drivers are affected.

Now I'm confused: is the patch needed?

Re: [Mesa-dev] VC4 not working for me with mesa 17.3.7 - was [meta-raspberrypi] VC4 not working for me with mesa 17.3.7

[Daniel Stone]

Hi Trevor,

On 2 April 2018 at 23:09, Trevor Woerner <twoerner@gmail.com> wrote:
> On Mon 2018-04-02 @ 11:46:39 PM, Andreas Müller wrote:
>> > to my conf/local.conf has glmark2-es2 running, and chromium-x11 is running
>> > accelerated out-of-the-box (i.e. I don't have to install the egl/gles
>> > libraries it builds itself).
>> Cool - have not seen it running without issues for very long time...
>
> Yes, this is a very nice side effect of your digging into this apparently
> un-related issue! :-)
>
> In my own layers I had a .bbappend that was copying the chromium-built
> egl/gles libraries to the target, but it doesn't look like this is needed
> anymore. I posted complete information here (as part of an issue you had
> originally opened):
>
>         https://github.com/OSSystems/meta-browser/pull/82#issuecomment-353528110

Right, you shouldn't need that at all. It's unlikely to do any good.
If it does solve anything, we'd love to hear about what so we can try
to fix it, like with this one.

>> > I'm re-building my rpi3-64 image to see if things are better there too under
>> > vc4.
>> You'll let me know I guess...
>
> Absolutely! But, you know chromium... I'll need an hour or two... ;-)
> (my image has chromium, glmark2, mesa-demos, directfb, directfb-examples, Qt,
> and a bunch of Qt demos. sadly, the directfb examples always work, it's
> everything else that's a coin-toss!! haha)

Right, Weston/etc would've worked fine as well: this is solely broken
on X11 with DRI3 disabled.

>> > I guess the patch is to address some of the other things you were seeing?
>> No - after enabling dri3 all I tested so far was perfectly fine. But
>> maybe other graphic drivers are affected.
>
> Now I'm confused: is the patch needed?

Yes and no. It only affects DRI2. Merging the patch fixes DRI2. Using
DRI3 avoids the problem altogether, and is better to be doing anyway.
If the recipes are going to continue to offer the option to disable
DRI3 and go DRI2-only with X11, then making sure that's fixed is
prudent. But the default should very definitely be DRI3.

Cheers,
Daniel

Re: [Mesa-dev] VC4 not working for me with mesa 17.3.7 - was [meta-raspberrypi] VC4 not working for me with mesa 17.3.7

[Andreas Müller]

On Mon, Apr 2, 2018 at 11:46 PM, Andreas Müller <schnitzeltony@gmail.com> wrote:
> On Mon, Apr 2, 2018 at 11:12 PM, Trevor Woerner <twoerner@gmail.com> wrote:
> Removed mesa-dev - this is oe specific only.
>> Even without the patch, simply adding:
>>
>>         PACKAGECONFIG_append_pn-mesa = "dri3"
>>
FYI: Just sent out a pull request enabling dri3 for meta-raspberrypi.
So whatever mushrooms oe-core guys are going to consume - we'll have
dri3 :)

Andreas

Re: [Mesa-dev] VC4 not working for me with mesa 17.3.7 - was [meta-raspberrypi] VC4 not working for me with mesa 17.3.7

[Trevor Woerner]

On Mon 2018-04-02 @ 11:46:39 PM, Andreas Müller wrote:
> On Mon, Apr 2, 2018 at 11:12 PM, Trevor Woerner <twoerner@gmail.com> wrote:
> > I'm re-building my rpi3-64 image to see if things are better there too under
> > vc4.
> You'll let me know I guess...

Everything's working :-) This is the first time I've seen graphics (x11)
working with rpi3-64.

mesa-demos, directfb-examples, chromium (accelerated!), qt5...

Re: [Mesa-dev] VC4 not working for me with mesa 17.3.7 - was [meta-raspberrypi] VC4 not working for me with mesa 17.3.7

[Andreas Müller]

On Tue, Apr 3, 2018 at 2:26 AM, Trevor Woerner <twoerner@gmail.com> wrote:
> On Mon 2018-04-02 @ 11:46:39 PM, Andreas Müller wrote:
>> On Mon, Apr 2, 2018 at 11:12 PM, Trevor Woerner <twoerner@gmail.com> wrote:
>> > I'm re-building my rpi3-64 image to see if things are better there too under
>> > vc4.
>> You'll let me know I guess...
>
> Everything's working :-) This is the first time I've seen graphics (x11)
> working with rpi3-64.
>
> mesa-demos, directfb-examples, chromium (accelerated!), qt5...
A bit too late but..

Happy Easter!

Andreas