From: "Michael S. Tsirkin" <mst@redhat.com>
To: Si-Wei Liu <si-wei.liu@oracle.com>
Cc: jiri@resnulli.us, stephen@networkplumber.org,
alexander.h.duyck@intel.com, davem@davemloft.net,
jesse.brandeburg@intel.com, kubakici@wp.pl, jasowang@redhat.com,
sridhar.samudrala@intel.com, netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org,
virtio-dev@lists.oasis-open.org
Subject: [virtio-dev] Re: [RFC PATCH 3/3] virtio_net: make lower netdevs for virtio_bypass hidden
Date: Tue, 3 Apr 2018 15:20:27 +0300 [thread overview]
Message-ID: <20180403151915-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <1522573990-5242-4-git-send-email-si-wei.liu@oracle.com>
On Sun, Apr 01, 2018 at 05:13:10AM -0400, Si-Wei Liu wrote:
> diff --git a/include/uapi/linux/virtio_net.h b/include/uapi/linux/virtio_net.h
> index aa40664..0827b7e 100644
> --- a/include/uapi/linux/virtio_net.h
> +++ b/include/uapi/linux/virtio_net.h
> @@ -80,6 +80,8 @@ struct virtio_net_config {
> __u16 max_virtqueue_pairs;
> /* Default maximum transmit unit advice */
> __u16 mtu;
> + /* Device at bus:slot.function backed up by virtio_net */
> + __u16 bsf2backup;
> } __attribute__((packed));
I'm not sure this is a good interface. This isn't unique even on some
PCI systems, not to speak of non-PCI ones.
> /*
> --
> 1.8.3.1
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Si-Wei Liu <si-wei.liu@oracle.com>
Cc: jiri@resnulli.us, stephen@networkplumber.org,
alexander.h.duyck@intel.com, davem@davemloft.net,
jesse.brandeburg@intel.com, kubakici@wp.pl, jasowang@redhat.com,
sridhar.samudrala@intel.com, netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org,
virtio-dev@lists.oasis-open.org
Subject: Re: [RFC PATCH 3/3] virtio_net: make lower netdevs for virtio_bypass hidden
Date: Tue, 3 Apr 2018 15:20:27 +0300 [thread overview]
Message-ID: <20180403151915-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <1522573990-5242-4-git-send-email-si-wei.liu@oracle.com>
On Sun, Apr 01, 2018 at 05:13:10AM -0400, Si-Wei Liu wrote:
> diff --git a/include/uapi/linux/virtio_net.h b/include/uapi/linux/virtio_net.h
> index aa40664..0827b7e 100644
> --- a/include/uapi/linux/virtio_net.h
> +++ b/include/uapi/linux/virtio_net.h
> @@ -80,6 +80,8 @@ struct virtio_net_config {
> __u16 max_virtqueue_pairs;
> /* Default maximum transmit unit advice */
> __u16 mtu;
> + /* Device at bus:slot.function backed up by virtio_net */
> + __u16 bsf2backup;
> } __attribute__((packed));
I'm not sure this is a good interface. This isn't unique even on some
PCI systems, not to speak of non-PCI ones.
> /*
> --
> 1.8.3.1
next prev parent reply other threads:[~2018-04-03 12:20 UTC|newest]
Thread overview: 109+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-01 9:13 [virtio-dev] [RFC PATCH 0/3] Userspace compatible driver model for virtio_bypass Si-Wei Liu
2018-04-01 9:13 ` Si-Wei Liu
2018-04-01 9:13 ` [virtio-dev] [RFC PATCH 1/3] qemu: virtio-bypass should explicitly bind to a passthrough device Si-Wei Liu
2018-04-01 9:13 ` Si-Wei Liu
2018-04-03 12:25 ` Michael S. Tsirkin
2018-04-03 12:25 ` [virtio-dev] " Michael S. Tsirkin
2018-04-03 12:25 ` Michael S. Tsirkin
2018-04-04 8:02 ` [virtio-dev] " Siwei Liu
2018-04-04 8:02 ` Siwei Liu
2018-04-05 15:31 ` Paolo Bonzini
2018-04-07 2:54 ` Siwei Liu
2018-04-07 2:54 ` Siwei Liu
2018-04-07 2:54 ` [virtio-dev] " Siwei Liu
2018-04-04 8:02 ` Siwei Liu
2018-04-01 9:13 ` [virtio-dev] [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice Si-Wei Liu
2018-04-01 9:13 ` Si-Wei Liu
2018-04-01 16:11 ` David Ahern
2018-04-03 7:40 ` Siwei Liu
2018-04-03 7:40 ` [virtio-dev] " Siwei Liu
2018-04-03 7:40 ` Siwei Liu
2018-04-03 14:57 ` David Ahern
2018-04-03 15:42 ` Jiri Pirko
2018-04-03 19:23 ` [virtio-dev] " Siwei Liu
2018-04-03 19:23 ` Siwei Liu
2018-04-03 19:23 ` Siwei Liu
2018-04-04 1:04 ` David Ahern
2018-04-04 6:19 ` Jiri Pirko
2018-04-04 6:19 ` Jiri Pirko
2018-04-04 8:01 ` Siwei Liu
2018-04-04 8:01 ` [virtio-dev] " Siwei Liu
2018-04-04 8:01 ` Siwei Liu
2018-04-04 7:36 ` Siwei Liu
2018-04-04 7:36 ` [virtio-dev] " Siwei Liu
2018-04-04 7:36 ` Siwei Liu
2018-04-04 17:21 ` David Ahern
2018-04-04 17:37 ` David Miller
2018-04-04 18:20 ` Jiri Pirko
2018-04-04 18:20 ` Jiri Pirko
2018-04-07 2:32 ` [virtio-dev] " Siwei Liu
2018-04-07 2:32 ` Siwei Liu
2018-04-07 3:19 ` Andrew Lunn
2018-04-09 22:07 ` [virtio-dev] " Siwei Liu
2018-04-09 22:07 ` Siwei Liu
2018-04-09 22:15 ` Andrew Lunn
2018-04-09 22:15 ` Andrew Lunn
2018-04-09 22:30 ` [virtio-dev] " Siwei Liu
2018-04-09 22:30 ` Siwei Liu
2018-04-09 23:03 ` Stephen Hemminger
2018-04-09 23:31 ` [virtio-dev] " Siwei Liu
2018-04-09 23:31 ` Siwei Liu
2018-04-09 23:31 ` Siwei Liu
2018-04-09 23:03 ` Stephen Hemminger
2018-04-09 22:07 ` Siwei Liu
2018-04-08 16:32 ` David Miller
2018-04-10 6:48 ` Siwei Liu
2018-04-10 6:48 ` [virtio-dev] " Siwei Liu
2018-04-10 6:48 ` Siwei Liu
2018-04-18 0:26 ` Siwei Liu
2018-04-18 0:26 ` [virtio-dev] " Siwei Liu
2018-04-18 0:26 ` Siwei Liu
2018-04-18 23:33 ` [virtio-dev] " Samudrala, Sridhar
2018-04-18 23:33 ` Samudrala, Sridhar
2018-04-19 4:41 ` [virtio-dev] " Michael S. Tsirkin
2018-04-19 4:41 ` Michael S. Tsirkin
2018-04-19 4:41 ` Michael S. Tsirkin
2018-04-19 5:00 ` [virtio-dev] " Samudrala, Sridhar
2018-04-19 5:00 ` Samudrala, Sridhar
2018-04-19 5:07 ` Michael S. Tsirkin
2018-04-19 5:07 ` Michael S. Tsirkin
2018-04-19 6:10 ` [virtio-dev] " Samudrala, Sridhar
2018-04-19 6:10 ` Samudrala, Sridhar
2018-04-19 6:10 ` Samudrala, Sridhar
2018-04-19 6:43 ` Siwei Liu
2018-04-19 6:43 ` Siwei Liu
2018-04-19 6:43 ` Siwei Liu
2018-04-19 5:07 ` Michael S. Tsirkin
2018-04-19 6:31 ` Siwei Liu
2018-04-19 6:31 ` Siwei Liu
2018-04-19 6:31 ` [virtio-dev] " Siwei Liu
2018-04-19 5:00 ` Samudrala, Sridhar
2018-04-18 23:33 ` Samudrala, Sridhar
2018-04-08 16:32 ` David Miller
2018-04-04 17:37 ` David Miller
2018-04-04 18:02 ` Siwei Liu
2018-04-04 18:02 ` Siwei Liu
2018-04-04 8:28 ` [virtio-dev] " Siwei Liu
2018-04-04 8:28 ` Siwei Liu
2018-04-04 17:37 ` David Ahern
2018-04-04 17:42 ` David Miller
2018-04-04 17:42 ` David Miller
2018-04-04 17:44 ` Stephen Hemminger
2018-04-04 17:44 ` Stephen Hemminger
2018-04-04 20:08 ` Andrew Lunn
2018-04-04 20:08 ` Andrew Lunn
2018-04-04 8:28 ` Siwei Liu
2018-04-03 15:42 ` Jiri Pirko
2018-04-03 17:35 ` Stephen Hemminger
[not found] ` <CADGSJ23vZdtQzWdc_6M_Hr4MUej--wgvJ785DwRF3VaPWS1rpA@mail.gmail.com>
[not found] ` <20180403160834.51594373@xeon-e3>
2018-04-06 21:29 ` [virtio-dev] " Siwei Liu
2018-04-06 21:29 ` Siwei Liu
2018-04-06 21:29 ` Siwei Liu
2018-04-03 17:35 ` Stephen Hemminger
2018-04-01 9:13 ` [virtio-dev] [RFC PATCH 3/3] virtio_net: make lower netdevs for virtio_bypass hidden Si-Wei Liu
2018-04-01 9:13 ` Si-Wei Liu
2018-04-03 12:20 ` Michael S. Tsirkin [this message]
2018-04-03 12:20 ` Michael S. Tsirkin
2018-04-04 8:03 ` [virtio-dev] " Siwei Liu
2018-04-04 8:03 ` Siwei Liu
2018-04-04 8:03 ` Siwei Liu
2018-04-03 12:20 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180403151915-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=jesse.brandeburg@intel.com \
--cc=jiri@resnulli.us \
--cc=kubakici@wp.pl \
--cc=netdev@vger.kernel.org \
--cc=si-wei.liu@oracle.com \
--cc=sridhar.samudrala@intel.com \
--cc=stephen@networkplumber.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.