From: Vinod Koul <vinod.koul@intel.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: "Dan Williams" <dan.j.williams@intel.com>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Kuninori Morimoto" <kuninori.morimoto.gx@renesas.com>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
dmaengine@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: dmaengine: rcar-dmac: Fix too early/late system suspend/resume callbacks
Date: Wed, 4 Apr 2018 11:24:21 +0530 [thread overview]
Message-ID: <20180404055420.GE15443@localhost> (raw)
On Thu, Mar 29, 2018 at 06:53:32PM +0200, Geert Uytterhoeven wrote:
> If serial console wake-up is enabled ("echo enabled >
> /sys/.../ttySC0/power/wakeup"), and any serial input is received while
> the system is suspended, serial port input no longer works after system
> resume.
>
> Note that:
> 1) The system can still be woken up using the serial console,
> 2) Serial port input keeps working if the system is woken up in some
> other way (e.g. Wake-on-LAN or gpio-keys), and no serial input was
> received while suspended.
>
> To fix this, replace SET_LATE_SYSTEM_SLEEP_PM_OPS() by
> SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(), as the callbacks installed by the
> former happen too early resp. late in the suspend resp. resume process.
Applied, thanks
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: "Dan Williams" <dan.j.williams@intel.com>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Kuninori Morimoto" <kuninori.morimoto.gx@renesas.com>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
dmaengine@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: rcar-dmac: Fix too early/late system suspend/resume callbacks
Date: Wed, 4 Apr 2018 11:24:21 +0530 [thread overview]
Message-ID: <20180404055420.GE15443@localhost> (raw)
In-Reply-To: <1522342412-10126-1-git-send-email-geert+renesas@glider.be>
On Thu, Mar 29, 2018 at 06:53:32PM +0200, Geert Uytterhoeven wrote:
> If serial console wake-up is enabled ("echo enabled >
> /sys/.../ttySC0/power/wakeup"), and any serial input is received while
> the system is suspended, serial port input no longer works after system
> resume.
>
> Note that:
> 1) The system can still be woken up using the serial console,
> 2) Serial port input keeps working if the system is woken up in some
> other way (e.g. Wake-on-LAN or gpio-keys), and no serial input was
> received while suspended.
>
> To fix this, replace SET_LATE_SYSTEM_SLEEP_PM_OPS() by
> SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(), as the callbacks installed by the
> former happen too early resp. late in the suspend resp. resume process.
Applied, thanks
--
~Vinod
next reply other threads:[~2018-04-04 5:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 5:54 Vinod Koul [this message]
2018-04-04 5:54 ` [PATCH] dmaengine: rcar-dmac: Fix too early/late system suspend/resume callbacks Vinod Koul
-- strict thread matches above, loose matches on Subject: below --
2018-03-29 16:53 Geert Uytterhoeven
2018-03-29 16:53 ` [PATCH] " Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180404055420.GE15443@localhost \
--to=vinod.koul@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=rafael.j.wysocki@intel.com \
--cc=ulf.hansson@linaro.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.