From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Sergey Suloev <ssuloev@orpaltech.com>
Cc: Mark Brown <broonie@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/6] spi: sun4i: coding style/readability improvements
Date: Wed, 4 Apr 2018 09:13:01 +0200 [thread overview]
Message-ID: <20180404071301.hr3t225bt3dstikr@flea> (raw)
In-Reply-To: <20180403152905.1524-4-ssuloev@orpaltech.com>
[-- Attachment #1: Type: text/plain, Size: 439 bytes --]
On Tue, Apr 03, 2018 at 06:29:02PM +0300, Sergey Suloev wrote:
> Minor changes to fulfill the coding style and
> improve the readability.
Again, this is a very subjective statement. Overall, I'm not convinced
by the idea of moving code around and shuffling variables assignments
just for the sake of it.
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@bootlin.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/6] spi: sun4i: coding style/readability improvements
Date: Wed, 4 Apr 2018 09:13:01 +0200 [thread overview]
Message-ID: <20180404071301.hr3t225bt3dstikr@flea> (raw)
In-Reply-To: <20180403152905.1524-4-ssuloev@orpaltech.com>
On Tue, Apr 03, 2018 at 06:29:02PM +0300, Sergey Suloev wrote:
> Minor changes to fulfill the coding style and
> improve the readability.
Again, this is a very subjective statement. Overall, I'm not convinced
by the idea of moving code around and shuffling variables assignments
just for the sake of it.
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180404/65893e53/attachment.sig>
next prev parent reply other threads:[~2018-04-04 7:13 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-03 15:28 [PATCH v2 0/6] spi: Add support for DMA transfers in sun4i SPI driver Sergey Suloev
2018-04-03 15:28 ` Sergey Suloev
2018-04-03 15:29 ` [PATCH v2 1/6] spi: core: handle timeout error from transfer_one() Sergey Suloev
2018-04-03 15:29 ` Sergey Suloev
2018-04-03 15:52 ` Mark Brown
2018-04-03 15:52 ` Mark Brown
2018-04-03 16:00 ` Sergey Suloev
2018-04-03 16:00 ` Sergey Suloev
2018-04-03 16:18 ` Mark Brown
2018-04-03 16:18 ` Mark Brown
2018-04-03 16:24 ` Sergey Suloev
2018-04-03 16:24 ` Sergey Suloev
2018-04-04 7:08 ` Maxime Ripard
2018-04-04 7:08 ` Maxime Ripard
2018-04-04 10:42 ` Mark Brown
2018-04-04 10:42 ` Mark Brown
2018-04-04 19:19 ` Sergey Suloev
2018-04-04 19:19 ` Sergey Suloev
2018-04-03 15:29 ` [PATCH v2 2/6] spi: sun4i: restrict transfer length in PIO-mode Sergey Suloev
2018-04-03 15:29 ` Sergey Suloev
2018-04-04 7:10 ` Maxime Ripard
2018-04-04 7:10 ` Maxime Ripard
2018-04-03 15:29 ` [PATCH v2 3/6] spi: sun4i: coding style/readability improvements Sergey Suloev
2018-04-03 15:29 ` Sergey Suloev
2018-04-04 7:13 ` Maxime Ripard [this message]
2018-04-04 7:13 ` Maxime Ripard
2018-04-03 15:29 ` [PATCH v2 4/6] spi: sun4i: use completion provided by SPI core driver Sergey Suloev
2018-04-03 15:29 ` Sergey Suloev
2018-04-04 7:13 ` Maxime Ripard
2018-04-04 7:13 ` Maxime Ripard
2018-04-03 15:29 ` [PATCH v2 5/6] spi: sun4i: introduce register set/unset helpers Sergey Suloev
2018-04-03 15:29 ` Sergey Suloev
2018-04-03 15:29 ` Sergey Suloev
2018-04-04 7:14 ` Maxime Ripard
2018-04-04 7:14 ` Maxime Ripard
2018-04-03 15:29 ` [PATCH v2 6/6] spi: sun4i: add DMA transfers support Sergey Suloev
2018-04-03 15:29 ` Sergey Suloev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180404071301.hr3t225bt3dstikr@flea \
--to=maxime.ripard@bootlin.com \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=ssuloev@orpaltech.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.