From: brgl@bgdev.pl (Bartosz Golaszewski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] ARM: imx: vpr200: drop at24_platform_data
Date: Wed, 4 Apr 2018 15:16:24 +0200 [thread overview]
Message-ID: <20180404131627.9135-2-brgl@bgdev.pl> (raw)
In-Reply-To: <20180404131627.9135-1-brgl@bgdev.pl>
The information contained in the platform data struct is redundant.
Page size == 1 is the safe default assumed if no pagesize property is
given. The EEPROM size can be indicated to the driver using the
correct model name.
Drop the at24_platform_data entirely.
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
---
arch/arm/mach-imx/mach-vpr200.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/arch/arm/mach-imx/mach-vpr200.c b/arch/arm/mach-imx/mach-vpr200.c
index 5ff154c9a086..da3336aaa4c5 100644
--- a/arch/arm/mach-imx/mach-vpr200.c
+++ b/arch/arm/mach-imx/mach-vpr200.c
@@ -29,7 +29,6 @@
#include <asm/mach/time.h>
#include <linux/i2c.h>
-#include <linux/platform_data/at24.h>
#include <linux/mfd/mc13xxx.h>
#include "common.h"
@@ -145,15 +144,9 @@ static const struct imxi2c_platform_data vpr200_i2c0_data __initconst = {
.bitrate = 50000,
};
-static struct at24_platform_data vpr200_eeprom = {
- .byte_len = 2048 / 8,
- .page_size = 1,
-};
-
static struct i2c_board_info vpr200_i2c_devices[] = {
{
- I2C_BOARD_INFO("at24", 0x50), /* E0=0, E1=0, E2=0 */
- .platform_data = &vpr200_eeprom,
+ I2C_BOARD_INFO("24c02", 0x50), /* E0=0, E1=0, E2=0 */
}, {
I2C_BOARD_INFO("mc13892", 0x08),
.platform_data = &vpr200_pmic,
--
2.16.3
WARNING: multiple messages have this Message-ID (diff)
From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
Russell King <linux@armlinux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Bartosz Golaszewski <brgl@bgdev.pl>
Subject: [PATCH 1/4] ARM: imx: vpr200: drop at24_platform_data
Date: Wed, 4 Apr 2018 15:16:24 +0200 [thread overview]
Message-ID: <20180404131627.9135-2-brgl@bgdev.pl> (raw)
In-Reply-To: <20180404131627.9135-1-brgl@bgdev.pl>
The information contained in the platform data struct is redundant.
Page size == 1 is the safe default assumed if no pagesize property is
given. The EEPROM size can be indicated to the driver using the
correct model name.
Drop the at24_platform_data entirely.
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
---
arch/arm/mach-imx/mach-vpr200.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/arch/arm/mach-imx/mach-vpr200.c b/arch/arm/mach-imx/mach-vpr200.c
index 5ff154c9a086..da3336aaa4c5 100644
--- a/arch/arm/mach-imx/mach-vpr200.c
+++ b/arch/arm/mach-imx/mach-vpr200.c
@@ -29,7 +29,6 @@
#include <asm/mach/time.h>
#include <linux/i2c.h>
-#include <linux/platform_data/at24.h>
#include <linux/mfd/mc13xxx.h>
#include "common.h"
@@ -145,15 +144,9 @@ static const struct imxi2c_platform_data vpr200_i2c0_data __initconst = {
.bitrate = 50000,
};
-static struct at24_platform_data vpr200_eeprom = {
- .byte_len = 2048 / 8,
- .page_size = 1,
-};
-
static struct i2c_board_info vpr200_i2c_devices[] = {
{
- I2C_BOARD_INFO("at24", 0x50), /* E0=0, E1=0, E2=0 */
- .platform_data = &vpr200_eeprom,
+ I2C_BOARD_INFO("24c02", 0x50), /* E0=0, E1=0, E2=0 */
}, {
I2C_BOARD_INFO("mc13892", 0x08),
.platform_data = &vpr200_pmic,
--
2.16.3
next prev parent reply other threads:[~2018-04-04 13:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 13:16 [PATCH 0/4] ARM: imx: use device properties for at24 eeprom Bartosz Golaszewski
2018-04-04 13:16 ` Bartosz Golaszewski
2018-04-04 13:16 ` Bartosz Golaszewski [this message]
2018-04-04 13:16 ` [PATCH 1/4] ARM: imx: vpr200: drop at24_platform_data Bartosz Golaszewski
2018-04-04 13:16 ` [PATCH 2/4] ARM: imx: pcm043: use device properties for at24 eeprom Bartosz Golaszewski
2018-04-04 13:16 ` Bartosz Golaszewski
2018-04-04 13:16 ` [PATCH 3/4] ARM: imx: pca100: " Bartosz Golaszewski
2018-04-04 13:16 ` Bartosz Golaszewski
2018-04-04 13:16 ` [PATCH 4/4] ARM: imx: pcm037: " Bartosz Golaszewski
2018-04-04 13:16 ` Bartosz Golaszewski
2018-04-06 12:17 ` [PATCH 0/4] ARM: imx: " Sascha Hauer
2018-04-06 12:17 ` Sascha Hauer
2018-04-18 3:19 ` Shawn Guo
2018-04-18 3:19 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180404131627.9135-2-brgl@bgdev.pl \
--to=brgl@bgdev.pl \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.