From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Eric Biggers <ebiggers@google.com>
Cc: fstests@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [xfstests-bld PATCH] test-appliance: support f2fs-tools v1.9 and later
Date: Fri, 6 Apr 2018 09:30:36 -0400 [thread overview]
Message-ID: <20180406133036.GD7345@thunk.org> (raw)
In-Reply-To: <20180405222141.42376-1-ebiggers@google.com>
On Thu, Apr 05, 2018 at 03:21:41PM -0700, Eric Biggers wrote:
> Pass the -f option to mkfs.f2fs when it appears to support it. This is
> required by f2fs-tools v1.9 and later in order to format the filesystem
> even when an existing filesystem is detected. But earlier versions did
> not accept this option.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Applied for now, but ugh. Grepping strings out of binaries is not
something I really like to depend upon. Can we convince the f2fs
folks to provide a "/sbin/mkfs.f2fs -V" which prints a version string,
or some such?
- Ted
WARNING: multiple messages have this Message-ID (diff)
From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Eric Biggers <ebiggers@google.com>
Cc: fstests@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [xfstests-bld PATCH] test-appliance: support f2fs-tools v1.9 and later
Date: Fri, 6 Apr 2018 09:30:36 -0400 [thread overview]
Message-ID: <20180406133036.GD7345@thunk.org> (raw)
In-Reply-To: <20180405222141.42376-1-ebiggers@google.com>
On Thu, Apr 05, 2018 at 03:21:41PM -0700, Eric Biggers wrote:
> Pass the -f option to mkfs.f2fs when it appears to support it. This is
> required by f2fs-tools v1.9 and later in order to format the filesystem
> even when an existing filesystem is detected. But earlier versions did
> not accept this option.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Applied for now, but ugh. Grepping strings out of binaries is not
something I really like to depend upon. Can we convince the f2fs
folks to provide a "/sbin/mkfs.f2fs -V" which prints a version string,
or some such?
- Ted
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
next prev parent reply other threads:[~2018-04-06 13:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-05 22:21 [xfstests-bld PATCH] test-appliance: support f2fs-tools v1.9 and later Eric Biggers
2018-04-05 22:21 ` Eric Biggers via Linux-f2fs-devel
2018-04-06 13:30 ` Theodore Y. Ts'o [this message]
2018-04-06 13:30 ` Theodore Y. Ts'o
2018-04-09 19:00 ` Eric Biggers
2018-04-09 19:00 ` Eric Biggers via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180406133036.GD7345@thunk.org \
--to=tytso@mit.edu \
--cc=ebiggers@google.com \
--cc=fstests@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.