From: Jonathan Cameron <jic23@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
nfarnesi4@gmail.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] iio: sca3000: Fix an error handling path in 'sca3000_probe()'
Date: Sun, 08 Apr 2018 16:32:20 +0000 [thread overview]
Message-ID: <20180408173220.7f2483c7@archlinux> (raw)
In-Reply-To: <20180402165942.9056-1-christophe.jaillet@wanadoo.fr>
On Mon, 2 Apr 2018 18:59:42 +0200
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> In case of error, we must undo the previous 'sca3000_configure_ring()' call
> in order to free some memory.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Perhaps we can simplify this by using devm_iio_kfifo_allocate in
the ring configure function?
> ---
> drivers/iio/accel/sca3000.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c
> index f33dadf7b262..dae4c594c170 100644
> --- a/drivers/iio/accel/sca3000.c
> +++ b/drivers/iio/accel/sca3000.c
> @@ -1496,7 +1496,7 @@ static int sca3000_probe(struct spi_device *spi)
> "sca3000",
> indio_dev);
> if (ret)
> - return ret;
> + goto error_unconfigure_ring;
> }
> indio_dev->setup_ops = &sca3000_ring_setup_ops;
> ret = sca3000_clean_setup(st);
> @@ -1513,6 +1513,9 @@ static int sca3000_probe(struct spi_device *spi)
> if (spi->irq)
> free_irq(spi->irq, indio_dev);
>
> +error_unconfigure_ring:
> + sca3000_unconfigure_ring(indio_dev);
> +
> return ret;
> }
>
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
nfarnesi4@gmail.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] iio: sca3000: Fix an error handling path in 'sca3000_probe()'
Date: Sun, 8 Apr 2018 17:32:20 +0100 [thread overview]
Message-ID: <20180408173220.7f2483c7@archlinux> (raw)
In-Reply-To: <20180402165942.9056-1-christophe.jaillet@wanadoo.fr>
On Mon, 2 Apr 2018 18:59:42 +0200
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> In case of error, we must undo the previous 'sca3000_configure_ring()' call
> in order to free some memory.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Perhaps we can simplify this by using devm_iio_kfifo_allocate in
the ring configure function?
> ---
> drivers/iio/accel/sca3000.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c
> index f33dadf7b262..dae4c594c170 100644
> --- a/drivers/iio/accel/sca3000.c
> +++ b/drivers/iio/accel/sca3000.c
> @@ -1496,7 +1496,7 @@ static int sca3000_probe(struct spi_device *spi)
> "sca3000",
> indio_dev);
> if (ret)
> - return ret;
> + goto error_unconfigure_ring;
> }
> indio_dev->setup_ops = &sca3000_ring_setup_ops;
> ret = sca3000_clean_setup(st);
> @@ -1513,6 +1513,9 @@ static int sca3000_probe(struct spi_device *spi)
> if (spi->irq)
> free_irq(spi->irq, indio_dev);
>
> +error_unconfigure_ring:
> + sca3000_unconfigure_ring(indio_dev);
> +
> return ret;
> }
>
next prev parent reply other threads:[~2018-04-08 16:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-02 16:59 [PATCH 1/2] iio: sca3000: Fix an error handling path in 'sca3000_probe()' Christophe JAILLET
2018-04-02 16:59 ` Christophe JAILLET
2018-04-08 16:32 ` Jonathan Cameron [this message]
2018-04-08 16:32 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180408173220.7f2483c7@archlinux \
--to=jic23@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nfarnesi4@gmail.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.