* [PATCH] tools/memory-model: Update required version of herdtools7
@ 2018-04-08 0:18 Akira Yokosawa
2018-04-08 21:21 ` Paul E. McKenney
0 siblings, 1 reply; 2+ messages in thread
From: Akira Yokosawa @ 2018-04-08 0:18 UTC (permalink / raw)
To: Paul E. McKenney
Cc: Alan Stern, Andrea Parri, Will Deacon, Peter Zijlstra, Boqun Feng,
Nicholas Piggin, David Howells, Jade Alglave, Luc Maranget,
Ingo Molnar, Akira Yokosawa, linux-kernel
>From 64542a47acf159d26b8290480c0af9c2a05d20d6 Mon Sep 17 00:00:00 2001
From: Akira Yokosawa <akiyks@gmail.com>
Date: Sun, 8 Apr 2018 07:44:55 +0900
Subject: [PATCH] tools/memory-model: Update required version of herdtools7
Code generated by klitmus7 version 7.48 doesn't compile with kernel
header of 4.15 and later due to the absence of ACCESS_ONCE().
As the issue has been resolved in herdtools7 7.49, bump the required
version number in README.
Signed-off-by: Akira Yokosawa <akiyks@gmail.com>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Andrea Parri <parri.andrea@gmail.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Boqun Feng <boqun.feng@gmail.com>
Cc: Nicholas Piggin <npiggin@gmail.com>
Cc: David Howells <dhowells@redhat.com>
Cc: Jade Alglave <j.alglave@ucl.ac.uk>
Cc: Luc Maranget <luc.maranget@inria.fr>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Ingo Molnar <mingo@redhat.com>
---
Hi Paul,
I think this is a 4.17 matter.
Thoughts?
Thanks, Akira
--
tools/memory-model/README | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/memory-model/README b/tools/memory-model/README
index 0b3a5f3..734f7fe 100644
--- a/tools/memory-model/README
+++ b/tools/memory-model/README
@@ -20,7 +20,7 @@ that litmus test to be exercised within the Linux kernel.
REQUIREMENTS
============
-Version 7.48 of the "herd7" and "klitmus7" tools must be downloaded
+Version 7.49 of the "herd7" and "klitmus7" tools must be downloaded
separately:
https://github.com/herd/herdtools7
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tools/memory-model: Update required version of herdtools7
2018-04-08 0:18 [PATCH] tools/memory-model: Update required version of herdtools7 Akira Yokosawa
@ 2018-04-08 21:21 ` Paul E. McKenney
0 siblings, 0 replies; 2+ messages in thread
From: Paul E. McKenney @ 2018-04-08 21:21 UTC (permalink / raw)
To: Akira Yokosawa
Cc: Alan Stern, Andrea Parri, Will Deacon, Peter Zijlstra, Boqun Feng,
Nicholas Piggin, David Howells, Jade Alglave, Luc Maranget,
Ingo Molnar, linux-kernel
On Sun, Apr 08, 2018 at 09:18:08AM +0900, Akira Yokosawa wrote:
> >From 64542a47acf159d26b8290480c0af9c2a05d20d6 Mon Sep 17 00:00:00 2001
> From: Akira Yokosawa <akiyks@gmail.com>
> Date: Sun, 8 Apr 2018 07:44:55 +0900
> Subject: [PATCH] tools/memory-model: Update required version of herdtools7
>
> Code generated by klitmus7 version 7.48 doesn't compile with kernel
> header of 4.15 and later due to the absence of ACCESS_ONCE().
> As the issue has been resolved in herdtools7 7.49, bump the required
> version number in README.
>
> Signed-off-by: Akira Yokosawa <akiyks@gmail.com>
> Cc: Alan Stern <stern@rowland.harvard.edu>
> Cc: Andrea Parri <parri.andrea@gmail.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Boqun Feng <boqun.feng@gmail.com>
> Cc: Nicholas Piggin <npiggin@gmail.com>
> Cc: David Howells <dhowells@redhat.com>
> Cc: Jade Alglave <j.alglave@ucl.ac.uk>
> Cc: Luc Maranget <luc.maranget@inria.fr>
> Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
> Cc: Ingo Molnar <mingo@redhat.com>
> ---
> Hi Paul,
>
> I think this is a 4.17 matter.
> Thoughts?
Good catch, queued and pushed, thank you!
I don't believe that this needs to go into the current merge window,
given that there is an easy workaround and that people running into this
will likely find your patch via web-seach, at which point they can update
their herdtools. But it should definitely go into v4.18!
Thanx, Paul
> Thanks, Akira
> --
> tools/memory-model/README | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/memory-model/README b/tools/memory-model/README
> index 0b3a5f3..734f7fe 100644
> --- a/tools/memory-model/README
> +++ b/tools/memory-model/README
> @@ -20,7 +20,7 @@ that litmus test to be exercised within the Linux kernel.
> REQUIREMENTS
> ============
>
> -Version 7.48 of the "herd7" and "klitmus7" tools must be downloaded
> +Version 7.49 of the "herd7" and "klitmus7" tools must be downloaded
> separately:
>
> https://github.com/herd/herdtools7
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-08 21:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-08 0:18 [PATCH] tools/memory-model: Update required version of herdtools7 Akira Yokosawa
2018-04-08 21:21 ` Paul E. McKenney
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.