* [Buildroot] [PATCH 1/1] mpd: add mms support
@ 2018-04-07 11:52 Fabrice Fontaine
2018-04-09 9:15 ` Thomas Petazzoni
2018-04-28 16:36 ` Thomas Petazzoni
0 siblings, 2 replies; 4+ messages in thread
From: Fabrice Fontaine @ 2018-04-07 11:52 UTC (permalink / raw)
To: buildroot
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/mpd/Config.in | 6 ++++++
package/mpd/mpd.mk | 7 +++++++
2 files changed, 13 insertions(+)
diff --git a/package/mpd/Config.in b/package/mpd/Config.in
index 6c7468e173..831e4ab0d7 100644
--- a/package/mpd/Config.in
+++ b/package/mpd/Config.in
@@ -180,6 +180,12 @@ config BR2_PACKAGE_MPD_CURL
help
Enable curl streaming (http) support.
+config BR2_PACKAGE_MPD_LIBMMS
+ bool "mms"
+ select BR2_PACKAGE_LIBMMS
+ help
+ Enable MMS support.
+
config BR2_PACKAGE_MPD_LIBNFS
bool "nfs"
# libnfs -> libtirpc
diff --git a/package/mpd/mpd.mk b/package/mpd/mpd.mk
index 639c8c1981..64471d4da5 100644
--- a/package/mpd/mpd.mk
+++ b/package/mpd/mpd.mk
@@ -120,6 +120,13 @@ else
MPD_CONF_OPTS += --disable-libmpdclient
endif
+ifeq ($(BR2_PACKAGE_MPD_LIBMMS),y)
+MPD_DEPENDENCIES += libmms
+MPD_CONF_OPTS += --enable-mms
+else
+MPD_CONF_OPTS += --disable-mms
+endif
+
ifeq ($(BR2_PACKAGE_MPD_LIBNFS),y)
MPD_DEPENDENCIES += libnfs
MPD_CONF_OPTS += --enable-nfs
--
2.14.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] mpd: add mms support
2018-04-07 11:52 [Buildroot] [PATCH 1/1] mpd: add mms support Fabrice Fontaine
@ 2018-04-09 9:15 ` Thomas Petazzoni
2018-04-17 17:25 ` Fabrice Fontaine
2018-04-28 16:36 ` Thomas Petazzoni
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2018-04-09 9:15 UTC (permalink / raw)
To: buildroot
Hello,
On Sat, 7 Apr 2018 13:52:30 +0200, Fabrice Fontaine wrote:
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/mpd/Config.in | 6 ++++++
> package/mpd/mpd.mk | 7 +++++++
> 2 files changed, 13 insertions(+)
>
> diff --git a/package/mpd/Config.in b/package/mpd/Config.in
> index 6c7468e173..831e4ab0d7 100644
> --- a/package/mpd/Config.in
> +++ b/package/mpd/Config.in
> @@ -180,6 +180,12 @@ config BR2_PACKAGE_MPD_CURL
> help
> Enable curl streaming (http) support.
>
> +config BR2_PACKAGE_MPD_LIBMMS
> + bool "mms"
> + select BR2_PACKAGE_LIBMMS
> + help
> + Enable MMS support.
Shouldn't we propagate the dependencies of the libmms package ?
I suppose most (all ?) of them are already covered by the
BR2_PACKAGE_MPD option, but shouldn't we propagate them anyway, in case
we change the dependencies of BR2_PACKAGE_MPD in the future ?
Do we a clear policy on this ?
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] mpd: add mms support
2018-04-09 9:15 ` Thomas Petazzoni
@ 2018-04-17 17:25 ` Fabrice Fontaine
0 siblings, 0 replies; 4+ messages in thread
From: Fabrice Fontaine @ 2018-04-17 17:25 UTC (permalink / raw)
To: buildroot
Dear Thomas,
2018-04-09 11:15 GMT+02:00 Thomas Petazzoni <thomas.petazzoni@bootlin.com>:
> Hello,
>
> On Sat, 7 Apr 2018 13:52:30 +0200, Fabrice Fontaine wrote:
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> > package/mpd/Config.in | 6 ++++++
> > package/mpd/mpd.mk | 7 +++++++
> > 2 files changed, 13 insertions(+)
> >
> > diff --git a/package/mpd/Config.in b/package/mpd/Config.in
> > index 6c7468e173..831e4ab0d7 100644
> > --- a/package/mpd/Config.in
> > +++ b/package/mpd/Config.in
> > @@ -180,6 +180,12 @@ config BR2_PACKAGE_MPD_CURL
> > help
> > Enable curl streaming (http) support.
> >
> > +config BR2_PACKAGE_MPD_LIBMMS
> > + bool "mms"
> > + select BR2_PACKAGE_LIBMMS
> > + help
> > + Enable MMS support.
>
> Shouldn't we propagate the dependencies of the libmms package ?
>
> I suppose most (all ?) of them are already covered by the
> BR2_PACKAGE_MPD option, but shouldn't we propagate them anyway, in case
> we change the dependencies of BR2_PACKAGE_MPD in the future ?
>
> Do we a clear policy on this ?
>
All libmms dependencies are already covered by mpd package.
It don't know if we have a clear policy for all packages.
However, for samba support, BR2_USE_MMU, BR2_USE_WCHAR and
BR2_TOOLCHAIN_HAS_THREADS_NPTL have not been propagated to mpd.
Same thing for jack support and BR2_USE_MMU / BR2_TOOLCHAIN_HAS_THREADS.
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
Best Regards,
Fabrice
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180417/695ce1ae/attachment.html>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] mpd: add mms support
2018-04-07 11:52 [Buildroot] [PATCH 1/1] mpd: add mms support Fabrice Fontaine
2018-04-09 9:15 ` Thomas Petazzoni
@ 2018-04-28 16:36 ` Thomas Petazzoni
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2018-04-28 16:36 UTC (permalink / raw)
To: buildroot
Hello,
On Sat, 7 Apr 2018 13:52:30 +0200, Fabrice Fontaine wrote:
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/mpd/Config.in | 6 ++++++
> package/mpd/mpd.mk | 7 +++++++
> 2 files changed, 13 insertions(+)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-04-28 16:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-07 11:52 [Buildroot] [PATCH 1/1] mpd: add mms support Fabrice Fontaine
2018-04-09 9:15 ` Thomas Petazzoni
2018-04-17 17:25 ` Fabrice Fontaine
2018-04-28 16:36 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.