All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Cc: mhiramat@kernel.org, peterz@infradead.org,
	srikar@linux.vnet.ibm.com, rostedt@goodmis.org, acme@kernel.org,
	ananth@linux.vnet.ibm.com, akpm@linux-foundation.org,
	alexander.shishkin@linux.intel.com, alexis.berlemont@gmail.com,
	corbet@lwn.net, dan.j.williams@intel.com, jolsa@redhat.com,
	kan.liang@intel.com, kjlx@templeofstupid.com,
	kstewart@linuxfoundation.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	milian.wolff@kdab.com, mingo@redhat.com, namhyung@kernel.org,
	naveen.n.rao@linux.vnet.ibm.com, pc@us.ibm.com,
	tglx@linutronix.de, yao.jin@linux.intel.com,
	fengguang.wu@intel.com, jglisse@redhat.com
Subject: Re: [PATCH v2 7/9] trace_uprobe/sdt: Fix multiple update of same reference counter
Date: Mon, 9 Apr 2018 15:17:31 +0200	[thread overview]
Message-ID: <20180409131730.GA25631@redhat.com> (raw)
In-Reply-To: <20180404083110.18647-8-ravi.bangoria@linux.vnet.ibm.com>

On 04/04, Ravi Bangoria wrote:
>
> +static void sdt_add_mm_list(struct trace_uprobe *tu, struct mm_struct *mm)
> +{
> +	struct mmu_notifier *mn;
> +	struct sdt_mm_list *sml = kzalloc(sizeof(*sml), GFP_KERNEL);
> +
> +	if (!sml)
> +		return;
> +	sml->mm = mm;
> +	list_add(&(sml->list), &(tu->sml.list));
> +
> +	/* Register mmu_notifier for this mm. */
> +	mn = kzalloc(sizeof(*mn), GFP_KERNEL);
> +	if (!mn)
> +		return;
> +
> +	mn->ops = &sdt_mmu_notifier_ops;
> +	__mmu_notifier_register(mn, mm);
> +}

I didn't read this version yet, just one question...

So now it depends on CONFIG_MMU_NOTIFIER, yes? I do not see any changes in Kconfig
files, this doesn't look right...

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Oleg Nesterov <oleg@redhat.com>
To: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Cc: mhiramat@kernel.org, peterz@infradead.org,
	srikar@linux.vnet.ibm.com, rostedt@goodmis.org, acme@kernel.org,
	ananth@linux.vnet.ibm.com, akpm@linux-foundation.org,
	alexander.shishkin@linux.intel.com, alexis.berlemont@gmail.com,
	corbet@lwn.net, dan.j.williams@intel.com, jolsa@redhat.com,
	kan.liang@intel.com, kjlx@templeofstupid.com,
	kstewart@linuxfoundation.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	milian.wolff@kdab.com, mingo@redhat.com, namhyung@kernel.org,
	naveen.n.rao@linux.vnet.ibm.com, pc@us.ibm.com,
	tglx@linutronix.de, yao.jin@linux.intel.com,
	fengguang.wu@intel.com, jglisse@redhat.com
Subject: Re: [PATCH v2 7/9] trace_uprobe/sdt: Fix multiple update of same reference counter
Date: Mon, 9 Apr 2018 15:17:31 +0200	[thread overview]
Message-ID: <20180409131730.GA25631@redhat.com> (raw)
In-Reply-To: <20180404083110.18647-8-ravi.bangoria@linux.vnet.ibm.com>

On 04/04, Ravi Bangoria wrote:
>
> +static void sdt_add_mm_list(struct trace_uprobe *tu, struct mm_struct *mm)
> +{
> +	struct mmu_notifier *mn;
> +	struct sdt_mm_list *sml = kzalloc(sizeof(*sml), GFP_KERNEL);
> +
> +	if (!sml)
> +		return;
> +	sml->mm = mm;
> +	list_add(&(sml->list), &(tu->sml.list));
> +
> +	/* Register mmu_notifier for this mm. */
> +	mn = kzalloc(sizeof(*mn), GFP_KERNEL);
> +	if (!mn)
> +		return;
> +
> +	mn->ops = &sdt_mmu_notifier_ops;
> +	__mmu_notifier_register(mn, mm);
> +}

I didn't read this version yet, just one question...

So now it depends on CONFIG_MMU_NOTIFIER, yes? I do not see any changes in Kconfig
files, this doesn't look right...

Oleg.

  parent reply	other threads:[~2018-04-09 13:17 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-04  8:31 [PATCH v2 0/9] trace_uprobe: Support SDT markers having reference count (semaphore) Ravi Bangoria
2018-04-04  8:31 ` Ravi Bangoria
2018-04-04  8:31 ` [PATCH v2 1/9] Uprobe: Export vaddr <-> offset conversion functions Ravi Bangoria
2018-04-04  8:31   ` Ravi Bangoria
2018-04-04  8:31   ` Ravi Bangoria
2018-04-04  8:31 ` [PATCH v2 2/9] mm: Prefix vma_ to vaddr_to_offset() and offset_to_vaddr() Ravi Bangoria
2018-04-04  8:31   ` Ravi Bangoria
2018-04-04  8:31   ` Ravi Bangoria
2018-04-04  8:31 ` [PATCH v2 3/9] Uprobe: Move mmput() into free_map_info() Ravi Bangoria
2018-04-04  8:31   ` Ravi Bangoria
2018-04-04  8:31 ` [PATCH v2 4/9] Uprobe: Rename map_info to uprobe_map_info Ravi Bangoria
2018-04-04  8:31   ` Ravi Bangoria
2018-04-04  8:31   ` Ravi Bangoria
2018-04-04  8:31 ` [PATCH v2 5/9] Uprobe: Export uprobe_map_info along with uprobe_{build/free}_map_info() Ravi Bangoria
2018-04-04  8:31   ` Ravi Bangoria
2018-04-04  8:31   ` Ravi Bangoria
2018-04-04  8:31 ` [PATCH v2 6/9] trace_uprobe: Support SDT markers having reference count (semaphore) Ravi Bangoria
2018-04-04  8:31   ` Ravi Bangoria
2018-04-04 15:03   ` kbuild test robot
2018-04-04 15:03     ` kbuild test robot
2018-04-04 15:03     ` kbuild test robot
2018-04-04 15:03   ` [RFC PATCH] trace_uprobe: trace_uprobe_mmap() can be static kbuild test robot
2018-04-04 15:03     ` kbuild test robot
2018-04-04 15:03     ` kbuild test robot
2018-04-04  8:31 ` [PATCH v2 7/9] trace_uprobe/sdt: Fix multiple update of same reference counter Ravi Bangoria
2018-04-04  8:31   ` Ravi Bangoria
2018-04-04 13:18   ` kbuild test robot
2018-04-04 13:18     ` kbuild test robot
2018-04-04 13:24   ` kbuild test robot
2018-04-04 13:24     ` kbuild test robot
2018-04-09 13:17   ` Oleg Nesterov [this message]
2018-04-09 13:17     ` Oleg Nesterov
2018-04-09 13:32     ` Ravi Bangoria
2018-04-09 13:32       ` Ravi Bangoria
2018-04-09 13:41       ` Ravi Bangoria
2018-04-09 13:41         ` Ravi Bangoria
2018-04-09 13:29   ` Oleg Nesterov
2018-04-09 13:29     ` Oleg Nesterov
2018-04-10  8:19     ` Ravi Bangoria
2018-04-10  8:19       ` Ravi Bangoria
2018-04-10 11:06       ` Oleg Nesterov
2018-04-10 11:06         ` Oleg Nesterov
2018-04-11  4:28         ` Ravi Bangoria
2018-04-11  4:28           ` Ravi Bangoria
2018-04-04  8:31 ` [PATCH v2 8/9] trace_uprobe/sdt: Document about " Ravi Bangoria
2018-04-04  8:31   ` Ravi Bangoria
2018-04-04  8:31 ` [PATCH v2 9/9] perf probe: Support SDT markers having reference counter (semaphore) Ravi Bangoria
2018-04-04  8:31   ` Ravi Bangoria
2018-04-09  7:28   ` Masami Hiramatsu
2018-04-09  7:28     ` Masami Hiramatsu
2018-04-09  8:29     ` Ravi Bangoria
2018-04-09  8:29       ` Ravi Bangoria
2018-04-09  8:29       ` Ravi Bangoria
2018-04-09 14:08       ` Masami Hiramatsu
2018-04-09 14:08         ` Masami Hiramatsu
2018-04-09 14:08         ` Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180409131730.GA25631@redhat.com \
    --to=oleg@redhat.com \
    --cc=acme@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=alexis.berlemont@gmail.com \
    --cc=ananth@linux.vnet.ibm.com \
    --cc=corbet@lwn.net \
    --cc=dan.j.williams@intel.com \
    --cc=fengguang.wu@intel.com \
    --cc=jglisse@redhat.com \
    --cc=jolsa@redhat.com \
    --cc=kan.liang@intel.com \
    --cc=kjlx@templeofstupid.com \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhiramat@kernel.org \
    --cc=milian.wolff@kdab.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=naveen.n.rao@linux.vnet.ibm.com \
    --cc=pc@us.ibm.com \
    --cc=peterz@infradead.org \
    --cc=ravi.bangoria@linux.vnet.ibm.com \
    --cc=rostedt@goodmis.org \
    --cc=srikar@linux.vnet.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=yao.jin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.