All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/1] x86/platform/UV: UV Fix patches for Intel processors
@ 2018-03-28 17:40 mike.travis
  2018-03-28 17:40 ` [PATCH 1/1] x86/platform/UV: Fix critical UV MMR address error mike.travis
  0 siblings, 1 reply; 9+ messages in thread
From: mike.travis @ 2018-03-28 17:40 UTC (permalink / raw)
  To: Thomas Gleixner, Ingo Molnar
  Cc: Russ Anderson, Dimitri Sivanich, Andrew Banman, x86, linux-kernel


Updates to UV4 fix patches.

-- 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 1/1] x86/platform/UV: Fix critical UV MMR address error
  2018-03-28 17:40 [PATCH 0/1] x86/platform/UV: UV Fix patches for Intel processors mike.travis
@ 2018-03-28 17:40 ` mike.travis
  2018-03-28 18:17   ` Thomas Gleixner
  2018-03-28 18:25   ` [tip:x86/urgent] " tip-bot for mike.travis@hpe.com
  0 siblings, 2 replies; 9+ messages in thread
From: mike.travis @ 2018-03-28 17:40 UTC (permalink / raw)
  To: Thomas Gleixner, Ingo Molnar
  Cc: Russ Anderson, Dimitri Sivanich, Andrew Banman, x86, linux-kernel

[-- Attachment #1: fix-gam-mmioh-config1 --]
[-- Type: text/plain, Size: 1076 bytes --]

A critical error was found testing the fixed UV4 HUB in that an MMR
address was found to be incorrect.  This causes the virtual address
space for accessing the MMIOH1 region to be allocated with the
incorrect size.

Signed-off-by: Mike Travis <travis@sgi.com>
---
 arch/x86/include/asm/uv/uv_mmrs.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-4.4.orig/arch/x86/include/asm/uv/uv_mmrs.h
+++ linux-4.4/arch/x86/include/asm/uv/uv_mmrs.h
@@ -3833,7 +3833,7 @@ union uvh_rh_gam_mmioh_overlay_config0_m
 #define UV1H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR uv_undefined("UV1H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR")
 #define UV2H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR uv_undefined("UV2H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR")
 #define UV3H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR 0x1603000UL
-#define UV4H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR 0x483000UL
+#define UV4H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR 0x484000UL
 #define UVH_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR (				\
 	is_uv1_hub() ? UV1H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR :		\
 	is_uv2_hub() ? UV2H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR :		\

-- 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/1] x86/platform/UV: Fix critical UV MMR address error
  2018-03-28 17:40 ` [PATCH 1/1] x86/platform/UV: Fix critical UV MMR address error mike.travis
@ 2018-03-28 18:17   ` Thomas Gleixner
  2018-03-28 18:29     ` Mike Travis
  2018-03-28 18:25   ` [tip:x86/urgent] " tip-bot for mike.travis@hpe.com
  1 sibling, 1 reply; 9+ messages in thread
From: Thomas Gleixner @ 2018-03-28 18:17 UTC (permalink / raw)
  To: mike.travis
  Cc: Ingo Molnar, Russ Anderson, Dimitri Sivanich, Andrew Banman, x86,
	linux-kernel

On Wed, 28 Mar 2018, mike.travis@hpe.com wrote:

> A critical error was found testing the fixed UV4 HUB in that an MMR
> address was found to be incorrect.  This causes the virtual address
> space for accessing the MMIOH1 region to be allocated with the
> incorrect size.

Even if this is not intended for stable, despite the diff 

> --- linux-4.4.orig/arch/x86/include/asm/uv/uv_mmrs.h
> +++ linux-4.4/arch/x86/include/asm/uv/uv_mmrs.h

suggesting that this is against a kernel, which receives respiration
treatment, it would be appreciated if you could add a Fixes tag next time.

That spares me the time to figure out which commit introduced the wreckage
and therefore the scope of the fix. Added it myself.

Thanks,

	tglx

> @@ -3833,7 +3833,7 @@ union uvh_rh_gam_mmioh_overlay_config0_m
>  #define UV1H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR uv_undefined("UV1H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR")
>  #define UV2H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR uv_undefined("UV2H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR")
>  #define UV3H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR 0x1603000UL
> -#define UV4H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR 0x483000UL
> +#define UV4H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR 0x484000UL
>  #define UVH_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR (				\
>  	is_uv1_hub() ? UV1H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR :		\
>  	is_uv2_hub() ? UV2H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR :		\
> 
> -- 
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [tip:x86/urgent] x86/platform/UV: Fix critical UV MMR address error
  2018-03-28 17:40 ` [PATCH 1/1] x86/platform/UV: Fix critical UV MMR address error mike.travis
  2018-03-28 18:17   ` Thomas Gleixner
@ 2018-03-28 18:25   ` tip-bot for mike.travis@hpe.com
  2018-04-09 17:57     ` Fwd: " Mike Travis
  1 sibling, 1 reply; 9+ messages in thread
From: tip-bot for mike.travis@hpe.com @ 2018-03-28 18:25 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: dimitri.sivanich, mike.travis, linux-kernel, mingo, hpa, tglx,
	andrew.banman, russ.anderson, travis

Commit-ID:  bd47a85acd727e27b7283daff557865ad04c59f6
Gitweb:     https://git.kernel.org/tip/bd47a85acd727e27b7283daff557865ad04c59f6
Author:     mike.travis@hpe.com <mike.travis@hpe.com>
AuthorDate: Wed, 28 Mar 2018 12:40:11 -0500
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 28 Mar 2018 20:19:45 +0200

x86/platform/UV: Fix critical UV MMR address error

A critical error was found testing the fixed UV4 HUB in that an MMR address
was found to be incorrect.  This causes the virtual address space for
accessing the MMIOH1 region to be allocated with the incorrect size.

Fixes: 673aa20c55a1 ("x86/platform/UV: Update uv_mmrs.h to prepare for UV4A fixes")
Signed-off-by: Mike Travis <travis@sgi.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Dimitri Sivanich <dimitri.sivanich@hpe.com>
Cc: Russ Anderson <russ.anderson@hpe.com>
Cc: Andrew Banman <andrew.banman@hpe.com>
Link: https://lkml.kernel.org/r/20180328174011.041801248@stormcage.americas.sgi.com

---
 arch/x86/include/asm/uv/uv_mmrs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/include/asm/uv/uv_mmrs.h b/arch/x86/include/asm/uv/uv_mmrs.h
index ecb9ddef128f..62c79e26a59a 100644
--- a/arch/x86/include/asm/uv/uv_mmrs.h
+++ b/arch/x86/include/asm/uv/uv_mmrs.h
@@ -3833,7 +3833,7 @@ union uvh_rh_gam_mmioh_overlay_config0_mmr_u {
 #define UV1H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR uv_undefined("UV1H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR")
 #define UV2H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR uv_undefined("UV2H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR")
 #define UV3H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR 0x1603000UL
-#define UV4H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR 0x483000UL
+#define UV4H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR 0x484000UL
 #define UVH_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR (				\
 	is_uv1_hub() ? UV1H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR :		\
 	is_uv2_hub() ? UV2H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR :		\

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/1] x86/platform/UV: Fix critical UV MMR address error
  2018-03-28 18:17   ` Thomas Gleixner
@ 2018-03-28 18:29     ` Mike Travis
  0 siblings, 0 replies; 9+ messages in thread
From: Mike Travis @ 2018-03-28 18:29 UTC (permalink / raw)
  To: Thomas Gleixner
  Cc: Ingo Molnar, Russ Anderson, Dimitri Sivanich, Andrew Banman, x86,
	linux-kernel



On 3/28/2018 11:17 AM, Thomas Gleixner wrote:
> On Wed, 28 Mar 2018, mike.travis@hpe.com wrote:
> 
>> A critical error was found testing the fixed UV4 HUB in that an MMR
>> address was found to be incorrect.  This causes the virtual address
>> space for accessing the MMIOH1 region to be allocated with the
>> incorrect size.
> 
> Even if this is not intended for stable, despite the diff

Yes, I realized I missed 'stable' a moment or two after hitting send.
> 
>> --- linux-4.4.orig/arch/x86/include/asm/uv/uv_mmrs.h
>> +++ linux-4.4/arch/x86/include/asm/uv/uv_mmrs.h
> 
> suggesting that this is against a kernel, which receives respiration
> treatment, it would be appreciated if you could add a Fixes tag next time.

Sorry I didn't know about that.  Here it is:

Commit-ID:  673aa20c55a138621d1340d343cd6b07c1cb4e92
Gitweb: 
https://.kernel.org/tip/673aa20c55a13862git1d1340d343cd6b07c1cb4e92
Author:     Mike Travis <mike.travis@hpe.com>
AuthorDate: Mon, 8 Jan 2018 13:39:59 -0600
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 16 Jan 2018 03:58:36 +0100

x86/platform/UV: Update uv_mmrs.h to prepare for UV4A fixes

Regenerate uv_mmrs.h file to accommodate fixes to UV4A MMRs.
> 
> That spares me the time to figure out which commit introduced the wreckage
> and therefore the scope of the fix. Added it myself.

Oh, well the above should be the same as what you found.
> 
> Thanks,
> 
> 	tglx

Thank You!
> 
>> @@ -3833,7 +3833,7 @@ union uvh_rh_gam_mmioh_overlay_config0_m
>>   #define UV1H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR uv_undefined("UV1H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR")
>>   #define UV2H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR uv_undefined("UV2H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR")
>>   #define UV3H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR 0x1603000UL
>> -#define UV4H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR 0x483000UL
>> +#define UV4H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR 0x484000UL
>>   #define UVH_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR (				\
>>   	is_uv1_hub() ? UV1H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR :		\
>>   	is_uv2_hub() ? UV2H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR :		\
>>
>> -- 
>>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Fwd: [tip:x86/urgent] x86/platform/UV: Fix critical UV MMR address error
  2018-03-28 18:25   ` [tip:x86/urgent] " tip-bot for mike.travis@hpe.com
@ 2018-04-09 17:57     ` Mike Travis
  2018-04-09 20:03       ` Greg KH
  0 siblings, 1 reply; 9+ messages in thread
From: Mike Travis @ 2018-04-09 17:57 UTC (permalink / raw)
  To: stable

This was sent to stable@vger.kernel.org almost 2 weeks ago and I haven't 
heard anything back yet.  Is there any update on the status?  (sorry for 
the bad formatting, this is the only way I can forward the email.  I can 
only resend the original email before the commit email from Thomas.)

Thanks.

-------- Forwarded Message --------
Subject: [tip:x86/urgent] x86/platform/UV: Fix critical UV MMR address error
Date: Wed, 28 Mar 2018 11:25:04 -0700
From: tip-bot for mike.travis@hpe.com <tipbot@zytor.com>
Reply-To: andrew.banman@hpe.com, hpa@zytor.com, tglx@linutronix.de, 
mingo@kernel.org, russ.anderson@hpe.com, travis@sgi.com, 
linux-kernel@vger.kernel.org, mike.travis@hpe.com, dimitri.sivanich@hpe.com
To: linux-tip-commits@vger.kernel.org
CC: dimitri.sivanich@hpe.com, mike.travis@hpe.com, 
linux-kernel@vger.kernel.org, mingo@kernel.org, hpa@zytor.com, 
tglx@linutronix.de, andrew.banman@hpe.com, russ.anderson@hpe.com, 
travis@sgi.com

Commit-ID:  bd47a85acd727e27b7283daff557865ad04c59f6
Gitweb: 
https://git.kernel.org/tip/bd47a85acd727e27b7283daff557865ad04c59f6
Author:     mike.travis@hpe.com <mike.travis@hpe.com>
AuthorDate: Wed, 28 Mar 2018 12:40:11 -0500
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 28 Mar 2018 20:19:45 +0200

x86/platform/UV: Fix critical UV MMR address error

A critical error was found testing the fixed UV4 HUB in that an MMR address
was found to be incorrect.  This causes the virtual address space for
accessing the MMIOH1 region to be allocated with the incorrect size.

Fixes: 673aa20c55a1 ("x86/platform/UV: Update uv_mmrs.h to prepare for 
UV4A fixes")
Signed-off-by: Mike Travis <travis@sgi.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Dimitri Sivanich <dimitri.sivanich@hpe.com>
Cc: Russ Anderson <russ.anderson@hpe.com>
Cc: Andrew Banman <andrew.banman@hpe.com>
Link: 
https://lkml.kernel.org/r/20180328174011.041801248@stormcage.americas.sgi.com

---
  arch/x86/include/asm/uv/uv_mmrs.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/include/asm/uv/uv_mmrs.h 
b/arch/x86/include/asm/uv/uv_mmrs.h
index ecb9ddef128f..62c79e26a59a 100644
--- a/arch/x86/include/asm/uv/uv_mmrs.h
+++ b/arch/x86/include/asm/uv/uv_mmrs.h
@@ -3833,7 +3833,7 @@ union uvh_rh_gam_mmioh_overlay_config0_mmr_u {
  #define UV1H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR 
uv_undefined("UV1H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR")
  #define UV2H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR 
uv_undefined("UV2H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR")
  #define UV3H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR 0x1603000UL
-#define UV4H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR 0x483000UL
+#define UV4H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR 0x484000UL
  #define UVH_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR (				\
  	is_uv1_hub() ? UV1H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR :		\
  	is_uv2_hub() ? UV2H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR :		\

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: Fwd: [tip:x86/urgent] x86/platform/UV: Fix critical UV MMR address error
  2018-04-09 17:57     ` Fwd: " Mike Travis
@ 2018-04-09 20:03       ` Greg KH
  2018-04-09 22:48         ` Mike Travis
  0 siblings, 1 reply; 9+ messages in thread
From: Greg KH @ 2018-04-09 20:03 UTC (permalink / raw)
  To: Mike Travis; +Cc: stable

On Mon, Apr 09, 2018 at 10:57:56AM -0700, Mike Travis wrote:
> This was sent to stable@vger.kernel.org almost 2 weeks ago and I haven't
> heard anything back yet.  Is there any update on the status?  (sorry for the
> bad formatting, this is the only way I can forward the email.  I can only
> resend the original email before the commit email from Thomas.)

How did you send it?

Ugh, you bounced it?  No wonder I didn't do anything with it at all, it
looked exactly like a "this is being committed to the TIP tree" type
message.

How was I supposed to know what to do with it?

Please be more specific next time, read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

A simple "please commit git id XXXXX to the X.X tree" is all that is
needed.

Wait, in looking closer at this:

> -------- Forwarded Message --------
> Subject: [tip:x86/urgent] x86/platform/UV: Fix critical UV MMR address error
> Date: Wed, 28 Mar 2018 11:25:04 -0700
> From: tip-bot for mike.travis@hpe.com <tipbot@zytor.com>
> Reply-To: andrew.banman@hpe.com, hpa@zytor.com, tglx@linutronix.de,
> mingo@kernel.org, russ.anderson@hpe.com, travis@sgi.com,
> linux-kernel@vger.kernel.org, mike.travis@hpe.com, dimitri.sivanich@hpe.com
> To: linux-tip-commits@vger.kernel.org
> CC: dimitri.sivanich@hpe.com, mike.travis@hpe.com,
> linux-kernel@vger.kernel.org, mingo@kernel.org, hpa@zytor.com,
> tglx@linutronix.de, andrew.banman@hpe.com, russ.anderson@hpe.com,
> travis@sgi.com
> 
> Commit-ID:  bd47a85acd727e27b7283daff557865ad04c59f6

Ok, that commit showed up in 4.16:
	$ git describe --contains bd47a85acd727e27b7283daff557865ad04c59f6
	v4.16~2^2

But the commit this fixes:

> Gitweb: https://git.kernel.org/tip/bd47a85acd727e27b7283daff557865ad04c59f6
> Author:     mike.travis@hpe.com <mike.travis@hpe.com>
> AuthorDate: Wed, 28 Mar 2018 12:40:11 -0500
> Committer:  Thomas Gleixner <tglx@linutronix.de>
> CommitDate: Wed, 28 Mar 2018 20:19:45 +0200
> 
> x86/platform/UV: Fix critical UV MMR address error
> 
> A critical error was found testing the fixed UV4 HUB in that an MMR address
> was found to be incorrect.  This causes the virtual address space for
> accessing the MMIOH1 region to be allocated with the incorrect size.
> 
> Fixes: 673aa20c55a1 ("x86/platform/UV: Update uv_mmrs.h to prepare for UV4A
> fixes")

Is in 4.16-rc1:
	$ git describe --contains 673aa20c55a1
	v4.16-rc1~174^2~9

And is not backported to any other stable tree that I see:
	$ fr 673aa20c55a1
	4.16
	$ alias fr
	alias fr='~/linux/scripts/fix_in_what_release'

So what exactly am I supposed to do with this commit?  What do you want
to see done with it?

totally confused,

greg k-h

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: Fwd: [tip:x86/urgent] x86/platform/UV: Fix critical UV MMR address error
  2018-04-09 20:03       ` Greg KH
@ 2018-04-09 22:48         ` Mike Travis
  2018-04-10  5:26           ` Greg KH
  0 siblings, 1 reply; 9+ messages in thread
From: Mike Travis @ 2018-04-09 22:48 UTC (permalink / raw)
  To: Greg KH; +Cc: stable, Dimitri Sivanich, Anderson, Russ



On 4/9/2018 1:03 PM, Greg KH wrote:
> On Mon, Apr 09, 2018 at 10:57:56AM -0700, Mike Travis wrote:
>> This was sent to stable@vger.kernel.org almost 2 weeks ago and I haven't
>> heard anything back yet.  Is there any update on the status?  (sorry for the
>> bad formatting, this is the only way I can forward the email.  I can only
>> resend the original email before the commit email from Thomas.)
> 
> How did you send it?
> 
> Ugh, you bounced it?  No wonder I didn't do anything with it at all, it
> looked exactly like a "this is being committed to the TIP tree" type
> message.
> 
> How was I supposed to know what to do with it?
> 
> Please be more specific next time, read:
>      https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> for how to do this properly.
> 
> A simple "please commit git id XXXXX to the X.X tree" is all that is
> needed.

I'll definitely do this in the future.

For my info which "X.X" tree is significant?  In this case I'm guessing 
that it would be the version where the breakage occurred?  Or is it some 
other specific major or minor version change?

The end goal is for the distros to pull them in and they usually monitor 
certain stable trees for new commits for their own releases.  But they 
generally don't share with us those details.

> 
> Wait, in looking closer at this:
> 
>> -------- Forwarded Message --------
>> Subject: [tip:x86/urgent] x86/platform/UV: Fix critical UV MMR address error
>> Date: Wed, 28 Mar 2018 11:25:04 -0700
>> From: tip-bot for mike.travis@hpe.com <tipbot@zytor.com>
>> Reply-To: andrew.banman@hpe.com, hpa@zytor.com, tglx@linutronix.de,
>> mingo@kernel.org, russ.anderson@hpe.com, travis@sgi.com,
>> linux-kernel@vger.kernel.org, mike.travis@hpe.com, dimitri.sivanich@hpe.com
>> To: linux-tip-commits@vger.kernel.org
>> CC: dimitri.sivanich@hpe.com, mike.travis@hpe.com,
>> linux-kernel@vger.kernel.org, mingo@kernel.org, hpa@zytor.com,
>> tglx@linutronix.de, andrew.banman@hpe.com, russ.anderson@hpe.com,
>> travis@sgi.com
>>
>> Commit-ID:  bd47a85acd727e27b7283daff557865ad04c59f6
> 
> Ok, that commit showed up in 4.16:
> 	$ git describe --contains bd47a85acd727e27b7283daff557865ad04c59f6
> 	v4.16~2^2
> 
> But the commit this fixes:
> 
>> Gitweb: https://git.kernel.org/tip/bd47a85acd727e27b7283daff557865ad04c59f6
>> Author:     mike.travis@hpe.com <mike.travis@hpe.com>
>> AuthorDate: Wed, 28 Mar 2018 12:40:11 -0500
>> Committer:  Thomas Gleixner <tglx@linutronix.de>
>> CommitDate: Wed, 28 Mar 2018 20:19:45 +0200
>>
>> x86/platform/UV: Fix critical UV MMR address error
>>
>> A critical error was found testing the fixed UV4 HUB in that an MMR address
>> was found to be incorrect.  This causes the virtual address space for
>> accessing the MMIOH1 region to be allocated with the incorrect size.
>>
>> Fixes: 673aa20c55a1 ("x86/platform/UV: Update uv_mmrs.h to prepare for UV4A
>> fixes")
> 
> Is in 4.16-rc1:
> 	$ git describe --contains 673aa20c55a1
> 	v4.16-rc1~174^2~9
> 
> And is not backported to any other stable tree that I see:
> 	$ fr 673aa20c55a1
> 	4.16
> 	$ alias fr
> 	alias fr='~/linux/scripts/fix_in_what_release'
> 
> So what exactly am I supposed to do with this commit?  What do you want
> to see done with it?
> 
> totally confused,
> 
> greg k-h
> 

I am too.  The earlier "breakage" was committed on Jan 8th and has been 
pulled into earlier releases by the distros.  It was the initial patch 
for enabling UV4A HUB systems, so it was not a fix to software, but an 
update in response to fixed hardware (to allow NVDIMMS and Icelake CPUs).

Should this have been pushed to "stable" as well?

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: Fwd: [tip:x86/urgent] x86/platform/UV: Fix critical UV MMR address error
  2018-04-09 22:48         ` Mike Travis
@ 2018-04-10  5:26           ` Greg KH
  0 siblings, 0 replies; 9+ messages in thread
From: Greg KH @ 2018-04-10  5:26 UTC (permalink / raw)
  To: Mike Travis; +Cc: stable, Dimitri Sivanich, Anderson, Russ

On Mon, Apr 09, 2018 at 03:48:58PM -0700, Mike Travis wrote:
> 
> 
> On 4/9/2018 1:03 PM, Greg KH wrote:
> > On Mon, Apr 09, 2018 at 10:57:56AM -0700, Mike Travis wrote:
> > > This was sent to stable@vger.kernel.org almost 2 weeks ago and I haven't
> > > heard anything back yet.  Is there any update on the status?  (sorry for the
> > > bad formatting, this is the only way I can forward the email.  I can only
> > > resend the original email before the commit email from Thomas.)
> > 
> > How did you send it?
> > 
> > Ugh, you bounced it?  No wonder I didn't do anything with it at all, it
> > looked exactly like a "this is being committed to the TIP tree" type
> > message.
> > 
> > How was I supposed to know what to do with it?
> > 
> > Please be more specific next time, read:
> >      https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> > for how to do this properly.
> > 
> > A simple "please commit git id XXXXX to the X.X tree" is all that is
> > needed.
> 
> I'll definitely do this in the future.
> 
> For my info which "X.X" tree is significant?  In this case I'm guessing that
> it would be the version where the breakage occurred?  Or is it some other
> specific major or minor version change?

That's up to you to decide looking at where the breakage happened.  If
you do not know this, then asking for a patch to be backported is a bit
odd :)

> The end goal is for the distros to pull them in and they usually monitor
> certain stable trees for new commits for their own releases.  But they
> generally don't share with us those details.

The "end goal" for the stable list is to get patches into the stable
kernel trees.  If you want to deal with the distros, work with the
distros directly.

Remember, it's guessed that only about 1/3 of the systems out there are
actually running the "enterprise distros", the other 2/3 are either
running kernel.org kernels or Debian.  So if you want the majority of
the systems to have your patches, please just worry about the stable
kernels.

> > Wait, in looking closer at this:
> > 
> > > -------- Forwarded Message --------
> > > Subject: [tip:x86/urgent] x86/platform/UV: Fix critical UV MMR address error
> > > Date: Wed, 28 Mar 2018 11:25:04 -0700
> > > From: tip-bot for mike.travis@hpe.com <tipbot@zytor.com>
> > > Reply-To: andrew.banman@hpe.com, hpa@zytor.com, tglx@linutronix.de,
> > > mingo@kernel.org, russ.anderson@hpe.com, travis@sgi.com,
> > > linux-kernel@vger.kernel.org, mike.travis@hpe.com, dimitri.sivanich@hpe.com
> > > To: linux-tip-commits@vger.kernel.org
> > > CC: dimitri.sivanich@hpe.com, mike.travis@hpe.com,
> > > linux-kernel@vger.kernel.org, mingo@kernel.org, hpa@zytor.com,
> > > tglx@linutronix.de, andrew.banman@hpe.com, russ.anderson@hpe.com,
> > > travis@sgi.com
> > > 
> > > Commit-ID:  bd47a85acd727e27b7283daff557865ad04c59f6
> > 
> > Ok, that commit showed up in 4.16:
> > 	$ git describe --contains bd47a85acd727e27b7283daff557865ad04c59f6
> > 	v4.16~2^2
> > 
> > But the commit this fixes:
> > 
> > > Gitweb: https://git.kernel.org/tip/bd47a85acd727e27b7283daff557865ad04c59f6
> > > Author:     mike.travis@hpe.com <mike.travis@hpe.com>
> > > AuthorDate: Wed, 28 Mar 2018 12:40:11 -0500
> > > Committer:  Thomas Gleixner <tglx@linutronix.de>
> > > CommitDate: Wed, 28 Mar 2018 20:19:45 +0200
> > > 
> > > x86/platform/UV: Fix critical UV MMR address error
> > > 
> > > A critical error was found testing the fixed UV4 HUB in that an MMR address
> > > was found to be incorrect.  This causes the virtual address space for
> > > accessing the MMIOH1 region to be allocated with the incorrect size.
> > > 
> > > Fixes: 673aa20c55a1 ("x86/platform/UV: Update uv_mmrs.h to prepare for UV4A
> > > fixes")
> > 
> > Is in 4.16-rc1:
> > 	$ git describe --contains 673aa20c55a1
> > 	v4.16-rc1~174^2~9
> > 
> > And is not backported to any other stable tree that I see:
> > 	$ fr 673aa20c55a1
> > 	4.16
> > 	$ alias fr
> > 	alias fr='~/linux/scripts/fix_in_what_release'
> > 
> > So what exactly am I supposed to do with this commit?  What do you want
> > to see done with it?
> > 
> > totally confused,
> > 
> > greg k-h
> > 
> 
> I am too.  The earlier "breakage" was committed on Jan 8th and has been
> pulled into earlier releases by the distros.

Again, I don't care about the "distros", that's not what you are asking
me to do here.

> It was the initial patch for enabling UV4A HUB systems, so it was not
> a fix to software, but an update in response to fixed hardware (to
> allow NVDIMMS and Icelake CPUs).
> 
> Should this have been pushed to "stable" as well?

I don't know, does it match the rules for stable kernels that you have
already read now?

Again, does this need to go into any released stable kernel?  If so,
which ones.  If not, there's nothing I can do here.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2018-04-10  5:26 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-28 17:40 [PATCH 0/1] x86/platform/UV: UV Fix patches for Intel processors mike.travis
2018-03-28 17:40 ` [PATCH 1/1] x86/platform/UV: Fix critical UV MMR address error mike.travis
2018-03-28 18:17   ` Thomas Gleixner
2018-03-28 18:29     ` Mike Travis
2018-03-28 18:25   ` [tip:x86/urgent] " tip-bot for mike.travis@hpe.com
2018-04-09 17:57     ` Fwd: " Mike Travis
2018-04-09 20:03       ` Greg KH
2018-04-09 22:48         ` Mike Travis
2018-04-10  5:26           ` Greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.