From: Johan Hovold <johan@kernel.org>
To: Edward Chang <edward.chang.mcs@gmail.com>
Cc: johan@kernel.org, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: usb: serial: option: add HP LT4220 support
Date: Tue, 10 Apr 2018 11:04:57 +0200 [thread overview]
Message-ID: <20180410090457.GB10795@localhost> (raw)
On Tue, Apr 03, 2018 at 10:34:39AM +0800, Edward Chang wrote:
> This patch adds support for HP LT4220.
>
> Signed-off-by: Edward Chang <edward.chang.mcs@gmail.com>
> +/* HP products */
> +#define HP_VENDOR_ID 0x03f0
> +#define HP_PRODUCT_LT4220 0x0857
> +
> struct option_blacklist_info {
> /* bitmask of interface numbers blacklisted for send_setup */
> const unsigned long sendsetup;
> @@ -2066,6 +2070,8 @@ struct option_blacklist_info {
> { USB_DEVICE_AND_INTERFACE_INFO(WETELECOM_VENDOR_ID, WETELECOM_PRODUCT_6802, 0xff, 0xff, 0xff) },
> { USB_DEVICE_AND_INTERFACE_INFO(WETELECOM_VENDOR_ID, WETELECOM_PRODUCT_WMD300, 0xff, 0xff, 0xff) },
> { USB_DEVICE_AND_INTERFACE_INFO(0x03f0, 0x421d, 0xff, 0xff, 0xff) }, /* HP lt2523 (Novatel E371) */
> + { USB_DEVICE_INTERFACE_CLASS(HP_VENDOR_ID, HP_PRODUCT_LT4220, USB_CLASS_VENDOR_SPEC),
> + .driver_info = (kernel_ulong_t)&telit_le920a4_blacklist_1 },
The option blacklisting-implementation has recently been updated, so
this patch would no longer apply. Could you please respin this on top of
Linus's tree or my usb-next branch:
https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/log/?h=usb-next
which have the following commit
c3a65808f04a ("USB: serial: option: reimplement interface masking")
Also, I'm trying to move away from adding redundant id-defines, so
please use the numerical values directly in the table and add a short
comment after the entry with the product name instead.
Thanks,
Johan
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan@kernel.org>
To: Edward Chang <edward.chang.mcs@gmail.com>
Cc: johan@kernel.org, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: serial: option: add HP LT4220 support
Date: Tue, 10 Apr 2018 11:04:57 +0200 [thread overview]
Message-ID: <20180410090457.GB10795@localhost> (raw)
In-Reply-To: <1522722879-2171-1-git-send-email-edward.chang.mcs@gmail.com>
On Tue, Apr 03, 2018 at 10:34:39AM +0800, Edward Chang wrote:
> This patch adds support for HP LT4220.
>
> Signed-off-by: Edward Chang <edward.chang.mcs@gmail.com>
> +/* HP products */
> +#define HP_VENDOR_ID 0x03f0
> +#define HP_PRODUCT_LT4220 0x0857
> +
> struct option_blacklist_info {
> /* bitmask of interface numbers blacklisted for send_setup */
> const unsigned long sendsetup;
> @@ -2066,6 +2070,8 @@ struct option_blacklist_info {
> { USB_DEVICE_AND_INTERFACE_INFO(WETELECOM_VENDOR_ID, WETELECOM_PRODUCT_6802, 0xff, 0xff, 0xff) },
> { USB_DEVICE_AND_INTERFACE_INFO(WETELECOM_VENDOR_ID, WETELECOM_PRODUCT_WMD300, 0xff, 0xff, 0xff) },
> { USB_DEVICE_AND_INTERFACE_INFO(0x03f0, 0x421d, 0xff, 0xff, 0xff) }, /* HP lt2523 (Novatel E371) */
> + { USB_DEVICE_INTERFACE_CLASS(HP_VENDOR_ID, HP_PRODUCT_LT4220, USB_CLASS_VENDOR_SPEC),
> + .driver_info = (kernel_ulong_t)&telit_le920a4_blacklist_1 },
The option blacklisting-implementation has recently been updated, so
this patch would no longer apply. Could you please respin this on top of
Linus's tree or my usb-next branch:
https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/log/?h=usb-next
which have the following commit
c3a65808f04a ("USB: serial: option: reimplement interface masking")
Also, I'm trying to move away from adding redundant id-defines, so
please use the numerical values directly in the table and add a short
comment after the entry with the product name instead.
Thanks,
Johan
next reply other threads:[~2018-04-10 9:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 9:04 Johan Hovold [this message]
2018-04-10 9:04 ` [PATCH] usb: serial: option: add HP LT4220 support Johan Hovold
-- strict thread matches above, loose matches on Subject: below --
2018-04-11 6:56 Johan Hovold
2018-04-11 6:36 Edward Chang
2018-04-03 2:34 Edward Chang
2018-04-03 2:34 ` [PATCH] " Edward Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180410090457.GB10795@localhost \
--to=johan@kernel.org \
--cc=edward.chang.mcs@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.