[Buildroot] [git commit] package/mesa3d: add dependency on elfutils for R600 with LLVM

[Buildroot] [git commit] package/mesa3d: add dependency on elfutils for R600 with LLVM

[Thomas Petazzoni]

commit: https://git.buildroot.net/buildroot/commit/?id=92fda8761aa8024be53a8edb8c102d1ba6401bce
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

Gallium R600 needs libelf when mesa is built with llvm support.
Because of this, toolchain must use either uClibc or glibc, as
musl is not currently compatible with elfutils.

This patch solves:
configure: error: r600 requires libelf when using llvm

Fixes:

  http://autobuild.buildroot.org/results/8845ff0f28d3273ebe884126b85cd7c4a905d81b/

Signed-off-by: Valentin Korenblit <valentin.korenblit@smile.fr>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 package/mesa3d/Config.in | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/package/mesa3d/Config.in b/package/mesa3d/Config.in
index 1476b39acc..bd3d050e29 100644
--- a/package/mesa3d/Config.in
+++ b/package/mesa3d/Config.in
@@ -97,13 +97,23 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_NOUVEAU
 config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_R600
 	bool "Gallium Radeon R600 driver"
 	depends on BR2_i386 || BR2_x86_64
+	depends on !BR2_PACKAGE_MESA3D_LLVM || \
+		(BR2_PACKAGE_MESA3D_LLVM && (BR2_TOOLCHAIN_USES_UCLIBC || \
+			BR2_TOOLCHAIN_USES_GLIBC)) # elfutils
 	select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER
 	select BR2_PACKAGE_LIBDRM_RADEON
 	select BR2_PACKAGE_LLVM_AMDGPU if BR2_PACKAGE_MESA3D_LLVM
+	select BR2_PACKAGE_ELFUTILS if BR2_PACKAGE_MESA3D_LLVM
 	select BR2_PACKAGE_MESA3D_NEEDS_XA
 	help
 	  Driver for ATI/AMD Radeon R600/R700/HD5000/HD6000 GPUs.
 
+# R600 needs libelf when Mesa3D is built with LLVM support
+# musl is not currently compatible with elfutils
+comment "R600 driver needs a uClibc or glibc toolchain when llvm is enabled"
+	depends on BR2_PACKAGE_MESA3D_LLVM
+	depends on !(BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_GLIBC)
+
 config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SVGA
 	bool "Gallium vmware svga driver"
 	depends on BR2_i386 || BR2_x86_64

[Buildroot] [git commit] package/mesa3d: add dependency on elfutils for R600 with LLVM

[Michał Kalbarczyk]

Hi,
Just figured out that you're creating a PR with gallium R600 driver. I'm
trying do the same thing with RADEONSI driver.
Can you add radeonsi driver to your PR, or should I create separate PR for
that ?

thanks for your help
Micha?.


On Thu, Apr 12, 2018 at 11:31 PM, Thomas Petazzoni <
thomas.petazzoni@bootlin.com> wrote:

> commit: https://git.buildroot.net/buildroot/commit/?id=
> 92fda8761aa8024be53a8edb8c102d1ba6401bce
> branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
>
> Gallium R600 needs libelf when mesa is built with llvm support.
> Because of this, toolchain must use either uClibc or glibc, as
> musl is not currently compatible with elfutils.
>
> This patch solves:
> configure: error: r600 requires libelf when using llvm
>
> Fixes:
>
>   http://autobuild.buildroot.org/results/8845ff0f28d3273ebe884126b85cd7
> c4a905d81b/
>
> Signed-off-by: Valentin Korenblit <valentin.korenblit@smile.fr>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
>  package/mesa3d/Config.in | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/package/mesa3d/Config.in b/package/mesa3d/Config.in
> index 1476b39acc..bd3d050e29 100644
> --- a/package/mesa3d/Config.in
> +++ b/package/mesa3d/Config.in
> @@ -97,13 +97,23 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_NOUVEAU
>  config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_R600
>         bool "Gallium Radeon R600 driver"
>         depends on BR2_i386 || BR2_x86_64
> +       depends on !BR2_PACKAGE_MESA3D_LLVM || \
> +               (BR2_PACKAGE_MESA3D_LLVM && (BR2_TOOLCHAIN_USES_UCLIBC || \
> +                       BR2_TOOLCHAIN_USES_GLIBC)) # elfutils
>         select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER
>         select BR2_PACKAGE_LIBDRM_RADEON
>         select BR2_PACKAGE_LLVM_AMDGPU if BR2_PACKAGE_MESA3D_LLVM
> +       select BR2_PACKAGE_ELFUTILS if BR2_PACKAGE_MESA3D_LLVM
>         select BR2_PACKAGE_MESA3D_NEEDS_XA
>         help
>           Driver for ATI/AMD Radeon R600/R700/HD5000/HD6000 GPUs.
>
> +# R600 needs libelf when Mesa3D is built with LLVM support
> +# musl is not currently compatible with elfutils
> +comment "R600 driver needs a uClibc or glibc toolchain when llvm is
> enabled"
> +       depends on BR2_PACKAGE_MESA3D_LLVM
> +       depends on !(BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_GLIBC)
> +
>  config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SVGA
>         bool "Gallium vmware svga driver"
>         depends on BR2_i386 || BR2_x86_64
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180413/d89ab868/attachment.html>

[Buildroot] [git commit] package/mesa3d: add dependency on elfutils for R600 with LLVM

[Thomas Petazzoni]

Hello,

On Fri, 13 Apr 2018 10:16:19 +0200, Micha? Kalbarczyk wrote:

> Just figured out that you're creating a PR with gallium R600 driver. I'm
> trying do the same thing with RADEONSI driver.
> Can you add radeonsi driver to your PR, or should I create separate PR for
> that ?

We don't do "PR" in Buildroot, we send patches over e-mail. I'm not
sure Valentin has the hardware to test RadeonSI, so if you're
interested by RadeonSI, please send your patches :-)

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [git commit] package/mesa3d: add dependency on elfutils for R600 with LLVM

[Romain Naour]

Hi Thomas, Michal,

Le 13/04/2018 ? 10:17, Thomas Petazzoni a ?crit?:
> Hello,
> 
> On Fri, 13 Apr 2018 10:16:19 +0200, Micha? Kalbarczyk wrote:
> 
>> Just figured out that you're creating a PR with gallium R600 driver. I'm
>> trying do the same thing with RADEONSI driver.
>> Can you add radeonsi driver to your PR, or should I create separate PR for
>> that ?
> 
> We don't do "PR" in Buildroot, we send patches over e-mail. I'm not
> sure Valentin has the hardware to test RadeonSI, so if you're
> interested by RadeonSI, please send your patches :-)

I confirm that Valentin doesn't have the hardware to test RadeonSI, me neither.
Michal, you're welcome to send patches to add RadeonSI support. I'll review them.

Best regards,
Romain

> 
> Thanks!
> 
> Thomas
>