All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Vogt <mvo@ubuntu.com>
To: git@vger.kernel.org, sbeller@google.com, avarab@gmail.com
Subject: [PATCH v2] show: add --follow-symlinks option for <rev>:<path>
Date: Mon, 16 Apr 2018 11:36:24 +0200	[thread overview]
Message-ID: <20180416093625.15752-1-mvo@ubuntu.com> (raw)
In-Reply-To: <87fu3yg6od.fsf@evledraar.gmail.com>

Updated version of the `git show --follow-symlink` patch. This version
includes the feedback from Ævar Arnfjörð Bjarmason and Stefan Beller:

- commit message updated
- test fixes merged from Ævar (thanks!)
- Documentation/git-show.txt clarified

It does not include a test for --follow-symlinks in the dirlink case
when a file is behind a dirlink symlink. This this currently fails with
a non-descriptive error message. I hope to find time to improve this
error message at some point and then a test for this will be added.

It also does not include a test for a repo with symlinks when running
on a system without SYMLINKS. I don't have access to such a system,
sorry.




  reply	other threads:[~2018-04-16  9:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-09  9:00 [RFC PATCH] Add "git show --follow-symlinks HEAD:symlink" Michael Vogt
2018-04-09  9:28 ` Ævar Arnfjörð Bjarmason
2018-04-13  9:43   ` Michael Vogt
2018-04-13 17:28     ` Stefan Beller
2018-04-13 17:48       ` Michael Vogt
2018-04-13 19:33         ` Ævar Arnfjörð Bjarmason
2018-04-13 19:48           ` [PATCH] support: git show --follow-symlinks HEAD:symlink Michael Vogt
2018-04-13 21:03             ` Ævar Arnfjörð Bjarmason
2018-04-16  9:36               ` Michael Vogt [this message]
2018-04-16  9:36                 ` [PATCH] show: add --follow-symlinks option for <rev>:<path> Michael Vogt
2018-04-16 23:05                   ` Junio C Hamano
2018-04-13 19:55           ` [RFC PATCH] Add "git show --follow-symlinks HEAD:symlink" Michael Vogt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180416093625.15752-1-mvo@ubuntu.com \
    --to=mvo@ubuntu.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=sbeller@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.