From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Michael Vogt <mvo@ubuntu.com>
Cc: Stefan Beller <sbeller@google.com>, git@vger.kernel.org
Subject: Re: [RFC PATCH] Add "git show --follow-symlinks HEAD:symlink"
Date: Fri, 13 Apr 2018 21:33:00 +0200 [thread overview]
Message-ID: <87h8oegavn.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <20180413174819.GA19030@bod>
On Fri, Apr 13 2018, Michael Vogt wrote:
> The update patch is attached as an inline attachement.
Your patch still just shows up as a straight-up attachment in many
E-Mail clients. Note the difference between what your patch
(https://public-inbox.org/git/20180413174819.GA19030@bod/raw) and a
patch that's not an attachment
(https://public-inbox.org/git/0f0942043678fe76f8d654306482ee26fac643f0.1523617836.git.johannes.schindelin@gmx.de/raw)
look like.
Try to "wget" both of those and apply them with "git am" on top of
master, and note how what you're doing results in a broken patch.
This is why Documentation/SubmittingPatches suggests using format-patch
& send-email. You don't *have* to use those tools, and can use something
that's compatible with what's expected on-list, but what you're doing
isn't that.
next prev parent reply other threads:[~2018-04-13 19:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 9:00 [RFC PATCH] Add "git show --follow-symlinks HEAD:symlink" Michael Vogt
2018-04-09 9:28 ` Ævar Arnfjörð Bjarmason
2018-04-13 9:43 ` Michael Vogt
2018-04-13 17:28 ` Stefan Beller
2018-04-13 17:48 ` Michael Vogt
2018-04-13 19:33 ` Ævar Arnfjörð Bjarmason [this message]
2018-04-13 19:48 ` [PATCH] support: git show --follow-symlinks HEAD:symlink Michael Vogt
2018-04-13 21:03 ` Ævar Arnfjörð Bjarmason
2018-04-16 9:36 ` [PATCH v2] show: add --follow-symlinks option for <rev>:<path> Michael Vogt
2018-04-16 9:36 ` [PATCH] " Michael Vogt
2018-04-16 23:05 ` Junio C Hamano
2018-04-13 19:55 ` [RFC PATCH] Add "git show --follow-symlinks HEAD:symlink" Michael Vogt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8oegavn.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=mvo@ubuntu.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.