All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Fabrice Gasnier <fabrice.gasnier@st.com>
Cc: thierry.reding@gmail.com, alexandre.torgue@st.com,
	benjamin.gaignard@linaro.org, robh+dt@kernel.org,
	mark.rutland@arm.com, linux@armlinux.org.uk,
	mcoquelin.stm32@gmail.com, benjamin.gaignard@st.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org
Subject: Re: [PATCH v3 2/6] mfd: stm32-timers: add support for dmas
Date: Mon, 16 Apr 2018 15:47:53 +0100	[thread overview]
Message-ID: <20180416144753.parny6fhvpd3tryf@dell> (raw)
In-Reply-To: <7531300c-7b7e-75c9-ea5b-8ca01b684c45@st.com>

On Mon, 16 Apr 2018, Fabrice Gasnier wrote:

> On 04/16/2018 02:22 PM, Lee Jones wrote:
> > On Fri, 30 Mar 2018, Fabrice Gasnier wrote:
> > 
> >> STM32 Timers can support up to 7 DMA requests:
> >> - 4 channels, update, compare and trigger.
> >> Optionally request part, or all DMAs from stm32-timers MFD core.
> >>
> >> Also add routine to implement burst reads using DMA from timer registers.
> >> This is exported. So, it can be used by child drivers, PWM capture
> >> for instance (but not limited to).
> >>
> >> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
> >> Reviewed-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
> >> ---
> >> Changes in v3:
> >> - Basically Lee's comments:
> >> - rather create a struct stm32_timers_dma, and place a reference to it
> >>   in existing ddata (instead of adding priv struct).
> >> - rather use a struct device in exported routine prototype, and use
> >>   standard helpers instead of ddata. Get rid of to_stm32_timers_priv().
> >> - simplify error handling in probe (remove a goto)
> >> - comment on devm_of_platform_*populate() usage.
> >>
> >> Changes in v2:
> >> - Abstract DMA handling from child driver: move it to MFD core
> >> - Add comments on optional dma support
> >> ---
> >>  drivers/mfd/stm32-timers.c       | 219 ++++++++++++++++++++++++++++++++++++++-
> >>  include/linux/mfd/stm32-timers.h |  32 ++++++
> >>  2 files changed, 249 insertions(+), 2 deletions(-)

[...]

> >> diff --git a/include/linux/mfd/stm32-timers.h b/include/linux/mfd/stm32-timers.h
> >> index 2aadab6..585a4de 100644
> >> --- a/include/linux/mfd/stm32-timers.h
> >> +++ b/include/linux/mfd/stm32-timers.h
> >> @@ -8,6 +8,8 @@
> >>  #define _LINUX_STM32_GPTIMER_H_
> >>  
> >>  #include <linux/clk.h>
> >> +#include <linux/dmaengine.h>
> >> +#include <linux/dma-mapping.h>
> >>  #include <linux/regmap.h>
> > 
> > [...]
> > 
> >> +enum stm32_timers_dmas {
> >> +	STM32_TIMERS_DMA_CH1,
> >> +	STM32_TIMERS_DMA_CH2,
> >> +	STM32_TIMERS_DMA_CH3,
> >> +	STM32_TIMERS_DMA_CH4,
> >> +	STM32_TIMERS_DMA_UP,
> >> +	STM32_TIMERS_DMA_TRIG,
> >> +	STM32_TIMERS_DMA_COM,
> >> +	STM32_TIMERS_MAX_DMAS,
> >> +};
> >> +
> >> +struct stm32_timers_dma;
> > 
> > Why don't you move the declaration into here?
> 
> To follow previous discussions we had in V1 and V2, this is to avoid
> sharing all the information with child drivers, e.g. passing physical
> address of parent MFD into child devices.
> 
> I should probably add a comment there ? Something like:
> 
> /* STM32 timers MFD parent internal struct to handle DMA transfers */
> struct stm32_timers_dma;
> 
> Do you agree with this ?
> 
> Thanks for reviewing,
> BR,
> Fabrice
> 
> > 
> > Then you don't need to forward declare.

Yes, I remember our previous conversation.

Perhaps you could always put a comment like:

> >>  struct stm32_timers {
> >>  	struct clk *clk;
> >>  	struct regmap *regmap;
> >>  	u32 max_arr;
> >> +	struct stm32_timers_dma *dma; /* Only to be used by the parent */
> >>  };

If this is not acceptable, then the current solution will do.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/6] mfd: stm32-timers: add support for dmas
Date: Mon, 16 Apr 2018 15:47:53 +0100	[thread overview]
Message-ID: <20180416144753.parny6fhvpd3tryf@dell> (raw)
In-Reply-To: <7531300c-7b7e-75c9-ea5b-8ca01b684c45@st.com>

On Mon, 16 Apr 2018, Fabrice Gasnier wrote:

> On 04/16/2018 02:22 PM, Lee Jones wrote:
> > On Fri, 30 Mar 2018, Fabrice Gasnier wrote:
> > 
> >> STM32 Timers can support up to 7 DMA requests:
> >> - 4 channels, update, compare and trigger.
> >> Optionally request part, or all DMAs from stm32-timers MFD core.
> >>
> >> Also add routine to implement burst reads using DMA from timer registers.
> >> This is exported. So, it can be used by child drivers, PWM capture
> >> for instance (but not limited to).
> >>
> >> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
> >> Reviewed-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
> >> ---
> >> Changes in v3:
> >> - Basically Lee's comments:
> >> - rather create a struct stm32_timers_dma, and place a reference to it
> >>   in existing ddata (instead of adding priv struct).
> >> - rather use a struct device in exported routine prototype, and use
> >>   standard helpers instead of ddata. Get rid of to_stm32_timers_priv().
> >> - simplify error handling in probe (remove a goto)
> >> - comment on devm_of_platform_*populate() usage.
> >>
> >> Changes in v2:
> >> - Abstract DMA handling from child driver: move it to MFD core
> >> - Add comments on optional dma support
> >> ---
> >>  drivers/mfd/stm32-timers.c       | 219 ++++++++++++++++++++++++++++++++++++++-
> >>  include/linux/mfd/stm32-timers.h |  32 ++++++
> >>  2 files changed, 249 insertions(+), 2 deletions(-)

[...]

> >> diff --git a/include/linux/mfd/stm32-timers.h b/include/linux/mfd/stm32-timers.h
> >> index 2aadab6..585a4de 100644
> >> --- a/include/linux/mfd/stm32-timers.h
> >> +++ b/include/linux/mfd/stm32-timers.h
> >> @@ -8,6 +8,8 @@
> >>  #define _LINUX_STM32_GPTIMER_H_
> >>  
> >>  #include <linux/clk.h>
> >> +#include <linux/dmaengine.h>
> >> +#include <linux/dma-mapping.h>
> >>  #include <linux/regmap.h>
> > 
> > [...]
> > 
> >> +enum stm32_timers_dmas {
> >> +	STM32_TIMERS_DMA_CH1,
> >> +	STM32_TIMERS_DMA_CH2,
> >> +	STM32_TIMERS_DMA_CH3,
> >> +	STM32_TIMERS_DMA_CH4,
> >> +	STM32_TIMERS_DMA_UP,
> >> +	STM32_TIMERS_DMA_TRIG,
> >> +	STM32_TIMERS_DMA_COM,
> >> +	STM32_TIMERS_MAX_DMAS,
> >> +};
> >> +
> >> +struct stm32_timers_dma;
> > 
> > Why don't you move the declaration into here?
> 
> To follow previous discussions we had in V1 and V2, this is to avoid
> sharing all the information with child drivers, e.g. passing physical
> address of parent MFD into child devices.
> 
> I should probably add a comment there ? Something like:
> 
> /* STM32 timers MFD parent internal struct to handle DMA transfers */
> struct stm32_timers_dma;
> 
> Do you agree with this ?
> 
> Thanks for reviewing,
> BR,
> Fabrice
> 
> > 
> > Then you don't need to forward declare.

Yes, I remember our previous conversation.

Perhaps you could always put a comment like:

> >>  struct stm32_timers {
> >>  	struct clk *clk;
> >>  	struct regmap *regmap;
> >>  	u32 max_arr;
> >> +	struct stm32_timers_dma *dma; /* Only to be used by the parent */
> >>  };

If this is not acceptable, then the current solution will do.

-- 
Lee Jones [???]
Linaro Services Technical Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2018-04-16 14:47 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-30 10:01 [PATCH v3 0/6] Add support for PWM input capture on STM32 Fabrice Gasnier
2018-03-30 10:01 ` Fabrice Gasnier
2018-03-30 10:01 ` Fabrice Gasnier
2018-03-30 10:01 ` [PATCH v3 1/6] dt-bindings: mfd: stm32-timers: add support for dmas Fabrice Gasnier
2018-03-30 10:01   ` Fabrice Gasnier
2018-03-30 10:01   ` Fabrice Gasnier
2018-04-16 12:23   ` Lee Jones
2018-04-16 12:23     ` Lee Jones
2018-04-16 12:23     ` Lee Jones
2018-04-16 12:23       ` Lee Jones
2018-03-30 10:01 ` [PATCH v3 2/6] " Fabrice Gasnier
2018-03-30 10:01   ` Fabrice Gasnier
2018-03-30 10:01   ` Fabrice Gasnier
2018-04-16 12:22   ` Lee Jones
2018-04-16 12:22     ` Lee Jones
2018-04-16 12:46     ` Fabrice Gasnier
2018-04-16 12:46       ` Fabrice Gasnier
2018-04-16 12:46       ` Fabrice Gasnier
2018-04-16 14:47       ` Lee Jones [this message]
2018-04-16 14:47         ` Lee Jones
2018-04-16 15:12         ` Fabrice Gasnier
2018-04-16 15:12           ` Fabrice Gasnier
2018-04-16 15:12           ` Fabrice Gasnier
2018-03-30 10:01 ` [PATCH v3 3/6] pwm: stm32: add capture support Fabrice Gasnier
2018-03-30 10:01   ` Fabrice Gasnier
2018-03-30 10:01   ` Fabrice Gasnier
2018-04-16 12:24   ` Lee Jones
2018-04-16 12:24     ` Lee Jones
2018-03-30 10:01 ` [PATCH v3 4/6] pwm: stm32: improve capture by tuning counter prescaler Fabrice Gasnier
2018-03-30 10:01   ` Fabrice Gasnier
2018-03-30 10:01   ` Fabrice Gasnier
2018-03-30 10:01 ` [PATCH v3 5/6] pwm: stm32: use input prescaler to improve period capture Fabrice Gasnier
2018-03-30 10:01   ` Fabrice Gasnier
2018-03-30 10:01   ` Fabrice Gasnier
2018-04-16 12:25   ` Lee Jones
2018-04-16 12:25     ` Lee Jones
2018-03-30 10:01 ` [PATCH v3 6/6] ARM: dts: stm32: Enable pwm3 input capture on stm32f429i-eval Fabrice Gasnier
2018-03-30 10:01   ` Fabrice Gasnier
2018-03-30 10:01   ` Fabrice Gasnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180416144753.parny6fhvpd3tryf@dell \
    --to=lee.jones@linaro.org \
    --cc=alexandre.torgue@st.com \
    --cc=benjamin.gaignard@linaro.org \
    --cc=benjamin.gaignard@st.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fabrice.gasnier@st.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.