From: Thymo van Beers <thymovanbeers@gmail.com>
To: Jonathan Corbet <corbet@lwn.net>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] docs: kernel-parameters.txt: Fix whitespace
Date: Mon, 16 Apr 2018 23:48:18 +0200 [thread overview]
Message-ID: <20180416214602.GA11295@thinkpad> (raw)
In-Reply-To: <20180416140846.0effe6ad@lwn.net>
On Mon, Apr 16, 2018 at 02:08:46PM -0600, Jonathan Corbet wrote:
> On Mon, 16 Apr 2018 17:45:01 +0200
> Thymo van Beers <thymovanbeers@gmail.com> wrote:
>
> > Some lines used spaces instead of tabs at line start.
> > This can cause mangled lines in editors due to inconsistency.
> >
> > Replace spaces for tabs where appropriate.
>
> Seems like a fine idea. The patch doesn't apply, though; can you please
> make a version against current docs-next? (Or against 4.17-rc1 will work
> too).
>
> Also...
>
> > domain
> > - Isolate from the general SMP balancing and scheduling
> > - algorithms. Note that performing domain isolation this way
> > - is irreversible: it's not possible to bring back a CPU to
> > - the domains once isolated through isolcpus. It's strongly
> > - advised to use cpusets instead to disable scheduler load
> > - balancing through the "cpuset.sched_load_balance" file.
> > - It offers a much more flexible interface where CPUs can
> > - move in and out of an isolated set anytime.
> > -
> > - You can move a process onto or off an "isolated" CPU via
> > - the CPU affinity syscalls or cpuset.
> > - <cpu number> begins at 0 and the maximum value is
> > - "number of CPUs in system - 1".
> > + Isolate from the general SMP balancing and scheduling
> > + algorithms. Note that performing domain isolation this way
> > + is irreversible: it's not possible to bring back a CPU to
> > + the domains once isolated through isolcpus. It's strongly
> > + advised to use cpusets instead to disable scheduler load
> > + balancing through the "cpuset.sched_load_balance" file.
> > + It offers a much more flexible interface where CPUs can
> > + move in and out of an isolated set anytime.
> > +
> > + You can move a process onto or off an "isolated" CPU via
> > + the CPU affinity syscalls or cpuset.
> > + <cpu number> begins at 0 and the maximum value is
> > + "number of CPUs in system - 1".
>
> This would appear to have changed the indentation of some of the text?
>
> Thanks,
>
> jon
Thanks for the comment.
I will rebase against docs-next. Hadn't realised my tree wasn't
up-to-date.
Upon reviewing that section I see that was intentional indentation and
not some tab/space mix up.
Both will be fixed in v2.
- Thymo
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Thymo van Beers <thymovanbeers@gmail.com>
To: Jonathan Corbet <corbet@lwn.net>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] docs: kernel-parameters.txt: Fix whitespace
Date: Mon, 16 Apr 2018 23:48:18 +0200 [thread overview]
Message-ID: <20180416214602.GA11295@thinkpad> (raw)
In-Reply-To: <20180416140846.0effe6ad@lwn.net>
On Mon, Apr 16, 2018 at 02:08:46PM -0600, Jonathan Corbet wrote:
> On Mon, 16 Apr 2018 17:45:01 +0200
> Thymo van Beers <thymovanbeers@gmail.com> wrote:
>
> > Some lines used spaces instead of tabs at line start.
> > This can cause mangled lines in editors due to inconsistency.
> >
> > Replace spaces for tabs where appropriate.
>
> Seems like a fine idea. The patch doesn't apply, though; can you please
> make a version against current docs-next? (Or against 4.17-rc1 will work
> too).
>
> Also...
>
> > domain
> > - Isolate from the general SMP balancing and scheduling
> > - algorithms. Note that performing domain isolation this way
> > - is irreversible: it's not possible to bring back a CPU to
> > - the domains once isolated through isolcpus. It's strongly
> > - advised to use cpusets instead to disable scheduler load
> > - balancing through the "cpuset.sched_load_balance" file.
> > - It offers a much more flexible interface where CPUs can
> > - move in and out of an isolated set anytime.
> > -
> > - You can move a process onto or off an "isolated" CPU via
> > - the CPU affinity syscalls or cpuset.
> > - <cpu number> begins at 0 and the maximum value is
> > - "number of CPUs in system - 1".
> > + Isolate from the general SMP balancing and scheduling
> > + algorithms. Note that performing domain isolation this way
> > + is irreversible: it's not possible to bring back a CPU to
> > + the domains once isolated through isolcpus. It's strongly
> > + advised to use cpusets instead to disable scheduler load
> > + balancing through the "cpuset.sched_load_balance" file.
> > + It offers a much more flexible interface where CPUs can
> > + move in and out of an isolated set anytime.
> > +
> > + You can move a process onto or off an "isolated" CPU via
> > + the CPU affinity syscalls or cpuset.
> > + <cpu number> begins at 0 and the maximum value is
> > + "number of CPUs in system - 1".
>
> This would appear to have changed the indentation of some of the text?
>
> Thanks,
>
> jon
Thanks for the comment.
I will rebase against docs-next. Hadn't realised my tree wasn't
up-to-date.
Upon reviewing that section I see that was intentional indentation and
not some tab/space mix up.
Both will be fixed in v2.
- Thymo
next prev parent reply other threads:[~2018-04-16 21:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 15:45 [PATCH] docs: kernel-parameters.txt: Fix whitespace Thymo van Beers
2018-04-16 15:45 ` Thymo van Beers
2018-04-16 20:08 ` Jonathan Corbet
2018-04-16 20:08 ` Jonathan Corbet
2018-04-16 21:48 ` Thymo van Beers [this message]
2018-04-16 21:48 ` Thymo van Beers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180416214602.GA11295@thinkpad \
--to=thymovanbeers@gmail.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.