From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bart.vanassche@wdc.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Damien Le Moal <damien.lemoal@wdc.com>,
Hannes Reinecke <hare@suse.com>,
Shaun Tancheff <shaun@tancheff.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] block: Avoid executing a report or reset zones while a queue is frozen
Date: Tue, 17 Apr 2018 17:18:57 +0200 [thread overview]
Message-ID: <20180417151857.GA25646@lst.de> (raw)
In-Reply-To: <20180417010034.28676-1-bart.vanassche@wdc.com>
On Mon, Apr 16, 2018 at 06:00:34PM -0700, Bart Van Assche wrote:
> This patch on itself does not change the behavior of either ioctl.
> However, this patch is necessary to avoid that these ioctls fail
> with -EIO if sd_revalidate_disk() is called while these ioctls are
> in progress because the current zoned block command code temporarily
> clears data that is needed by these ioctls. See also commit
> 3ed05a987e0f ("blk-zoned: implement ioctls").
Hmm. I think we need to avoid clearing that data and update it using
RCU instead. Calling blk_queue_enter before submitting bios is
something that would make zone reporting very different from any
other block layer user.
next prev parent reply other threads:[~2018-04-17 15:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 1:00 [PATCH] block: Avoid executing a report or reset zones while a queue is frozen Bart Van Assche
2018-04-17 15:18 ` Christoph Hellwig [this message]
2018-04-17 15:32 ` Bart Van Assche
2018-04-17 15:32 ` Bart Van Assche
2018-04-17 17:35 ` Bart Van Assche
2018-04-17 17:35 ` Bart Van Assche
2018-04-19 9:14 ` hch
2018-04-17 22:58 ` Damien Le Moal
2018-04-17 22:58 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180417151857.GA25646@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@wdc.com \
--cc=damien.lemoal@wdc.com \
--cc=hare@suse.com \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=shaun@tancheff.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.