From: "hch@lst.de" <hch@lst.de>
To: Bart Van Assche <Bart.VanAssche@wdc.com>
Cc: "hch@lst.de" <hch@lst.de>,
"shaun@tancheff.com" <shaun@tancheff.com>,
"hare@suse.com" <hare@suse.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Damien Le Moal <Damien.LeMoal@wdc.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] block: Avoid executing a report or reset zones while a queue is frozen
Date: Thu, 19 Apr 2018 11:14:17 +0200 [thread overview]
Message-ID: <20180419091417.GA22988@lst.de> (raw)
In-Reply-To: <f966e56f3c2c9add48d0a93fb56321f7eb7ee33e.camel@wdc.com>
On Tue, Apr 17, 2018 at 05:35:07PM +0000, Bart Van Assche wrote:
> > Hmm. I think we need to avoid clearing that data and update it using
> > RCU instead. Calling blk_queue_enter before submitting bios is
> > something that would make zone reporting very different from any
> > other block layer user.
>
> Hello Christoph,
>
> Please have a look at generic_make_request(). I think that function shows
> that blk_queue_enter() is called anyway before .make_request_fn() is called.
Yes, that is the point. We already call blk_queue_enter in
generic_make_request, which the zone report and reset ops pass through.
next prev parent reply other threads:[~2018-04-19 9:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 1:00 [PATCH] block: Avoid executing a report or reset zones while a queue is frozen Bart Van Assche
2018-04-17 15:18 ` Christoph Hellwig
2018-04-17 15:32 ` Bart Van Assche
2018-04-17 15:32 ` Bart Van Assche
2018-04-17 17:35 ` Bart Van Assche
2018-04-17 17:35 ` Bart Van Assche
2018-04-19 9:14 ` hch [this message]
2018-04-17 22:58 ` Damien Le Moal
2018-04-17 22:58 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180419091417.GA22988@lst.de \
--to=hch@lst.de \
--cc=Bart.VanAssche@wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.com \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=shaun@tancheff.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.