From: Jesper Dangaard Brouer <brouer@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: alexei.starovoitov@gmail.com, netdev@vger.kernel.org,
bjorn.topel@intel.com, magnus.karlsson@intel.com,
eugenia@mellanox.com, jasowang@redhat.com,
john.fastabend@gmail.com, eranbe@mellanox.com,
saeedm@mellanox.com, galp@mellanox.com, borkmann@iogearbox.net,
tariqt@mellanox.com, brouer@redhat.com
Subject: Re: [net-next V10 PATCH 00/16] XDP redirect memory return API
Date: Tue, 17 Apr 2018 16:39:30 +0200 [thread overview]
Message-ID: <20180417163930.5aa24de9@redhat.com> (raw)
In-Reply-To: <20180417.100750.62384164907693513.davem@davemloft.net>
On Tue, 17 Apr 2018 10:07:50 -0400 (EDT)
David Miller <davem@davemloft.net> wrote:
> From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
> Date: Tue, 17 Apr 2018 06:53:33 -0700
>
> > looks like you forgot to include extra patch to fixup xdp_adjust_head()
> > helper. Otherwise reused xdp_frame in the top of that packet is leaking
> > kernel pointers into bpf program.
> > Could you please respin with that change included?
>
> Just in time, I was about to push this back out. :)
>
> Jesper, please respin with Alexei's requested changes.
Your guys are torturing me!
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2018-04-17 14:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 12:58 [net-next V10 PATCH 00/16] XDP redirect memory return API Jesper Dangaard Brouer
2018-04-17 12:58 ` [net-next V10 PATCH 01/16] mlx5: basic XDP_REDIRECT forward support Jesper Dangaard Brouer
2018-04-17 12:59 ` [net-next V10 PATCH 02/16] xdp: introduce xdp_return_frame API and use in cpumap Jesper Dangaard Brouer
2018-04-17 12:59 ` [net-next V10 PATCH 03/16] ixgbe: use xdp_return_frame API Jesper Dangaard Brouer
2018-04-17 12:59 ` [net-next V10 PATCH 04/16] xdp: move struct xdp_buff from filter.h to xdp.h Jesper Dangaard Brouer
2018-04-17 12:59 ` [net-next V10 PATCH 05/16] xdp: introduce a new xdp_frame type Jesper Dangaard Brouer
2018-04-17 12:59 ` [net-next V10 PATCH 06/16] tun: convert to use generic xdp_frame and xdp_return_frame API Jesper Dangaard Brouer
2018-04-17 12:59 ` [net-next V10 PATCH 07/16] virtio_net: " Jesper Dangaard Brouer
2018-04-17 12:59 ` [net-next V10 PATCH 08/16] bpf: cpumap convert to use generic xdp_frame Jesper Dangaard Brouer
2018-04-17 12:59 ` [net-next V10 PATCH 09/16] i40e: convert to use generic xdp_frame and xdp_return_frame API Jesper Dangaard Brouer
2018-04-17 12:59 ` [net-next V10 PATCH 10/16] mlx5: register a memory model when XDP is enabled Jesper Dangaard Brouer
2018-04-17 12:59 ` [net-next V10 PATCH 11/16] xdp: rhashtable with allocator ID to pointer mapping Jesper Dangaard Brouer
2018-04-17 12:59 ` [net-next V10 PATCH 12/16] page_pool: refurbish version of page_pool code Jesper Dangaard Brouer
2018-04-17 12:59 ` [net-next V10 PATCH 13/16] xdp: allow page_pool as an allocator type in xdp_return_frame Jesper Dangaard Brouer
2018-04-17 13:00 ` [net-next V10 PATCH 14/16] mlx5: use page_pool for xdp_return_frame call Jesper Dangaard Brouer
2018-04-17 13:00 ` [net-next V10 PATCH 15/16] xdp: transition into using xdp_frame for return API Jesper Dangaard Brouer
2018-04-17 13:00 ` [net-next V10 PATCH 16/16] xdp: transition into using xdp_frame for ndo_xdp_xmit Jesper Dangaard Brouer
2018-04-17 13:53 ` [net-next V10 PATCH 00/16] XDP redirect memory return API Alexei Starovoitov
2018-04-17 14:07 ` David Miller
2018-04-17 14:39 ` Jesper Dangaard Brouer [this message]
2018-04-17 14:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180417163930.5aa24de9@redhat.com \
--to=brouer@redhat.com \
--cc=alexei.starovoitov@gmail.com \
--cc=bjorn.topel@intel.com \
--cc=borkmann@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eranbe@mellanox.com \
--cc=eugenia@mellanox.com \
--cc=galp@mellanox.com \
--cc=jasowang@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.