All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org
Cc: jeykumar-jfJNa2p1gH1BDgjK7y7TUQ@public.gmane.org,
	linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	hoegsberg-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
	freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	chandanu-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org
Subject: Re: [DPU PATCH v2 2/2] drm/panel: add backlight control support for truly panel
Date: Tue, 17 Apr 2018 14:29:01 -0700	[thread overview]
Message-ID: <20180417212901.GK18510@minitux> (raw)
In-Reply-To: <e220ca93282a7d942d4144ac2313efc0-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>

On Tue 17 Apr 11:21 PDT 2018, abhinavk@codeaurora.org wrote:
> On 2018-04-16 23:13, Bjorn Andersson wrote:
[..]
> > If the panel isn't actually a piece of backlight hardware then it should
> > not register a backlight device. Why do you need your own sysfs?
> > 
> > Regards,
> > Bjorn
> [Abhinav] This particular panel isnt a piece of backlight hardware.
> But, we want to have our own sysfs to give flexibility to our userspace
> to write and read stuff for its proprietary uses.

Please be more specific in your replies, no one will accept code that
"does stuff" and expecting a reviewer to spend time guessing or pulling
the information out of you is a sure way to get your patches ignored.

Exactly what kind of stuff are you talking about here and exactly which
problem are you solving.

> Thats how our downstream has been working so far and hence to maintain
> the compatibility would like to have it.

Make your proprietary code work with the upstream kernel and you
shouldn't ever have to modify it.

Regards,
Bjorn
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno

  parent reply	other threads:[~2018-04-17 21:29 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-14  7:25 [DPU PATCH v2 1/2] drm/panel: Add Truly NT35597 panel Abhinav Kumar
     [not found] ` <1523690713-22543-1-git-send-email-abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-04-14  7:25   ` [DPU PATCH v2 2/2] drm/panel: add backlight control support for truly panel Abhinav Kumar
     [not found]     ` <1523690713-22543-2-git-send-email-abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-04-16 16:41       ` Bjorn Andersson
2018-04-16 16:51         ` Sean Paul
2018-04-16 22:45         ` abhinavk-sgV2jX0FEOL9JmXXK+q4OQ
     [not found]           ` <d50c2a2dac7d6541d78eee60c2ff4739-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-04-17  6:13             ` Bjorn Andersson
2018-04-17 18:21               ` [Freedreno] " abhinavk
     [not found]                 ` <e220ca93282a7d942d4144ac2313efc0-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-04-17 18:57                   ` Sujeev Dias
2018-04-17 21:29                   ` Bjorn Andersson [this message]
2018-04-18  0:04                     ` abhinavk-sgV2jX0FEOL9JmXXK+q4OQ
2018-04-18  0:42                       ` [Freedreno] " abhinavk
2018-04-18 10:52                         ` Daniel Thompson
     [not found]                           ` <20180418105218.oja4gogmcx32ym5a-SoAo7ar8mTX/PtFMR13I2A@public.gmane.org>
2018-04-18 13:42                             ` Sean Paul
2018-04-18 22:08                               ` abhinavk-sgV2jX0FEOL9JmXXK+q4OQ
     [not found]                         ` <be0fa84101458da4cd6d77b963189baf-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-04-19  4:24                           ` Bjorn Andersson
2018-04-18 13:32                       ` [Freedreno] " Sean Paul
     [not found]                       ` <7cb250765fbf7b633fd54e4338cc433d-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-04-19  4:00                         ` Bjorn Andersson
2018-04-19  4:23                           ` abhinavk-sgV2jX0FEOL9JmXXK+q4OQ
     [not found]                             ` <b2e4e39d6911d4ab89fa753d194392b6-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-04-19  4:42                               ` Bjorn Andersson
2018-05-24  1:37                                 ` abhinavk-sgV2jX0FEOL9JmXXK+q4OQ
2018-04-19 17:44   ` [DPU PATCH v2 1/2] drm/panel: Add Truly NT35597 panel Archit Taneja
2018-05-24  1:28     ` abhinavk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180417212901.GK18510@minitux \
    --to=bjorn.andersson-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
    --cc=abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=chandanu-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=hoegsberg-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=jeykumar-jfJNa2p1gH1BDgjK7y7TUQ@public.gmane.org \
    --cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.