All of lore.kernel.org
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme: fix the suspicious RCU usage warning in nvme_mpath_clear_current_path
Date: Wed, 18 Apr 2018 12:19:13 +0200	[thread overview]
Message-ID: <20180418101913.GB15833@lst.de> (raw)
In-Reply-To: <1524036767-3701-1-git-send-email-jianchao.w.wang@oracle.com>

On Wed, Apr 18, 2018@03:32:47PM +0800, Jianchao Wang wrote:
> With lockdep enabled, when trigger nvme_remove, suspicious RCU
> usage warning will be printed out.
> Fix it with adding srcu_read_lock/unlock in it.

Looks fine,

Reviewed-by: Christoph Hellwig <hch at lst.de>

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Jianchao Wang <jianchao.w.wang@oracle.com>
Cc: keith.busch@intel.com, axboe@fb.com, hch@lst.de,
	sagi@grimberg.me, linux-nvme@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme: fix the suspicious RCU usage warning in nvme_mpath_clear_current_path
Date: Wed, 18 Apr 2018 12:19:13 +0200	[thread overview]
Message-ID: <20180418101913.GB15833@lst.de> (raw)
In-Reply-To: <1524036767-3701-1-git-send-email-jianchao.w.wang@oracle.com>

On Wed, Apr 18, 2018 at 03:32:47PM +0800, Jianchao Wang wrote:
> With lockdep enabled, when trigger nvme_remove, suspicious RCU
> usage warning will be printed out.
> Fix it with adding srcu_read_lock/unlock in it.

Looks fine,

Reviewed-by: Christoph Hellwig <hch@lst.de>

  reply	other threads:[~2018-04-18 10:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-18  7:32 [PATCH] nvme: fix the suspicious RCU usage warning in nvme_mpath_clear_current_path Jianchao Wang
2018-04-18  7:32 ` Jianchao Wang
2018-04-18 10:19 ` Christoph Hellwig [this message]
2018-04-18 10:19   ` Christoph Hellwig
2018-04-18 14:45 ` Keith Busch
2018-04-18 14:45   ` Keith Busch
2018-04-18 15:07   ` Christoph Hellwig
2018-04-18 15:07     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180418101913.GB15833@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.