From: Huang Rui <ray.huang-5C7GfCeVMHo@public.gmane.org>
To: "Christian König"
<ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] drm/scheduler: fix build broken by "move last_sched fence updating prior to job popping"
Date: Wed, 18 Apr 2018 19:15:59 +0800 [thread overview]
Message-ID: <20180418111558.GA8166@hr-amur2> (raw)
In-Reply-To: <20180418100627.11879-1-christian.koenig-5C7GfCeVMHo@public.gmane.org>
On Wed, Apr 18, 2018 at 12:06:27PM +0200, Christian König wrote:
> We don't have s_fence as local variable here.
>
> Signed-off-by: Christian König <christian.koenig@amd.com>
I just also meet this issue, and file the patch. And found you already
fixed it.
Acked-by: Huang Rui <ray.huang@amd.com>
> ---
> drivers/gpu/drm/scheduler/gpu_scheduler.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler.c b/drivers/gpu/drm/scheduler/gpu_scheduler.c
> index 5de79bbb12c8..f4b862503710 100644
> --- a/drivers/gpu/drm/scheduler/gpu_scheduler.c
> +++ b/drivers/gpu/drm/scheduler/gpu_scheduler.c
> @@ -402,7 +402,7 @@ drm_sched_entity_pop_job(struct drm_sched_entity *entity)
> dma_fence_set_error(&sched_job->s_fence->finished, -ECANCELED);
>
> dma_fence_put(entity->last_scheduled);
> - entity->last_scheduled = dma_fence_get(&s_fence->finished);
> + entity->last_scheduled = dma_fence_get(&sched_job->s_fence->finished);
>
> spsc_queue_pop(&entity->job_queue);
> return sched_job;
> --
> 2.14.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2018-04-18 11:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 10:06 [PATCH] drm/scheduler: fix build broken by "move last_sched fence updating prior to job popping" Christian König
[not found] ` <20180418100627.11879-1-christian.koenig-5C7GfCeVMHo@public.gmane.org>
2018-04-18 10:33 ` Zhou, David(ChunMing)
2018-04-18 11:00 ` Michel Dänzer
2018-04-18 11:15 ` Huang Rui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180418111558.GA8166@hr-amur2 \
--to=ray.huang-5c7gfcevmho@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.