Re: [PATCH] drm/scheduler: fix build broken by "move last_sched fence updating prior to job popping"

From: "Michel Dänzer" <michel-otUistvHUpPR7s880joybQ@public.gmane.org>
To: "Christian König"
	<ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] drm/scheduler: fix build broken by "move last_sched fence updating prior to job popping"
Date: Wed, 18 Apr 2018 13:00:37 +0200	[thread overview]
Message-ID: <d3eae5a7-7084-ec6a-bfed-e27b96e33bf2@daenzer.net> (raw)
In-Reply-To: <20180418100627.11879-1-christian.koenig-5C7GfCeVMHo@public.gmane.org>

On 2018-04-18 12:06 PM, Christian König wrote:
> We don't have s_fence as local variable here.
> 
> Signed-off-by: Christian König <christian.koenig@amd.com>
> ---
>  drivers/gpu/drm/scheduler/gpu_scheduler.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler.c b/drivers/gpu/drm/scheduler/gpu_scheduler.c
> index 5de79bbb12c8..f4b862503710 100644
> --- a/drivers/gpu/drm/scheduler/gpu_scheduler.c
> +++ b/drivers/gpu/drm/scheduler/gpu_scheduler.c
> @@ -402,7 +402,7 @@ drm_sched_entity_pop_job(struct drm_sched_entity *entity)
>  		dma_fence_set_error(&sched_job->s_fence->finished, -ECANCELED);
>  
>  	dma_fence_put(entity->last_scheduled);
> -	entity->last_scheduled = dma_fence_get(&s_fence->finished);
> +	entity->last_scheduled = dma_fence_get(&sched_job->s_fence->finished);
>  
>  	spsc_queue_pop(&entity->job_queue);
>  	return sched_job;
> 

There's no need to wait for a review before pushing such an obvious and
trivial fix for a compile failure.

-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx