From: William Breathitt Gray <vilhelm.gray@gmail.com>
To: Colin King <colin.king@canonical.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpio: make several const arrays static, shrinks object size
Date: Wed, 18 Apr 2018 17:40:43 +0000 [thread overview]
Message-ID: <20180418174043.GA15833@sophia> (raw)
In-Reply-To: <20180418172634.14734-1-colin.king@canonical.com>
On Wed, Apr 18, 2018 at 06:26:34PM +0100, Colin King wrote:
>From: Colin Ian King <colin.king@canonical.com>
>
>Don't populate the const read-only arrays 'port' on the stack but
>instead make them static. Makes the object code smaller:
>
>Before:
> text data bss dec hex filename
> 8542 4088 672 13302 33f6 drivers/gpio/gpio-gpio-mm.o
> 10959 4952 832 16743 4167 drivers/gpio/gpio-104-dio-48e.o
> 9022 5064 1408 15494 3c86 drivers/gpio/gpio-104-idi-48.o
>
>After:
> text data bss dec hex filename
> 8372 4144 672 13188 3384 drivers/gpio/gpio-gpio-mm.o
> 10790 5008 832 16630 40f6 drivers/gpio/gpio-104-dio-48e.o
> 8853 5152 1408 15413 3c35 linux/drivers/gpio/gpio-104-idi-48.o
>
>(gcc version 7.2.0 x86_64)
>
>Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: William Breathitt Gray <vilhelm.gray@gmail.com>
WARNING: multiple messages have this Message-ID (diff)
From: William Breathitt Gray <vilhelm.gray@gmail.com>
To: Colin King <colin.king@canonical.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpio: make several const arrays static, shrinks object size
Date: Wed, 18 Apr 2018 13:40:43 -0400 [thread overview]
Message-ID: <20180418174043.GA15833@sophia> (raw)
In-Reply-To: <20180418172634.14734-1-colin.king@canonical.com>
On Wed, Apr 18, 2018 at 06:26:34PM +0100, Colin King wrote:
>From: Colin Ian King <colin.king@canonical.com>
>
>Don't populate the const read-only arrays 'port' on the stack but
>instead make them static. Makes the object code smaller:
>
>Before:
> text data bss dec hex filename
> 8542 4088 672 13302 33f6 drivers/gpio/gpio-gpio-mm.o
> 10959 4952 832 16743 4167 drivers/gpio/gpio-104-dio-48e.o
> 9022 5064 1408 15494 3c86 drivers/gpio/gpio-104-idi-48.o
>
>After:
> text data bss dec hex filename
> 8372 4144 672 13188 3384 drivers/gpio/gpio-gpio-mm.o
> 10790 5008 832 16630 40f6 drivers/gpio/gpio-104-dio-48e.o
> 8853 5152 1408 15413 3c35 linux/drivers/gpio/gpio-104-idi-48.o
>
>(gcc version 7.2.0 x86_64)
>
>Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: William Breathitt Gray <vilhelm.gray@gmail.com>
next prev parent reply other threads:[~2018-04-18 17:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 17:26 [PATCH] gpio: make several const arrays static, shrinks object size Colin King
2018-04-18 17:26 ` Colin King
2018-04-18 17:40 ` William Breathitt Gray [this message]
2018-04-18 17:40 ` William Breathitt Gray
2018-04-26 23:03 ` Linus Walleij
2018-04-26 23:03 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180418174043.GA15833@sophia \
--to=vilhelm.gray@gmail.com \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.