* [virtio-dev] [PATCH] content: document hugetlb page allocation counts
@ 2018-04-18 17:10 Jonathan Helman
2018-04-18 20:03 ` [virtio-dev] " Michael S. Tsirkin
2018-04-19 9:24 ` [virtio-dev] " Stefan Hajnoczi
0 siblings, 2 replies; 6+ messages in thread
From: Jonathan Helman @ 2018-04-18 17:10 UTC (permalink / raw)
To: virtio-dev; +Cc: mihai.carabas, mst, jasowang, Jonathan Helman
The Linux kernel exports the number of successful and failed
hugetlb page allocations via the virtio balloon driver. These
two counts need to be documented in this specification.
Signed-off-by: Jonathan Helman <jonathan.helman@oracle.com>
---
content.tex | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/content.tex b/content.tex
index 7a92cb1..110ab70 100644
--- a/content.tex
+++ b/content.tex
@@ -4516,6 +4516,8 @@ struct virtio_balloon_stat {
#define VIRTIO_BALLOON_S_MEMTOT 5
#define VIRTIO_BALLOON_S_AVAIL 6
#define VIRTIO_BALLOON_S_CACHES 7
+#define VIRTIO_BALLOON_S_HTLB_PGALLOC 8
+#define VIRTIO_BALLOON_S_HTLB_PGFAIL 9
le16 tag;
le64 val;
} __attribute__((packed));
@@ -4604,6 +4606,12 @@ first buffer.
\item[VIRTIO_BALLOON_S_CACHES (7)] The amount of memory, in bytes, that can be
quickly reclaimed without additional I/O. Typically these pages are used for
caching files from disk.
+
+\item[VIRTIO_BALLOON_S_HTLB_PGALLOC (8)] The number of successful hugetlb page
+ allocations in the guest.
+
+\item[VIRTIO_BALLOON_S_HTLB_PGFAIL (9)] The number of failed hugetlb page
+ allocations in the guest.
\end{description}
\section{SCSI Host Device}\label{sec:Device Types / SCSI Host Device}
--
1.8.3.1
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
^ permalink raw reply related [flat|nested] 6+ messages in thread* [virtio-dev] Re: [PATCH] content: document hugetlb page allocation counts
2018-04-18 17:10 [virtio-dev] [PATCH] content: document hugetlb page allocation counts Jonathan Helman
@ 2018-04-18 20:03 ` Michael S. Tsirkin
2018-04-18 21:16 ` Jonathan Helman
2018-04-19 9:24 ` [virtio-dev] " Stefan Hajnoczi
1 sibling, 1 reply; 6+ messages in thread
From: Michael S. Tsirkin @ 2018-04-18 20:03 UTC (permalink / raw)
To: Jonathan Helman; +Cc: virtio-dev, mihai.carabas, jasowang
On Wed, Apr 18, 2018 at 10:10:19AM -0700, Jonathan Helman wrote:
> The Linux kernel exports the number of successful and failed
> hugetlb page allocations via the virtio balloon driver. These
> two counts need to be documented in this specification.
>
> Signed-off-by: Jonathan Helman <jonathan.helman@oracle.com>
Thanks!
Would you mind opening a github issue to address that?
If you have to repost, you will be able to add a "Fixes:" tag
then.
> ---
> content.tex | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/content.tex b/content.tex
> index 7a92cb1..110ab70 100644
> --- a/content.tex
> +++ b/content.tex
> @@ -4516,6 +4516,8 @@ struct virtio_balloon_stat {
> #define VIRTIO_BALLOON_S_MEMTOT 5
> #define VIRTIO_BALLOON_S_AVAIL 6
> #define VIRTIO_BALLOON_S_CACHES 7
> +#define VIRTIO_BALLOON_S_HTLB_PGALLOC 8
> +#define VIRTIO_BALLOON_S_HTLB_PGFAIL 9
> le16 tag;
> le64 val;
> } __attribute__((packed));
> @@ -4604,6 +4606,12 @@ first buffer.
> \item[VIRTIO_BALLOON_S_CACHES (7)] The amount of memory, in bytes, that can be
> quickly reclaimed without additional I/O. Typically these pages are used for
> caching files from disk.
> +
> +\item[VIRTIO_BALLOON_S_HTLB_PGALLOC (8)] The number of successful hugetlb page
> + allocations in the guest.
> +
> +\item[VIRTIO_BALLOON_S_HTLB_PGFAIL (9)] The number of failed hugetlb page
> + allocations in the guest.
> \end{description}
>
> \section{SCSI Host Device}\label{sec:Device Types / SCSI Host Device}
> --
> 1.8.3.1
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [virtio-dev] Re: [PATCH] content: document hugetlb page allocation counts
2018-04-18 20:03 ` [virtio-dev] " Michael S. Tsirkin
@ 2018-04-18 21:16 ` Jonathan Helman
0 siblings, 0 replies; 6+ messages in thread
From: Jonathan Helman @ 2018-04-18 21:16 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: virtio-dev, mihai.carabas, jasowang
On 04/18/2018 01:03 PM, Michael S. Tsirkin wrote:
> On Wed, Apr 18, 2018 at 10:10:19AM -0700, Jonathan Helman wrote:
>> The Linux kernel exports the number of successful and failed
>> hugetlb page allocations via the virtio balloon driver. These
>> two counts need to be documented in this specification.
>>
>> Signed-off-by: Jonathan Helman <jonathan.helman@oracle.com>
>
> Thanks!
> Would you mind opening a github issue to address that?
Done. https://github.com/oasis-tcs/virtio-spec/issues/8
Jon
> If you have to repost, you will be able to add a "Fixes:" tag
> then.
>
>> ---
>> content.tex | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/content.tex b/content.tex
>> index 7a92cb1..110ab70 100644
>> --- a/content.tex
>> +++ b/content.tex
>> @@ -4516,6 +4516,8 @@ struct virtio_balloon_stat {
>> #define VIRTIO_BALLOON_S_MEMTOT 5
>> #define VIRTIO_BALLOON_S_AVAIL 6
>> #define VIRTIO_BALLOON_S_CACHES 7
>> +#define VIRTIO_BALLOON_S_HTLB_PGALLOC 8
>> +#define VIRTIO_BALLOON_S_HTLB_PGFAIL 9
>> le16 tag;
>> le64 val;
>> } __attribute__((packed));
>> @@ -4604,6 +4606,12 @@ first buffer.
>> \item[VIRTIO_BALLOON_S_CACHES (7)] The amount of memory, in bytes, that can be
>> quickly reclaimed without additional I/O. Typically these pages are used for
>> caching files from disk.
>> +
>> +\item[VIRTIO_BALLOON_S_HTLB_PGALLOC (8)] The number of successful hugetlb page
>> + allocations in the guest.
>> +
>> +\item[VIRTIO_BALLOON_S_HTLB_PGFAIL (9)] The number of failed hugetlb page
>> + allocations in the guest.
>> \end{description}
>>
>> \section{SCSI Host Device}\label{sec:Device Types / SCSI Host Device}
>> --
>> 1.8.3.1
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
> For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [virtio-dev] [PATCH] content: document hugetlb page allocation counts
2018-04-18 17:10 [virtio-dev] [PATCH] content: document hugetlb page allocation counts Jonathan Helman
2018-04-18 20:03 ` [virtio-dev] " Michael S. Tsirkin
@ 2018-04-19 9:24 ` Stefan Hajnoczi
2018-04-25 18:26 ` Jonathan Helman
1 sibling, 1 reply; 6+ messages in thread
From: Stefan Hajnoczi @ 2018-04-19 9:24 UTC (permalink / raw)
To: Jonathan Helman; +Cc: virtio-dev, mihai.carabas, mst, jasowang
[-- Attachment #1: Type: text/plain, Size: 447 bytes --]
On Wed, Apr 18, 2018 at 10:10:19AM -0700, Jonathan Helman wrote:
> The Linux kernel exports the number of successful and failed
> hugetlb page allocations via the virtio balloon driver. These
> two counts need to be documented in this specification.
>
> Signed-off-by: Jonathan Helman <jonathan.helman@oracle.com>
> ---
> content.tex | 8 ++++++++
> 1 file changed, 8 insertions(+)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [virtio-dev] [PATCH] content: document hugetlb page allocation counts
2018-04-19 9:24 ` [virtio-dev] " Stefan Hajnoczi
@ 2018-04-25 18:26 ` Jonathan Helman
2018-04-25 22:25 ` Michael S. Tsirkin
0 siblings, 1 reply; 6+ messages in thread
From: Jonathan Helman @ 2018-04-25 18:26 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: virtio-dev, mihai.carabas, mst, jasowang, Thomas Tai
On 04/19/2018 02:24 AM, Stefan Hajnoczi wrote:
> On Wed, Apr 18, 2018 at 10:10:19AM -0700, Jonathan Helman wrote:
>> The Linux kernel exports the number of successful and failed
>> hugetlb page allocations via the virtio balloon driver. These
>> two counts need to be documented in this specification.
>>
>> Signed-off-by: Jonathan Helman <jonathan.helman@oracle.com>
>> ---
>> content.tex | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>
Thanks. Do I need to take some action, like adding a tag to the github
issue I opened?
Jon
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [virtio-dev] [PATCH] content: document hugetlb page allocation counts
2018-04-25 18:26 ` Jonathan Helman
@ 2018-04-25 22:25 ` Michael S. Tsirkin
0 siblings, 0 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2018-04-25 22:25 UTC (permalink / raw)
To: Jonathan Helman
Cc: Stefan Hajnoczi, virtio-dev, mihai.carabas, jasowang, Thomas Tai
On Wed, Apr 25, 2018 at 11:26:59AM -0700, Jonathan Helman wrote:
>
>
> On 04/19/2018 02:24 AM, Stefan Hajnoczi wrote:
> > On Wed, Apr 18, 2018 at 10:10:19AM -0700, Jonathan Helman wrote:
> > > The Linux kernel exports the number of successful and failed
> > > hugetlb page allocations via the virtio balloon driver. These
> > > two counts need to be documented in this specification.
> > >
> > > Signed-off-by: Jonathan Helman <jonathan.helman@oracle.com>
> > > ---
> > > content.tex | 8 ++++++++
> > > 1 file changed, 8 insertions(+)
> >
> > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> >
>
> Thanks. Do I need to take some action, like adding a tag to the github issue
> I opened?
>
> Jon
Just what you did: ask for voting to start.
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-04-25 22:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-18 17:10 [virtio-dev] [PATCH] content: document hugetlb page allocation counts Jonathan Helman
2018-04-18 20:03 ` [virtio-dev] " Michael S. Tsirkin
2018-04-18 21:16 ` Jonathan Helman
2018-04-19 9:24 ` [virtio-dev] " Stefan Hajnoczi
2018-04-25 18:26 ` Jonathan Helman
2018-04-25 22:25 ` Michael S. Tsirkin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.