From: Shawn Guo <shawnguo@kernel.org>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Anson Huang <Anson.Huang@nxp.com>,
mark.rutland@arm.com, devicetree@vger.kernel.org,
mturquette@baylibre.com, linux-clk@vger.kernel.org,
linux@armlinux.org.uk, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, Linux-imx@nxp.com, kernel@pengutronix.de,
fabio.estevam@nxp.com, shengjiu.wang@nxp.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V2 2/2] ARM: dts: imx6sx-sabreauto: add external 24MHz clock source
Date: Thu, 19 Apr 2018 22:02:37 +0800 [thread overview]
Message-ID: <20180419140236.GU25429@dragon> (raw)
In-Reply-To: <152410785516.46528.12432838242068784117@swboyd.mtv.corp.google.com>
On Wed, Apr 18, 2018 at 08:17:35PM -0700, Stephen Boyd wrote:
> Quoting Shawn Guo (2018-04-17 07:22:05)
> > On Mon, Mar 19, 2018 at 10:30:45AM +0800, Anson Huang wrote:
> > > On i.MX6SX SabreAuto board, there is external 24MHz clock
> > > source for analog clock2, add this clock source to clock tree.
> > >
> > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > > ---
> > > changes since V1:
> > > remove unnecessary clocks container.
> >
> > I understand this is suggested by Fabio, but I'm afraid that it's not
> > going to work with imx_obtain_fixed_clock() call, which is coded to
> > look for clocks under /clocks node.
> >
>
> Should patch #1 be dropped from clk tree?
No. Patch #1 is good.
Shawn
WARNING: multiple messages have this Message-ID (diff)
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 2/2] ARM: dts: imx6sx-sabreauto: add external 24MHz clock source
Date: Thu, 19 Apr 2018 22:02:37 +0800 [thread overview]
Message-ID: <20180419140236.GU25429@dragon> (raw)
In-Reply-To: <152410785516.46528.12432838242068784117@swboyd.mtv.corp.google.com>
On Wed, Apr 18, 2018 at 08:17:35PM -0700, Stephen Boyd wrote:
> Quoting Shawn Guo (2018-04-17 07:22:05)
> > On Mon, Mar 19, 2018 at 10:30:45AM +0800, Anson Huang wrote:
> > > On i.MX6SX SabreAuto board, there is external 24MHz clock
> > > source for analog clock2, add this clock source to clock tree.
> > >
> > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > > ---
> > > changes since V1:
> > > remove unnecessary clocks container.
> >
> > I understand this is suggested by Fabio, but I'm afraid that it's not
> > going to work with imx_obtain_fixed_clock() call, which is coded to
> > look for clocks under /clocks node.
> >
>
> Should patch #1 be dropped from clk tree?
No. Patch #1 is good.
Shawn
next prev parent reply other threads:[~2018-04-19 14:02 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-19 2:30 [PATCH V2 1/2] clk: imx6sx: add missing lvds2 clock to the clock tree Anson Huang
2018-03-19 2:30 ` Anson Huang
2018-03-19 2:30 ` Anson Huang
2018-03-19 2:30 ` [PATCH V2 2/2] ARM: dts: imx6sx-sabreauto: add external 24MHz clock source Anson Huang
2018-03-19 2:30 ` Anson Huang
2018-03-19 2:30 ` Anson Huang
2018-04-17 14:22 ` Shawn Guo
2018-04-17 14:22 ` Shawn Guo
2018-04-19 3:17 ` Stephen Boyd
2018-04-19 3:17 ` Stephen Boyd
2018-04-19 3:17 ` Stephen Boyd
2018-04-19 3:23 ` Anson Huang
2018-04-19 3:23 ` Anson Huang
2018-04-19 3:23 ` Anson Huang
2018-04-19 14:03 ` Shawn Guo
2018-04-19 14:03 ` Shawn Guo
2018-04-19 14:02 ` Shawn Guo [this message]
2018-04-19 14:02 ` Shawn Guo
2018-04-19 14:24 ` Shawn Guo
2018-04-19 14:24 ` Shawn Guo
2018-04-19 19:32 ` Stephen Boyd
2018-04-19 19:32 ` Stephen Boyd
2018-04-19 19:32 ` Stephen Boyd
2018-03-26 22:23 ` [PATCH V2 1/2] clk: imx6sx: add missing lvds2 clock to the clock tree Rob Herring
2018-03-26 22:23 ` Rob Herring
2018-04-16 18:32 ` Stephen Boyd
2018-04-16 18:32 ` Stephen Boyd
2018-04-16 18:32 ` Stephen Boyd
2018-04-19 14:57 ` Shawn Guo
2018-04-19 14:57 ` Shawn Guo
2018-04-20 6:57 ` Anson Huang
2018-04-20 6:57 ` Anson Huang
2018-04-20 6:57 ` Anson Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180419140236.GU25429@dragon \
--to=shawnguo@kernel.org \
--cc=Anson.Huang@nxp.com \
--cc=Linux-imx@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=shengjiu.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.