From: Borislav Petkov <bp@alien8.de>
To: "Alex G." <mr.nuke.me@gmail.com>
Cc: linux-acpi@vger.kernel.org, linux-edac@vger.kernel.org,
rjw@rjwysocki.net, lenb@kernel.org, tony.luck@intel.com,
tbaicar@codeaurora.org, will.deacon@arm.com, james.morse@arm.com,
shiju.jose@huawei.com, zjzhang@codeaurora.org,
gengdongjiu@huawei.com, linux-kernel@vger.kernel.org,
alex_gagniuc@dellteam.com, austin_bolen@dell.com,
shyam_iyer@dell.com, devel@acpica.org, mchehab@kernel.org,
robert.moore@intel.com, erik.schmauss@intel.com
Subject: Re: [RFC PATCH v2 2/4] acpi: apei: Split GHES handlers outside of ghes_do_proc
Date: Thu, 19 Apr 2018 17:29:33 +0200 [thread overview]
Message-ID: <20180419152933.GD3600@pd.tnic> (raw)
In-Reply-To: <8f467611-16a1-8fe7-ea12-e2e29023e4e8@gmail.com>
On Thu, Apr 19, 2018 at 09:57:08AM -0500, Alex G. wrote:
> And that was the motivation behind my splitting it in this patch.
By "split" I don't mean add a function pointer which gets selected and
then called - if the function becomes too long, you simply split the
function body properly.
> You don't need the entire GHES structure -- wide context. Individual
> handlers should not be able to access the entire ghes.
But you remove the @ghes argument in patch 1. So what are we even
talking about?
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: "Alex G." <mr.nuke.me@gmail.com>
Cc: linux-acpi@vger.kernel.org, linux-edac@vger.kernel.org,
rjw@rjwysocki.net, lenb@kernel.org, tony.luck@intel.com,
tbaicar@codeaurora.org, will.deacon@arm.com, james.morse@arm.com,
shiju.jose@huawei.com, zjzhang@codeaurora.org,
gengdongjiu@huawei.com, linux-kernel@vger.kernel.org,
alex_gagniuc@dellteam.com, austin_bolen@dell.com,
shyam_iyer@dell.com, devel@acpica.org, mchehab@kernel.org,
robert.moore@intel.com, erik.schmauss@intel.com
Subject: [RFC,v2,2/4] acpi: apei: Split GHES handlers outside of ghes_do_proc
Date: Thu, 19 Apr 2018 17:29:33 +0200 [thread overview]
Message-ID: <20180419152933.GD3600@pd.tnic> (raw)
On Thu, Apr 19, 2018 at 09:57:08AM -0500, Alex G. wrote:
> And that was the motivation behind my splitting it in this patch.
By "split" I don't mean add a function pointer which gets selected and
then called - if the function becomes too long, you simply split the
function body properly.
> You don't need the entire GHES structure -- wide context. Individual
> handlers should not be able to access the entire ghes.
But you remove the @ghes argument in patch 1. So what are we even
talking about?
next prev parent reply other threads:[~2018-04-19 15:29 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 21:58 [RFC PATCH v2 0/4] acpi: apei: Improve error handling with firmware-first Alexandru Gagniuc
2018-04-16 21:59 ` [RFC PATCH v2 1/4] EDAC, GHES: Remove unused argument to ghes_edac_report_mem_error Alexandru Gagniuc
2018-04-16 21:59 ` [RFC,v2,1/4] " Alexandru Gagniuc
2018-04-17 9:36 ` [RFC PATCH v2 1/4] " Borislav Petkov
2018-04-17 9:36 ` [RFC,v2,1/4] " Borislav Petkov
2018-04-17 16:43 ` [RFC PATCH v2 1/4] " Alex G.
2018-04-17 16:43 ` [RFC,v2,1/4] " Alexandru Gagniuc
2018-04-16 21:59 ` [RFC PATCH v2 2/4] acpi: apei: Split GHES handlers outside of ghes_do_proc Alexandru Gagniuc
2018-04-16 21:59 ` [RFC,v2,2/4] " Alexandru Gagniuc
2018-04-18 17:52 ` [RFC PATCH v2 2/4] " Borislav Petkov
2018-04-18 17:52 ` [RFC,v2,2/4] " Borislav Petkov
2018-04-19 14:19 ` [RFC PATCH v2 2/4] " Alex G.
2018-04-19 14:19 ` [RFC,v2,2/4] " Alexandru Gagniuc
2018-04-19 14:30 ` [RFC PATCH v2 2/4] " Borislav Petkov
2018-04-19 14:30 ` [RFC,v2,2/4] " Borislav Petkov
2018-04-19 14:57 ` [RFC PATCH v2 2/4] " Alex G.
2018-04-19 14:57 ` [RFC,v2,2/4] " Alexandru Gagniuc
2018-04-19 15:29 ` Borislav Petkov [this message]
2018-04-19 15:29 ` Borislav Petkov
2018-04-19 15:46 ` [RFC PATCH v2 2/4] " Alex G.
2018-04-19 15:46 ` [RFC,v2,2/4] " Alexandru Gagniuc
2018-04-19 16:40 ` [RFC PATCH v2 2/4] " Borislav Petkov
2018-04-19 16:40 ` [RFC,v2,2/4] " Borislav Petkov
2018-04-16 21:59 ` [RFC PATCH v2 3/4] acpi: apei: Do not panic() when correctable errors are marked as fatal Alexandru Gagniuc
2018-04-16 21:59 ` [RFC,v2,3/4] " Alexandru Gagniuc
2018-04-18 17:54 ` [RFC PATCH v2 3/4] " Borislav Petkov
2018-04-18 17:54 ` [RFC,v2,3/4] " Borislav Petkov
2018-04-19 14:57 ` [RFC PATCH v2 3/4] " Alex G.
2018-04-19 14:57 ` [RFC,v2,3/4] " Alexandru Gagniuc
2018-04-19 15:35 ` [Devel] [RFC PATCH v2 3/4] " James Morse
2018-04-19 15:35 ` [RFC,v2,3/4] " James Morse
2018-04-19 15:35 ` [RFC PATCH v2 3/4] " James Morse
2018-04-19 16:27 ` Alex G.
2018-04-19 16:27 ` [RFC,v2,3/4] " Alexandru Gagniuc
2018-04-19 15:40 ` [RFC PATCH v2 3/4] " Borislav Petkov
2018-04-19 15:40 ` [RFC,v2,3/4] " Borislav Petkov
2018-04-19 16:26 ` [RFC PATCH v2 3/4] " Alex G.
2018-04-19 16:26 ` [RFC,v2,3/4] " Alexandru Gagniuc
2018-04-19 16:45 ` [RFC PATCH v2 3/4] " Borislav Petkov
2018-04-19 16:45 ` [RFC,v2,3/4] " Borislav Petkov
2018-04-19 17:40 ` [RFC PATCH v2 3/4] " Alex G.
2018-04-19 17:40 ` [RFC,v2,3/4] " Alexandru Gagniuc
2018-04-19 19:03 ` [RFC PATCH v2 3/4] " Borislav Petkov
2018-04-19 19:03 ` [RFC,v2,3/4] " Borislav Petkov
2018-04-19 22:55 ` [RFC PATCH v2 3/4] " Alex G.
2018-04-19 22:55 ` [RFC,v2,3/4] " Alexandru Gagniuc
2018-04-22 10:48 ` [RFC PATCH v2 3/4] " Borislav Petkov
2018-04-22 10:48 ` [RFC,v2,3/4] " Borislav Petkov
2018-04-24 4:19 ` [RFC PATCH v2 3/4] " Alex G.
2018-04-24 4:19 ` [RFC,v2,3/4] " Alexandru Gagniuc
2018-04-25 14:01 ` [RFC PATCH v2 3/4] " Borislav Petkov
2018-04-25 14:01 ` [RFC,v2,3/4] " Borislav Petkov
2018-04-25 15:00 ` [RFC PATCH v2 3/4] " Alex G.
2018-04-25 15:00 ` [RFC,v2,3/4] " Alexandru Gagniuc
2018-04-25 17:15 ` [RFC PATCH v2 3/4] " Borislav Petkov
2018-04-25 17:15 ` [RFC,v2,3/4] " Borislav Petkov
2018-04-25 17:27 ` [RFC PATCH v2 3/4] " Alex G.
2018-04-25 17:27 ` [RFC,v2,3/4] " Alexandru Gagniuc
2018-04-25 17:39 ` [RFC PATCH v2 3/4] " Borislav Petkov
2018-04-25 17:39 ` [RFC,v2,3/4] " Borislav Petkov
2018-04-16 21:59 ` [RFC PATCH v2 4/4] acpi: apei: Warn when GHES marks correctable errors as "fatal" Alexandru Gagniuc
2018-04-16 21:59 ` [RFC,v2,4/4] " Alexandru Gagniuc
2018-04-18 17:54 ` [RFC PATCH v2 4/4] " Borislav Petkov
2018-04-18 17:54 ` [RFC,v2,4/4] " Borislav Petkov
2018-04-19 15:11 ` [RFC PATCH v2 4/4] " Alex G.
2018-04-19 15:11 ` [RFC,v2,4/4] " Alexandru Gagniuc
2018-04-19 15:46 ` [RFC PATCH v2 4/4] " Borislav Petkov
2018-04-19 15:46 ` [RFC,v2,4/4] " Borislav Petkov
2018-04-25 20:39 ` [RFC PATCH v3 0/3] acpi: apei: Improve PCIe error handling with firmware-first Alexandru Gagniuc
2018-04-25 20:39 ` [RFC PATCH v3 1/3] EDAC, GHES: Remove unused argument to ghes_edac_report_mem_error Alexandru Gagniuc
2018-04-25 20:39 ` [RFC,v3,1/3] " Alexandru Gagniuc
2018-04-25 20:39 ` [RFC PATCH v3 2/3] acpi: apei: Do not panic() on PCIe errors reported through GHES Alexandru Gagniuc
2018-04-25 20:39 ` [RFC,v3,2/3] " Alexandru Gagniuc
2018-04-26 11:19 ` [RFC PATCH v3 2/3] " Borislav Petkov
2018-04-26 11:19 ` [RFC,v3,2/3] " Borislav Petkov
2018-04-26 17:44 ` [RFC PATCH v3 2/3] " Alex G.
2018-04-26 17:44 ` [RFC,v3,2/3] " Alexandru Gagniuc
2018-04-25 20:39 ` [RFC PATCH v3 3/3] acpi: apei: Warn when GHES marks correctable errors as "fatal" Alexandru Gagniuc
2018-04-25 20:39 ` [RFC,v3,3/3] " Alexandru Gagniuc
2018-04-26 11:20 ` [RFC PATCH v3 3/3] " Borislav Petkov
2018-04-26 11:20 ` [RFC,v3,3/3] " Borislav Petkov
2018-04-26 17:47 ` [RFC PATCH v3 3/3] " Alex G.
2018-04-26 17:47 ` [RFC,v3,3/3] " Alexandru Gagniuc
2018-04-26 18:03 ` [RFC PATCH v3 3/3] " Borislav Petkov
2018-04-26 18:03 ` [RFC,v3,3/3] " Borislav Petkov
2018-05-02 19:10 ` [RFC PATCH v3 3/3] " Pavel Machek
2018-05-02 19:10 ` [RFC,v3,3/3] " Pavel Machek
2018-05-02 19:29 ` [RFC PATCH v3 3/3] " Alex G.
2018-05-02 19:29 ` [RFC,v3,3/3] " Alexandru Gagniuc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180419152933.GD3600@pd.tnic \
--to=bp@alien8.de \
--cc=alex_gagniuc@dellteam.com \
--cc=austin_bolen@dell.com \
--cc=devel@acpica.org \
--cc=erik.schmauss@intel.com \
--cc=gengdongjiu@huawei.com \
--cc=james.morse@arm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mr.nuke.me@gmail.com \
--cc=rjw@rjwysocki.net \
--cc=robert.moore@intel.com \
--cc=shiju.jose@huawei.com \
--cc=shyam_iyer@dell.com \
--cc=tbaicar@codeaurora.org \
--cc=tony.luck@intel.com \
--cc=will.deacon@arm.com \
--cc=zjzhang@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.