[MODERATED] Re: [patch 06/11] [PATCH v2 06/10] Linux Patch #6

[Borislav Petkov <bp@suse.de>]

On Thu, Apr 19, 2018 at 10:25:46PM -0400, speck for konrad.wilk_at_oracle.com wrote:
> x86/ssb: Provide boot parameters to select which SSB/MD mitigation to use
> 
> mdd stands for "Memory Disambiguation Disable". It is used to disable
> a common industry performance optimization known as "Speculative
> Store Bypass" in which loads from addresses to which a recent store
> has occurred may (speculatively) see an older value. Intel refers
> to this feature as "Memory Disambiguation", which is part of their
> "Smart Memory Access" capability in Haswell and later processors.

...

> +static enum ssb_mitigation_cmd __init ssb_parse_cmdline(void)
> +{
> +	char arg[20];
> +	int ret, i;
> +	enum ssb_mitigation_cmd cmd = SSB_CMD_AUTO;
> +
> +	/*
> +	 * On Intel it is exposed in CPUID as Memory Disambiguation Disable
> +	 * bit.
> +	 */
> +	if (!boot_cpu_has(X86_FEATURE_MDD))
> +                return SSB_CMD_NONE;

Some whitespace damage?

ERROR: code indent should use tabs where possible
#247: FILE: arch/x86/kernel/cpu/bugs.c:391:
+                return SSB_CMD_NONE;$

WARNING: please, no spaces at the start of a line
#247: FILE: arch/x86/kernel/cpu/bugs.c:391:
+                return SSB_CMD_NONE;$


-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--