From: Borislav Petkov <bp@alien8.de>
To: "Ghannam, Yazen" <Yazen.Ghannam@amd.com>
Cc: "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"x86@kernel.org" <x86@kernel.org>
Subject: x86/MCE, EDAC/mce_amd: Save all aux registers on SMCA systems
Date: Fri, 20 Apr 2018 20:03:01 +0200 [thread overview]
Message-ID: <20180420180301.GF13351@pd.tnic> (raw)
On Fri, Apr 20, 2018 at 01:05:17PM +0000, Ghannam, Yazen wrote:
> Okay, I can do that. What about using mce_rdmsrl()? The value gets set to
> 0 and a user gets a single warning. This may be more clear to the user. Also,
> it shouldn't affect code that checks for non-zero values, like in __print_mce().
Hmm, good point. From the looks of it, it shouldn't be a problem and a
MSR value of 0 is of no interest anyway. I *think*.
But pls make it a separate patch so that we can revert it in case
something doesn't work as expected and we've missed a case.
Thx.
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: "Ghannam, Yazen" <Yazen.Ghannam@amd.com>
Cc: "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH] x86/MCE, EDAC/mce_amd: Save all aux registers on SMCA systems
Date: Fri, 20 Apr 2018 20:03:01 +0200 [thread overview]
Message-ID: <20180420180301.GF13351@pd.tnic> (raw)
In-Reply-To: <CY4PR12MB155779EEC2894B501F30292EF8B40@CY4PR12MB1557.namprd12.prod.outlook.com>
On Fri, Apr 20, 2018 at 01:05:17PM +0000, Ghannam, Yazen wrote:
> Okay, I can do that. What about using mce_rdmsrl()? The value gets set to
> 0 and a user gets a single warning. This may be more clear to the user. Also,
> it shouldn't affect code that checks for non-zero values, like in __print_mce().
Hmm, good point. From the looks of it, it shouldn't be a problem and a
MSR value of 0 is of no interest anyway. I *think*.
But pls make it a separate patch so that we can revert it in case
something doesn't work as expected and we've missed a case.
Thx.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next reply other threads:[~2018-04-20 18:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-20 18:03 Borislav Petkov [this message]
2018-04-20 18:03 ` [PATCH] x86/MCE, EDAC/mce_amd: Save all aux registers on SMCA systems Borislav Petkov
-- strict thread matches above, loose matches on Subject: below --
2018-04-20 13:05 Yazen Ghannam
2018-04-20 13:05 ` [PATCH] " Ghannam, Yazen
2018-04-18 17:13 Borislav Petkov
2018-04-18 17:13 ` [PATCH] " Borislav Petkov
2018-04-17 18:30 Yazen Ghannam
2018-04-17 18:30 ` [PATCH] " Ghannam, Yazen
2018-04-17 17:21 Borislav Petkov
2018-04-17 17:21 ` [PATCH] " Borislav Petkov
2018-04-02 19:57 Yazen Ghannam
2018-04-02 19:57 ` [PATCH] " Yazen Ghannam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180420180301.GF13351@pd.tnic \
--to=bp@alien8.de \
--cc=Yazen.Ghannam@amd.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.