* [PATCH] drm/i915/cnl: Use mmio access to context status buffer
@ 2018-04-12 14:58 Mika Kuoppala
2018-04-12 15:06 ` Chris Wilson
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Mika Kuoppala @ 2018-04-12 14:58 UTC (permalink / raw)
To: intel-gfx; +Cc: Rodrigo Vivi
Evidence indicates that Cannonlake HWSP is not coherent
as it should. Revert to using mmio access for now.
Testcase: igt/gem_ctx_switch
References: https://bugs.freedesktop.org/show_bug.cgi?id=105888
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Rafael Antognolli <rafael.antognolli@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
---
drivers/gpu/drm/i915/intel_engine_cs.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu/drm/i915/intel_engine_cs.c
index 68898d58dd1e..1a8370779bbb 100644
--- a/drivers/gpu/drm/i915/intel_engine_cs.c
+++ b/drivers/gpu/drm/i915/intel_engine_cs.c
@@ -475,6 +475,9 @@ static bool csb_force_mmio(struct drm_i915_private *i915)
if (intel_vgpu_active(i915) && !intel_vgpu_has_hwsp_emulation(i915))
return true;
+ if (IS_CANNONLAKE(i915))
+ return true;
+
return false;
}
--
2.14.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915/cnl: Use mmio access to context status buffer
2018-04-12 14:58 [PATCH] drm/i915/cnl: Use mmio access to context status buffer Mika Kuoppala
@ 2018-04-12 15:06 ` Chris Wilson
2018-04-12 15:31 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Chris Wilson @ 2018-04-12 15:06 UTC (permalink / raw)
To: Mika Kuoppala, intel-gfx; +Cc: Rodrigo Vivi
Quoting Mika Kuoppala (2018-04-12 15:58:02)
> Evidence indicates that Cannonlake HWSP is not coherent
> as it should. Revert to using mmio access for now.
>
> Testcase: igt/gem_ctx_switch
> References: https://bugs.freedesktop.org/show_bug.cgi?id=105888
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Rafael Antognolli <rafael.antognolli@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915/cnl: Use mmio access to context status buffer
2018-04-12 14:58 [PATCH] drm/i915/cnl: Use mmio access to context status buffer Mika Kuoppala
2018-04-12 15:06 ` Chris Wilson
@ 2018-04-12 15:31 ` Patchwork
2018-04-12 16:31 ` ✓ Fi.CI.IGT: " Patchwork
2018-04-20 21:43 ` [PATCH] " Rodrigo Vivi
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-04-12 15:31 UTC (permalink / raw)
To: Mika Kuoppala; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/cnl: Use mmio access to context status buffer
URL : https://patchwork.freedesktop.org/series/41630/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4049 -> Patchwork_8679 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/41630/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_8679 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_mmap_gtt@basic-small-bo-tiledx:
fi-gdg-551: PASS -> FAIL (fdo#102575)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
fi-bxt-dsi: PASS -> INCOMPLETE (fdo#103927)
fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
== Participating hosts (35 -> 33) ==
Additional (1): fi-cnl-y3
Missing (3): fi-ctg-p8600 fi-ilk-m540 fi-skl-6700hq
== Build changes ==
* Linux: CI_DRM_4049 -> Patchwork_8679
CI_DRM_4049: 3dbfa04d62f1f1214a03c3b2d30f987dccf50ab4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4426: d502f055ac4500cada758876a512ac4f14b34851 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_8679: ec952dc37d185165b612080cc6f1683593c275a1 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4426: 93b35926a150e318439d2505901288594b3548f5 @ git://anongit.freedesktop.org/piglit
== Linux commits ==
ec952dc37d18 drm/i915/cnl: Use mmio access to context status buffer
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8679/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* ✓ Fi.CI.IGT: success for drm/i915/cnl: Use mmio access to context status buffer
2018-04-12 14:58 [PATCH] drm/i915/cnl: Use mmio access to context status buffer Mika Kuoppala
2018-04-12 15:06 ` Chris Wilson
2018-04-12 15:31 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-04-12 16:31 ` Patchwork
2018-04-20 21:43 ` [PATCH] " Rodrigo Vivi
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-04-12 16:31 UTC (permalink / raw)
To: Mika Kuoppala; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/cnl: Use mmio access to context status buffer
URL : https://patchwork.freedesktop.org/series/41630/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4049_full -> Patchwork_8679_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_8679_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_8679_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/41630/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_8679_full:
=== IGT changes ===
==== Warnings ====
igt@gem_mocs_settings@mocs-rc6-blt:
shard-kbl: PASS -> SKIP
igt@gem_mocs_settings@mocs-rc6-vebox:
shard-kbl: SKIP -> PASS
== Known issues ==
Here are the changes found in Patchwork_8679_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
shard-hsw: PASS -> FAIL (fdo#102887) +1
igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw:
shard-apl: PASS -> FAIL (fdo#103167)
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-render:
shard-snb: PASS -> FAIL (fdo#103167)
igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence:
shard-apl: PASS -> FAIL (fdo#103191)
==== Possible fixes ====
igt@kms_flip@2x-dpms-vs-vblank-race-interruptible:
shard-hsw: FAIL (fdo#103060) -> PASS +1
igt@kms_flip@plain-flip-ts-check-interruptible:
shard-hsw: FAIL (fdo#100368) -> PASS +1
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
== Participating hosts (6 -> 4) ==
Missing (2): shard-glk shard-glkb
== Build changes ==
* Linux: CI_DRM_4049 -> Patchwork_8679
CI_DRM_4049: 3dbfa04d62f1f1214a03c3b2d30f987dccf50ab4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4426: d502f055ac4500cada758876a512ac4f14b34851 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_8679: ec952dc37d185165b612080cc6f1683593c275a1 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4426: 93b35926a150e318439d2505901288594b3548f5 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8679/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915/cnl: Use mmio access to context status buffer
2018-04-12 14:58 [PATCH] drm/i915/cnl: Use mmio access to context status buffer Mika Kuoppala
` (2 preceding siblings ...)
2018-04-12 16:31 ` ✓ Fi.CI.IGT: " Patchwork
@ 2018-04-20 21:43 ` Rodrigo Vivi
3 siblings, 0 replies; 5+ messages in thread
From: Rodrigo Vivi @ 2018-04-20 21:43 UTC (permalink / raw)
To: Mika Kuoppala; +Cc: intel-gfx
On Thu, Apr 12, 2018 at 05:58:02PM +0300, Mika Kuoppala wrote:
> Evidence indicates that Cannonlake HWSP is not coherent
> as it should. Revert to using mmio access for now.
>
> Testcase: igt/gem_ctx_switch
> References: https://bugs.freedesktop.org/show_bug.cgi?id=105888
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Rafael Antognolli <rafael.antognolli@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/intel_engine_cs.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu/drm/i915/intel_engine_cs.c
> index 68898d58dd1e..1a8370779bbb 100644
> --- a/drivers/gpu/drm/i915/intel_engine_cs.c
> +++ b/drivers/gpu/drm/i915/intel_engine_cs.c
> @@ -475,6 +475,9 @@ static bool csb_force_mmio(struct drm_i915_private *i915)
> if (intel_vgpu_active(i915) && !intel_vgpu_has_hwsp_emulation(i915))
> return true;
>
> + if (IS_CANNONLAKE(i915))
> + return true;
> +
> return false;
> }
>
> --
> 2.14.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-04-20 21:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-12 14:58 [PATCH] drm/i915/cnl: Use mmio access to context status buffer Mika Kuoppala
2018-04-12 15:06 ` Chris Wilson
2018-04-12 15:31 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-04-12 16:31 ` ✓ Fi.CI.IGT: " Patchwork
2018-04-20 21:43 ` [PATCH] " Rodrigo Vivi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.