* [PATCH] iio: adc: select buffer for at91-sama5d2_adc
@ 2018-04-16 6:54 ` Eugen Hristev
0 siblings, 0 replies; 4+ messages in thread
From: Eugen Hristev @ 2018-04-16 6:54 UTC (permalink / raw)
To: jic23, ludovic.desroches, linux-arm-kernel, linux-kernel,
linux-iio, nicolas.ferre
Cc: Eugen Hristev
We need to select the buffer code, otherwise we get build errors
with undefined functions on the trigger and buffer,
if we select just IIO and then AT91_SAMA5D2_ADC from menuconfig
This adds a Kconfig 'select' statement like other ADC
drivers have it already.
Fixes: 5e1a1da0f8c9 ("iio: adc: at91-sama5d2_adc: add hw trigger and buffer support")
Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
---
Hello Jonathan,
While you are at it, I also found this small kconfig issue during my tests.
Would be good to have as a fix as well.
Thanks,
Eugen
drivers/iio/adc/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index 15606f2..9da7907 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -158,6 +158,7 @@ config AT91_SAMA5D2_ADC
depends on ARCH_AT91 || COMPILE_TEST
depends on HAS_IOMEM
depends on HAS_DMA
+ select IIO_BUFFER
select IIO_TRIGGERED_BUFFER
help
Say yes here to build support for Atmel SAMA5D2 ADC which is
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] iio: adc: select buffer for at91-sama5d2_adc
@ 2018-04-16 6:54 ` Eugen Hristev
0 siblings, 0 replies; 4+ messages in thread
From: Eugen Hristev @ 2018-04-16 6:54 UTC (permalink / raw)
To: linux-arm-kernel
We need to select the buffer code, otherwise we get build errors
with undefined functions on the trigger and buffer,
if we select just IIO and then AT91_SAMA5D2_ADC from menuconfig
This adds a Kconfig 'select' statement like other ADC
drivers have it already.
Fixes: 5e1a1da0f8c9 ("iio: adc: at91-sama5d2_adc: add hw trigger and buffer support")
Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
---
Hello Jonathan,
While you are at it, I also found this small kconfig issue during my tests.
Would be good to have as a fix as well.
Thanks,
Eugen
drivers/iio/adc/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index 15606f2..9da7907 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -158,6 +158,7 @@ config AT91_SAMA5D2_ADC
depends on ARCH_AT91 || COMPILE_TEST
depends on HAS_IOMEM
depends on HAS_DMA
+ select IIO_BUFFER
select IIO_TRIGGERED_BUFFER
help
Say yes here to build support for Atmel SAMA5D2 ADC which is
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] iio: adc: select buffer for at91-sama5d2_adc
2018-04-16 6:54 ` Eugen Hristev
@ 2018-04-21 14:58 ` Jonathan Cameron
-1 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2018-04-21 14:58 UTC (permalink / raw)
To: Eugen Hristev
Cc: ludovic.desroches, linux-arm-kernel, linux-kernel, linux-iio,
nicolas.ferre
On Mon, 16 Apr 2018 09:54:03 +0300
Eugen Hristev <eugen.hristev@microchip.com> wrote:
> We need to select the buffer code, otherwise we get build errors
> with undefined functions on the trigger and buffer,
> if we select just IIO and then AT91_SAMA5D2_ADC from menuconfig
>
> This adds a Kconfig 'select' statement like other ADC
> drivers have it already.
>
> Fixes: 5e1a1da0f8c9 ("iio: adc: at91-sama5d2_adc: add hw trigger and buffer support")
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
Applied to the fixes-togreg branch of iio.git and marked for stable.
Thanks,
Jonathan
> ---
> Hello Jonathan,
>
> While you are at it, I also found this small kconfig issue during my tests.
> Would be good to have as a fix as well.
>
> Thanks,
> Eugen
>
> drivers/iio/adc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index 15606f2..9da7907 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -158,6 +158,7 @@ config AT91_SAMA5D2_ADC
> depends on ARCH_AT91 || COMPILE_TEST
> depends on HAS_IOMEM
> depends on HAS_DMA
> + select IIO_BUFFER
> select IIO_TRIGGERED_BUFFER
> help
> Say yes here to build support for Atmel SAMA5D2 ADC which is
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] iio: adc: select buffer for at91-sama5d2_adc
@ 2018-04-21 14:58 ` Jonathan Cameron
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2018-04-21 14:58 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, 16 Apr 2018 09:54:03 +0300
Eugen Hristev <eugen.hristev@microchip.com> wrote:
> We need to select the buffer code, otherwise we get build errors
> with undefined functions on the trigger and buffer,
> if we select just IIO and then AT91_SAMA5D2_ADC from menuconfig
>
> This adds a Kconfig 'select' statement like other ADC
> drivers have it already.
>
> Fixes: 5e1a1da0f8c9 ("iio: adc: at91-sama5d2_adc: add hw trigger and buffer support")
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
Applied to the fixes-togreg branch of iio.git and marked for stable.
Thanks,
Jonathan
> ---
> Hello Jonathan,
>
> While you are at it, I also found this small kconfig issue during my tests.
> Would be good to have as a fix as well.
>
> Thanks,
> Eugen
>
> drivers/iio/adc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index 15606f2..9da7907 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -158,6 +158,7 @@ config AT91_SAMA5D2_ADC
> depends on ARCH_AT91 || COMPILE_TEST
> depends on HAS_IOMEM
> depends on HAS_DMA
> + select IIO_BUFFER
> select IIO_TRIGGERED_BUFFER
> help
> Say yes here to build support for Atmel SAMA5D2 ADC which is
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-04-21 14:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-16 6:54 [PATCH] iio: adc: select buffer for at91-sama5d2_adc Eugen Hristev
2018-04-16 6:54 ` Eugen Hristev
2018-04-21 14:58 ` Jonathan Cameron
2018-04-21 14:58 ` Jonathan Cameron
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.