From: gregkh at linuxfoundation.org (Greg Kroah-Hartman)
Subject: [PATCH driver-core 2/2] test_firmware: fix setting old custom fw path back on exit, second try
Date: Mon, 23 Apr 2018 12:45:04 +0200 [thread overview]
Message-ID: <20180423104504.GA26502@kroah.com> (raw)
In-Reply-To: <20180418203808.GQ30543@wotan.suse.de>
On Wed, Apr 18, 2018 at 10:38:09PM +0200, Luis R. Rodriguez wrote:
> On Wed, Apr 04, 2018 at 10:38:49PM +0200, Ben Hutchings wrote:
> > Commit 65c79230576 tried to clear the custom firmware path on exit by
> > writing a single space to the firmware_class.path parameter. This
> > doesn't work because nothing strips this space from the value stored
> > and fw_get_filesystem_firmware() only ignores zero-length paths.
> >
> > Instead, write a null byte.
> >
> > Fixes: 0a8adf58475 ("test: add firmware_class loader test")
> > Fixes: 65c79230576 ("test_firmware: fix setting old custom fw path back on exit")
> > Signed-off-by: Ben Hutchings <ben.hutchings at codethink.co.uk>
>
> Acked-by: Luis R. Rodriguez <mcgrof at kernel.org>
>
> Greg, let me know if you want to take these two in now, or if you want me to
> queue them up on my own and then send you what I get in the queue later.
I can take them now, thanks.
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (Greg Kroah-Hartman)
Subject: [PATCH driver-core 2/2] test_firmware: fix setting old custom fw path back on exit, second try
Date: Mon, 23 Apr 2018 12:45:04 +0200 [thread overview]
Message-ID: <20180423104504.GA26502@kroah.com> (raw)
Message-ID: <20180423104504.mR2U94xBIC5kaRNTVZXlTI6dED5rGVbxcPBONme22DQ@z> (raw)
In-Reply-To: <20180418203808.GQ30543@wotan.suse.de>
On Wed, Apr 18, 2018@10:38:09PM +0200, Luis R. Rodriguez wrote:
> On Wed, Apr 04, 2018@10:38:49PM +0200, Ben Hutchings wrote:
> > Commit 65c79230576 tried to clear the custom firmware path on exit by
> > writing a single space to the firmware_class.path parameter. This
> > doesn't work because nothing strips this space from the value stored
> > and fw_get_filesystem_firmware() only ignores zero-length paths.
> >
> > Instead, write a null byte.
> >
> > Fixes: 0a8adf58475 ("test: add firmware_class loader test")
> > Fixes: 65c79230576 ("test_firmware: fix setting old custom fw path back on exit")
> > Signed-off-by: Ben Hutchings <ben.hutchings at codethink.co.uk>
>
> Acked-by: Luis R. Rodriguez <mcgrof at kernel.org>
>
> Greg, let me know if you want to take these two in now, or if you want me to
> queue them up on my own and then send you what I get in the queue later.
I can take them now, thanks.
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Luis R. Rodriguez" <mcgrof@kernel.org>
Cc: Ben Hutchings <ben.hutchings@codethink.co.uk>,
Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH driver-core 2/2] test_firmware: fix setting old custom fw path back on exit, second try
Date: Mon, 23 Apr 2018 12:45:04 +0200 [thread overview]
Message-ID: <20180423104504.GA26502@kroah.com> (raw)
In-Reply-To: <20180418203808.GQ30543@wotan.suse.de>
On Wed, Apr 18, 2018 at 10:38:09PM +0200, Luis R. Rodriguez wrote:
> On Wed, Apr 04, 2018 at 10:38:49PM +0200, Ben Hutchings wrote:
> > Commit 65c79230576 tried to clear the custom firmware path on exit by
> > writing a single space to the firmware_class.path parameter. This
> > doesn't work because nothing strips this space from the value stored
> > and fw_get_filesystem_firmware() only ignores zero-length paths.
> >
> > Instead, write a null byte.
> >
> > Fixes: 0a8adf58475 ("test: add firmware_class loader test")
> > Fixes: 65c79230576 ("test_firmware: fix setting old custom fw path back on exit")
> > Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
>
> Acked-by: Luis R. Rodriguez <mcgrof@kernel.org>
>
> Greg, let me know if you want to take these two in now, or if you want me to
> queue them up on my own and then send you what I get in the queue later.
I can take them now, thanks.
greg k-h
next prev parent reply other threads:[~2018-04-23 10:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 20:37 [PATCH driver-core 1/2] test_firmware: Install all scripts ben.hutchings
2018-04-04 20:37 ` Ben Hutchings
2018-04-04 20:37 ` Ben Hutchings
2018-04-04 20:38 ` [PATCH driver-core 2/2] test_firmware: fix setting old custom fw path back on exit, second try ben.hutchings
2018-04-04 20:38 ` Ben Hutchings
2018-04-04 20:38 ` Ben Hutchings
2018-04-18 20:38 ` mcgrof
2018-04-18 20:38 ` Luis R. Rodriguez
2018-04-18 20:38 ` Luis R. Rodriguez
2018-04-23 10:45 ` gregkh [this message]
2018-04-23 10:45 ` Greg Kroah-Hartman
2018-04-23 10:45 ` Greg Kroah-Hartman
2018-04-18 20:35 ` [PATCH driver-core 1/2] test_firmware: Install all scripts mcgrof
2018-04-18 20:35 ` Luis R. Rodriguez
2018-04-18 20:35 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180423104504.GA26502@kroah.com \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.