All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "David Woodhouse" <dwmw2@infradead.org>,
	"Brian Norris" <computersforpeace@gmail.com>,
	"Marek Vasut" <marek.vasut@gmail.com>,
	"Richard Weinberger" <richard@nod.at>,
	"Cyrille Pitchen" <cyrille.pitchen@wedev4u.fr>,
	"open list:MEMORY TECHNOLOGY..." <linux-mtd@lists.infradead.org>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Mark Brown" <broonie@kernel.org>,
	linux-spi <linux-spi@vger.kernel.org>,
	"Peter Pan" <peterpansjtu@gmail.com>,
	"Frieder Schrempf" <frieder.schrempf@exceet.de>,
	"Vignesh R" <vigneshr@ti.com>,
	"Yogesh Gaur" <yogeshnarayan.gaur@nxp.com>,
	"Rafał Miłecki" <rafal@milecki.pl>,
	"Kamal Dasu" <kdasu.kdev@gmail.com>,
	"Maxime Chevallier" <maxime.chevallier@bootlin.com>
Subject: Re: [PATCH v3 3/9] spi: Extend the core to ease integration of SPI memory controllers
Date: Tue, 24 Apr 2018 00:10:04 +0200	[thread overview]
Message-ID: <20180424000805.6c015a40@bbrezillon> (raw)
In-Reply-To: <CAHp75VfNzxGoSk==sdnOzp7LhuHVuanWAHOQk0eQC_g3Y3miQA@mail.gmail.com>

Hi Andy,

On Tue, 24 Apr 2018 00:53:22 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> On Sun, Apr 22, 2018 at 9:35 PM, Boris Brezillon
> <boris.brezillon@bootlin.com> wrote:
> > Some controllers are exposing high-level interfaces to access various
> > kind of SPI memories. Unfortunately they do not fit in the current
> > spi_controller model and usually have drivers placed in
> > drivers/mtd/spi-nor which are only supporting SPI NORs and not SPI
> > memories in general.
> >
> > This is an attempt at defining a SPI memory interface which works for
> > all kinds of SPI memories (NORs, NANDs, SRAMs).  
> 
> > +config SPI_MEM
> > +       bool "SPI memory extension"  
> 
> > +#if IS_ENABLED(CONFIG_SPI_MEM)  
> 
> IS_BUILTIN().
> You defined it as boolean, IS_ENABLE() is superfluous.

Sorry but I don't see the problem here. Yes, IS_BUILTIN() would work,
but IS_ENABLED() works fine too and has not impact on runtime perfs
(and probably near zero impact on compilation time). Anyway, I'll let
Mark decide if this is important enough to send a new version.

Regards,

Boris

WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Yogesh Gaur" <yogeshnarayan.gaur@nxp.com>,
	"Vignesh R" <vigneshr@ti.com>,
	"Kamal Dasu" <kdasu.kdev@gmail.com>,
	"Richard Weinberger" <richard@nod.at>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	linux-spi <linux-spi@vger.kernel.org>,
	"Peter Pan" <peterpansjtu@gmail.com>,
	"Marek Vasut" <marek.vasut@gmail.com>,
	"Frieder Schrempf" <frieder.schrempf@exceet.de>,
	"Mark Brown" <broonie@kernel.org>,
	"open list:MEMORY TECHNOLOGY..." <linux-mtd@lists.infradead.org>,
	"Cyrille Pitchen" <cyrille.pitchen@wedev4u.fr>,
	"Rafał Miłecki" <rafal@milecki.pl>,
	"Maxime Chevallier" <maxime.chevallier@bootlin.com>,
	"Brian Norris" <computersforpeace@gmail.com>,
	"David Woodhouse" <dwmw2@infradead.org>
Subject: Re: [PATCH v3 3/9] spi: Extend the core to ease integration of SPI memory controllers
Date: Tue, 24 Apr 2018 00:10:04 +0200	[thread overview]
Message-ID: <20180424000805.6c015a40@bbrezillon> (raw)
In-Reply-To: <CAHp75VfNzxGoSk==sdnOzp7LhuHVuanWAHOQk0eQC_g3Y3miQA@mail.gmail.com>

Hi Andy,

On Tue, 24 Apr 2018 00:53:22 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> On Sun, Apr 22, 2018 at 9:35 PM, Boris Brezillon
> <boris.brezillon@bootlin.com> wrote:
> > Some controllers are exposing high-level interfaces to access various
> > kind of SPI memories. Unfortunately they do not fit in the current
> > spi_controller model and usually have drivers placed in
> > drivers/mtd/spi-nor which are only supporting SPI NORs and not SPI
> > memories in general.
> >
> > This is an attempt at defining a SPI memory interface which works for
> > all kinds of SPI memories (NORs, NANDs, SRAMs).  
> 
> > +config SPI_MEM
> > +       bool "SPI memory extension"  
> 
> > +#if IS_ENABLED(CONFIG_SPI_MEM)  
> 
> IS_BUILTIN().
> You defined it as boolean, IS_ENABLE() is superfluous.

Sorry but I don't see the problem here. Yes, IS_BUILTIN() would work,
but IS_ENABLED() works fine too and has not impact on runtime perfs
(and probably near zero impact on compilation time). Anyway, I'll let
Mark decide if this is important enough to send a new version.

Regards,

Boris

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2018-04-23 22:10 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-22 18:35 [PATCH v3 0/9] spi: Extend the framework to generically support memory devices Boris Brezillon
2018-04-22 18:35 ` Boris Brezillon
2018-04-22 18:35 ` [PATCH v3 1/9] spi: Expose spi_{map,unmap}_buf() for internal use Boris Brezillon
2018-04-22 18:35   ` Boris Brezillon
2018-04-23 18:05   ` Applied "spi: Expose spi_{map, unmap}_buf() for internal use" to the spi tree Mark Brown
2018-04-23 18:05     ` Mark Brown
2018-04-22 18:35 ` [PATCH v3 2/9] spi: Add an helper to flush the message queue Boris Brezillon
2018-04-22 18:35   ` Boris Brezillon
2018-04-23 18:05   ` Applied "spi: Add an helper to flush the message queue" to the spi tree Mark Brown
2018-04-23 18:05     ` Mark Brown
2018-04-22 18:35 ` [PATCH v3 3/9] spi: Extend the core to ease integration of SPI memory controllers Boris Brezillon
2018-04-22 18:35   ` Boris Brezillon
2018-04-23 21:53   ` Andy Shevchenko
2018-04-23 21:53     ` Andy Shevchenko
2018-04-23 22:10     ` Boris Brezillon [this message]
2018-04-23 22:10       ` Boris Brezillon
2018-04-24 10:47       ` Mark Brown
2018-04-24 10:47         ` Mark Brown
2018-05-11  2:58   ` Applied "spi: Extend the core to ease integration of SPI memory controllers" to the spi tree Mark Brown
2018-05-11  2:58     ` Mark Brown
2018-04-22 18:35 ` [PATCH v3 4/9] spi: Make support for regular transfers optional when ->mem_ops != NULL Boris Brezillon
2018-04-22 18:35   ` Boris Brezillon
2018-04-22 18:35 ` [PATCH v3 5/9] spi: bcm-qspi: Implement the spi_mem interface Boris Brezillon
2018-04-22 18:35   ` Boris Brezillon
2018-04-24 15:19   ` Kamal Dasu
2018-04-24 15:19     ` Kamal Dasu
2018-04-22 18:35 ` [PATCH v3 6/9] spi: bcm53xx: " Boris Brezillon
2018-04-22 18:35   ` Boris Brezillon
2018-04-22 18:35 ` [PATCH v3 7/9] spi: ti-qspi: " Boris Brezillon
2018-04-22 18:35   ` Boris Brezillon
2018-04-26  9:10   ` Vignesh R
2018-04-26  9:10     ` Vignesh R
2018-04-26  9:28     ` Boris Brezillon
2018-04-26  9:28       ` Boris Brezillon
2018-04-22 18:35 ` [PATCH v3 8/9] mtd: spi-nor: Use the spi_mem_xx() API Boris Brezillon
2018-04-22 18:35   ` Boris Brezillon
2018-04-22 18:35 ` [PATCH v3 9/9] spi: Get rid of the spi_flash_read() API Boris Brezillon
2018-04-22 18:35   ` Boris Brezillon
2018-05-11  9:24   ` Boris Brezillon
2018-05-11  9:24     ` Boris Brezillon
2018-04-26  9:07 ` [PATCH v3 0/9] spi: Extend the framework to generically support memory devices Vignesh R
2018-04-26  9:07   ` Vignesh R
2018-04-26  9:27   ` Boris Brezillon
2018-04-26  9:27     ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180424000805.6c015a40@bbrezillon \
    --to=boris.brezillon@bootlin.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=broonie@kernel.org \
    --cc=computersforpeace@gmail.com \
    --cc=cyrille.pitchen@wedev4u.fr \
    --cc=dwmw2@infradead.org \
    --cc=frieder.schrempf@exceet.de \
    --cc=kdasu.kdev@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=marek.vasut@gmail.com \
    --cc=maxime.chevallier@bootlin.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=peterpansjtu@gmail.com \
    --cc=rafal@milecki.pl \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    --cc=yogeshnarayan.gaur@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.